From bbb622aaa6b6c9aeb125d1c1c5c9225ced5c8009 Mon Sep 17 00:00:00 2001 From: Austin Shalit Date: Sat, 28 Jul 2018 12:50:25 -0400 Subject: [PATCH] Revert "Use ASAN when on Clang (#1187)" (#1234) This reverts commit 340b26badaac3eddf89e39e0cc8f293e09808fc3. Closes #1232 We are reverting this because it broke Mac builds. The root cause of this is a requirement that the entire application must be built with ASAN to link properly. For more information about why this is see the below link. https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow#false-positives --- shared/googletest.gradle | 9 --------- 1 file changed, 9 deletions(-) diff --git a/shared/googletest.gradle b/shared/googletest.gradle index 6b40e36b92..fa471f6dc2 100644 --- a/shared/googletest.gradle +++ b/shared/googletest.gradle @@ -10,13 +10,4 @@ model { staticConfigs = project.staticGtestConfigs } } - binaries { - withType(GoogleTestTestSuiteBinarySpec) { - if (toolChain instanceof Clang) { - println "Clang Detected - Using ASAN" - cppCompiler.args << '-fsanitize=address' - linker.args << '-fsanitize=address' - } - } - } }