Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[cmd2] CommandScheduler::Cancel(): Don't mutate in for loop (#8743)

Browse Source 
Erasing elements from a container while iterating over the container may
not be well-defined.
This commit is contained in:
Peter Johnson
2026-04-10 12:30:00 -07:00
committed by GitHub
parent ea06f0b257
commit bc984234e9
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
commandsv2/src/main/native/cpp/frc2/command/CommandScheduler.cpp
View File

@@ -315,11 +315,15 @@ void CommandScheduler::Cancel(Command* command,
for (auto&& action : m_impl->interruptActions) {
action(*command, interruptor);
}
wpi::util::SmallVector<Subsystem*, 8> toErase;
for (auto&& requirement : m_impl->requirements) {
if (requirement.second == command) {
m_impl->requirements.erase(requirement.first);
toErase.push_back(requirement.first);
}
}
for (auto* subsystem : toErase) {
m_impl->requirements.erase(subsystem);
}
m_watchdog.AddEpoch(command->GetName() + ".End(true)");
}