Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-03 03:01:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable frivolous PMD warnings and enable PMD in ntcore (#3419)

Browse Source 
Some valid warnings like throwing NullPointerException or using a for
loop instead of System.arraycopy() were fixed.

Abstract classes marked with PMD.AbstractClassWithoutAbstractMethod were
made concrete because they already had protected constructors.

Fixes #1697.
This commit is contained in:
Tyler Veness
2021-06-09 07:01:00 -07:00
committed by GitHub
parent 8284075ee4
commit c1e128bd5a
93 changed files with 154 additions and 326 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cscore/src/main/java/edu/wpi/first/cscore/VideoEvent.java
View File

@@ -46,7 +46,6 @@ public class VideoEvent {
* @param kind The numerical representation of kind
* @return The kind
*/
@SuppressWarnings("PMD.CyclomaticComplexity")
public static Kind getKindFromInt(int kind) {
switch (kind) {
case 0x0001:
@@ -92,7 +91,6 @@ public class VideoEvent {
}
}
@SuppressWarnings("PMD.ExcessiveParameterList")
VideoEvent(
int kind,
int source,

2
cscore/src/main/java/edu/wpi/first/cscore/VideoSink.java
View File

@@ -112,7 +112,6 @@ public class VideoSink implements AutoCloseable {
}
/** Enumerate all properties of this sink. */
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
public VideoProperty[] enumerateProperties() {
int[] handles = CameraServerJNI.enumerateSinkProperties(m_handle);
VideoProperty[] rv = new VideoProperty[handles.length];
@@ -195,7 +194,6 @@ public class VideoSink implements AutoCloseable {
*
* @return Vector of sinks.
*/
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
public static VideoSink[] enumerateSinks() {
int[] handles = CameraServerJNI.enumerateSinks();
VideoSink[] rv = new VideoSink[handles.length];

3
cscore/src/main/java/edu/wpi/first/cscore/VideoSource.java
View File

@@ -179,7 +179,6 @@ public class VideoSource implements AutoCloseable {
}
/** Enumerate all properties of this source. */
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
public VideoProperty[] enumerateProperties() {
int[] handles = CameraServerJNI.enumerateSourceProperties(m_handle);
VideoProperty[] rv = new VideoProperty[handles.length];
@@ -323,7 +322,6 @@ public class VideoSource implements AutoCloseable {
*
* @return Vector of sinks.
*/
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
public VideoSink[] enumerateSinks() {
int[] handles = CameraServerJNI.enumerateSourceSinks(m_handle);
VideoSink[] rv = new VideoSink[handles.length];
@@ -338,7 +336,6 @@ public class VideoSource implements AutoCloseable {
*
* @return Vector of sources.
*/
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
public static VideoSource[] enumerateSources() {
int[] handles = CameraServerJNI.enumerateSources();
VideoSource[] rv = new VideoSource[handles.length];