Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-05 03:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpinet] WebSocket: Send pong in response to ping (#5498)

Browse Source 
This is required by the spec (RFC 6455 section 5.5.2).
This commit is contained in:
Peter Johnson
2023-08-04 16:27:08 -07:00
committed by GitHub
parent e2d17a24a6
commit c52dad609e
3 changed files with 56 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
wpinet/src/main/native/cpp/WebSocket.cpp
View File

@@ -573,6 +573,19 @@ void WebSocket::HandleIncoming(uv::Buffer& buf, size_t size) {
if (!fin) {
return Fail(1002, "cannot fragment control frames");
}
// If the connection is open, send a Pong in response
if (m_state == OPEN) {
SmallVector<uv::Buffer, 4> bufs;
{
raw_uv_ostream os{bufs, 4096};
os << m_payload;
}
SendPong(bufs, [](auto bufs, uv::Error) {
for (auto&& buf : bufs) {
buf.Deallocate();
}
});
}
ping(m_payload);
break;
case kOpPong:

3
wpinet/src/main/native/include/wpinet/WebSocket.h
View File

@@ -460,7 +460,8 @@ class WebSocket : public std::enable_shared_from_this<WebSocket> {
sig::Signal<std::span<const uint8_t>, bool> binary;
/**
* Ping event. Emitted when a ping message is received.
* Ping event. Emitted when a ping message is received. A pong message is
* automatically sent in response, so this is simply a notification.
*/
sig::Signal<std::span<const uint8_t>> ping;