From c569d8e523fe8d924b86643ecd558a3268720fff Mon Sep 17 00:00:00 2001 From: Sriman Achanta <68172138+srimanachanta@users.noreply.github.com> Date: Wed, 14 Dec 2022 01:29:09 -0500 Subject: [PATCH] [wpilib] Joystick.getMagnitude(): use hypot() function (#4816) --- wpilibc/src/main/native/cpp/Joystick.cpp | 2 +- wpilibj/src/main/java/edu/wpi/first/wpilibj/Joystick.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/wpilibc/src/main/native/cpp/Joystick.cpp b/wpilibc/src/main/native/cpp/Joystick.cpp index 4a7b91f807..0eff22612f 100644 --- a/wpilibc/src/main/native/cpp/Joystick.cpp +++ b/wpilibc/src/main/native/cpp/Joystick.cpp @@ -116,7 +116,7 @@ BooleanEvent Joystick::Top(EventLoop* loop) const { } double Joystick::GetMagnitude() const { - return std::sqrt(std::pow(GetX(), 2) + std::pow(GetY(), 2)); + return std::hypot(GetX(), GetY()); } double Joystick::GetDirectionRadians() const { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Joystick.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Joystick.java index e91bf322d7..d73b7bbc25 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Joystick.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Joystick.java @@ -291,7 +291,7 @@ public class Joystick extends GenericHID { * @return The magnitude of the direction vector */ public double getMagnitude() { - return Math.sqrt(Math.pow(getX(), 2) + Math.pow(getY(), 2)); + return Math.hypot(getX(), getY()); } /**