Uses ComputeDigitalMask function across HAL DIO (#837)

less risk for errors in the future.
This commit is contained in:
Thad House
2018-04-29 21:12:15 -07:00
committed by Peter Johnson
parent 11b99a016a
commit c84bd744c8
3 changed files with 43 additions and 116 deletions

View File

@@ -47,24 +47,20 @@ void InitializeDigitalInternal() {
namespace detail {
wpi::mutex& UnsafeGetDIOMutex() { return digitalDIOMutex; }
tDIO* UnsafeGetDigialSystem() { return digitalSystem.get(); }
int32_t ComputeDigitalMask(HAL_DigitalHandle handle, int32_t* status) {
auto port = digitalChannelHandles->Get(handle, HAL_HandleEnum::DIO);
if (port == nullptr) {
*status = HAL_HANDLE_ERROR;
return 0;
}
} // namespace detail
int32_t ComputeDigitalMask(uint8_t channel) {
tDIO::tDO output;
output.value = 0;
if (port->channel >= kNumDigitalHeaders + kNumDigitalMXPChannels) {
output.SPIPort = (1u << remapSPIChannel(port->channel));
} else if (port->channel < kNumDigitalHeaders) {
output.Headers = (1u << port->channel);
if (channel >= kNumDigitalHeaders + kNumDigitalMXPChannels) {
output.SPIPort = (1u << remapSPIChannel(channel));
} else if (channel < kNumDigitalHeaders) {
output.Headers = (1u << channel);
} else {
output.MXP = (1u << remapMXPChannel(port->channel));
output.MXP = (1u << remapMXPChannel(channel));
}
return output.value;
}
} // namespace detail
/**
* Initialize the digital system.