Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-27 02:01:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[build] Fix Gradle compile_commands.json and clang-tidy warnings (#5977)

Browse Source
This commit is contained in:
Tyler Veness
2023-12-02 21:20:43 -08:00
committed by GitHub
parent 76ae090570
commit ca272de400
11 changed files with 123 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
cscore/src/main/native/linux/NetworkListener.cpp
View File

@@ -89,6 +89,7 @@ void NetworkListener::Impl::Thread::Main() {
std::memset(&addr, 0, sizeof(addr));
addr.nl_family = AF_NETLINK;
addr.nl_groups = RTMGRP_LINK | RTMGRP_IPV4_IFADDR;
// NOLINTNEXTLINE(modernize-avoid-bind)
if (bind(sd, reinterpret_cast<struct sockaddr*>(&addr), sizeof(addr)) < 0) {
ERROR("NetworkListener: could not create socket: {}", std::strerror(errno));
::close(sd);

3
cscore/src/main/native/windows/WindowsMessagePump.cpp
View File

@@ -99,8 +99,9 @@ WindowsMessagePump::WindowsMessagePump(
WindowsMessagePump::~WindowsMessagePump() {
auto res = SendMessageA(hwnd, WM_CLOSE, NULL, NULL);
if (m_mainThread.joinable())
if (m_mainThread.joinable()) {
m_mainThread.join();
}
}
void WindowsMessagePump::ThreadMain(HANDLE eventHandle) {