Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: google-explicit-constructor

Browse Source
This commit is contained in:
Peter Johnson
2020-12-28 11:18:07 -08:00
parent c97c6dc065
commit cbe59fa3bf
15 changed files with 26 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wpilibNewCommands/src/main/native/include/frc2/command/InstantCommand.h
View File

@@ -37,8 +37,8 @@ class InstantCommand : public CommandHelper<CommandBase, InstantCommand> {
* @param toRun the Runnable to run
* @param requirements the subsystems required by this command
*/
InstantCommand(std::function<void()> toRun,
wpi::ArrayRef<Subsystem*> requirements = {});
explicit InstantCommand(std::function<void()> toRun,
wpi::ArrayRef<Subsystem*> requirements = {});
InstantCommand(InstantCommand&& other) = default;

4
wpilibNewCommands/src/main/native/include/frc2/command/RunCommand.h
View File

@@ -38,8 +38,8 @@ class RunCommand : public CommandHelper<CommandBase, RunCommand> {
* @param toRun the Runnable to run
* @param requirements the subsystems to require
*/
RunCommand(std::function<void()> toRun,
wpi::ArrayRef<Subsystem*> requirements = {});
explicit RunCommand(std::function<void()> toRun,
wpi::ArrayRef<Subsystem*> requirements = {});
RunCommand(RunCommand&& other) = default;

4
wpilibNewCommands/src/main/native/include/frc2/command/SelectCommand.h
View File

@@ -48,8 +48,8 @@ class SelectCommand : public CommandHelper<CommandBase, SelectCommand<Key>> {
template <class... Types,
typename = std::enable_if_t<std::conjunction_v<
std::is_base_of<Command, std::remove_reference_t<Types>>...>>>
SelectCommand(std::function<Key()> selector,
std::pair<Key, Types>... commands)
explicit SelectCommand(std::function<Key()> selector,
std::pair<Key, Types>... commands)
: m_selector{std::move(selector)} {
std::vector<std::pair<Key, std::unique_ptr<Command>>> foo;