Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-04 03:11:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: modernize-use-override (NFC)

Browse Source 
Add NOLINT to CommandTestBase due to gmock not adding "override" keyword,
which causes warnings on clang.
This commit is contained in:
Peter Johnson
2020-12-28 00:10:13 -08:00
parent 4cc0706b06
commit d11a3a6380
89 changed files with 156 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
simulation/halsim_gui/src/main/native/cpp/EncoderSimGui.cpp
View File

@@ -56,7 +56,7 @@ class EncoderSimModel : public glass::EncoderModel {
: EncoderSimModel(index, HALSIM_GetEncoderDigitalChannelA(index),
HALSIM_GetEncoderDigitalChannelB(index)) {}
~EncoderSimModel() {
~EncoderSimModel() override {
if (m_distancePerPulseCallback != 0) {
HALSIM_CancelEncoderDistancePerPulseCallback(m_index,
m_distancePerPulseCallback);

2
simulation/halsim_gui/src/main/native/cpp/SimDeviceGui.cpp
View File

@@ -24,7 +24,7 @@ class SimValueSource : public glass::DataSource {
: DataSource(wpi::Twine{device} + wpi::Twine{'-'} + name),
m_callback{HALSIM_RegisterSimValueChangedCallback(
handle, this, CallbackFunc, true)} {}
~SimValueSource() {
~SimValueSource() override {
if (m_callback != 0) {
HALSIM_CancelSimValueChangedCallback(m_callback);
}

5
simulation/halsim_ws_core/src/main/native/include/WSHalProviders.h
View File

@@ -27,8 +27,9 @@ class HALSimWSHalProvider : public HALSimWSBaseProvider {
public:
using HALSimWSBaseProvider::HALSimWSBaseProvider;
void OnNetworkConnected(std::shared_ptr<HALSimBaseWebSocketConnection> ws);
void OnNetworkDisconnected();
void OnNetworkConnected(
std::shared_ptr<HALSimBaseWebSocketConnection> ws) override;
void OnNetworkDisconnected() override;
void ProcessHalCallback(const wpi::json& payload);

4
simulation/halsim_ws_core/src/main/native/include/WSProvider_Analog.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderAnalogIn : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderAnalogIn();
~HALSimWSProviderAnalogIn() override;
void OnNetValueChanged(const wpi::json& json) override;
@@ -41,7 +41,7 @@ class HALSimWSProviderAnalogOut : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderAnalogOut();
~HALSimWSProviderAnalogOut() override;
protected:
void RegisterCallbacks() override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_BuiltInAccelerometer.h
View File

@@ -13,7 +13,7 @@ class HALSimWSProviderBuiltInAccelerometer : public HALSimWSHalProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalProvider::HALSimWSHalProvider;
~HALSimWSProviderBuiltInAccelerometer();
~HALSimWSProviderBuiltInAccelerometer() override;
void OnNetValueChanged(const wpi::json& json) override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_DIO.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderDIO : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderDIO();
~HALSimWSProviderDIO() override;
void OnNetValueChanged(const wpi::json& json) override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_DriverStation.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderDriverStation : public HALSimWSHalProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalProvider::HALSimWSHalProvider;
~HALSimWSProviderDriverStation();
~HALSimWSProviderDriverStation() override;
void OnNetValueChanged(const wpi::json& json) override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_Encoder.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderEncoder : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderEncoder();
~HALSimWSProviderEncoder() override;
void OnNetValueChanged(const wpi::json& json) override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_Joystick.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderJoystick : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderJoystick();
~HALSimWSProviderJoystick() override;
void OnNetValueChanged(const wpi::json& json) override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_PWM.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderPWM : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderPWM();
~HALSimWSProviderPWM() override;
protected:
void RegisterCallbacks() override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_Relay.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderRelay : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderRelay();
~HALSimWSProviderRelay() override;
protected:
void RegisterCallbacks() override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_RoboRIO.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderRoboRIO : public HALSimWSHalProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalProvider::HALSimWSHalProvider;
~HALSimWSProviderRoboRIO();
~HALSimWSProviderRoboRIO() override;
void OnNetValueChanged(const wpi::json& json) override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_SimDevice.h
View File

@@ -39,7 +39,7 @@ class HALSimWSProviderSimDevice : public HALSimWSBaseProvider {
m_deviceId = deviceId;
}
~HALSimWSProviderSimDevice();
~HALSimWSProviderSimDevice() override;
void OnNetworkConnected(
std::shared_ptr<HALSimBaseWebSocketConnection> ws) override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_dPWM.h
View File

@@ -15,7 +15,7 @@ class HALSimWSProviderDigitalPWM : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderDigitalPWM();
~HALSimWSProviderDigitalPWM() override;
protected:
void RegisterCallbacks() override;