Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: modernize-use-override (NFC)

Browse Source 
Add NOLINT to CommandTestBase due to gmock not adding "override" keyword,
which causes warnings on clang.
This commit is contained in:
Peter Johnson
2020-12-28 00:10:13 -08:00
parent 4cc0706b06
commit d11a3a6380
89 changed files with 156 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
simulation/halsim_gui/src/main/native/cpp/EncoderSimGui.cpp
View File

@@ -56,7 +56,7 @@ class EncoderSimModel : public glass::EncoderModel {
: EncoderSimModel(index, HALSIM_GetEncoderDigitalChannelA(index),
HALSIM_GetEncoderDigitalChannelB(index)) {}
~EncoderSimModel() {
~EncoderSimModel() override {
if (m_distancePerPulseCallback != 0) {
HALSIM_CancelEncoderDistancePerPulseCallback(m_index,
m_distancePerPulseCallback);

2
simulation/halsim_gui/src/main/native/cpp/SimDeviceGui.cpp
View File

@@ -24,7 +24,7 @@ class SimValueSource : public glass::DataSource {
: DataSource(wpi::Twine{device} + wpi::Twine{'-'} + name),
m_callback{HALSIM_RegisterSimValueChangedCallback(
handle, this, CallbackFunc, true)} {}
~SimValueSource() {
~SimValueSource() override {
if (m_callback != 0) {
HALSIM_CancelSimValueChangedCallback(m_callback);
}