Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-23 01:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: modernize-use-override (NFC)

Browse Source 
Add NOLINT to CommandTestBase due to gmock not adding "override" keyword,
which causes warnings on clang.
This commit is contained in:
Peter Johnson
2020-12-28 00:10:13 -08:00
parent 4cc0706b06
commit d11a3a6380
89 changed files with 156 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wpilibOldCommands/src/main/native/include/frc/buttons/CancelButtonScheduler.h
View File

@@ -14,12 +14,12 @@ class Command;
class CancelButtonScheduler : public ButtonScheduler {
public:
CancelButtonScheduler(bool last, Trigger* button, Command* orders);
virtual ~CancelButtonScheduler() = default;
~CancelButtonScheduler() override = default;
CancelButtonScheduler(CancelButtonScheduler&&) = default;
CancelButtonScheduler& operator=(CancelButtonScheduler&&) = default;
virtual void Execute();
void Execute() override;
};
} // namespace frc

4
wpilibOldCommands/src/main/native/include/frc/buttons/HeldButtonScheduler.h
View File

@@ -14,12 +14,12 @@ class Command;
class HeldButtonScheduler : public ButtonScheduler {
public:
HeldButtonScheduler(bool last, Trigger* button, Command* orders);
virtual ~HeldButtonScheduler() = default;
~HeldButtonScheduler() override = default;
HeldButtonScheduler(HeldButtonScheduler&&) = default;
HeldButtonScheduler& operator=(HeldButtonScheduler&&) = default;
virtual void Execute();
void Execute() override;
};
} // namespace frc

4
wpilibOldCommands/src/main/native/include/frc/buttons/InternalButton.h
View File

@@ -12,7 +12,7 @@ class InternalButton : public Button {
public:
InternalButton() = default;
explicit InternalButton(bool inverted);
virtual ~InternalButton() = default;
~InternalButton() override = default;
InternalButton(InternalButton&&) = default;
InternalButton& operator=(InternalButton&&) = default;
@@ -20,7 +20,7 @@ class InternalButton : public Button {
void SetInverted(bool inverted);
void SetPressed(bool pressed);
virtual bool Get();
bool Get() override;
private:
bool m_pressed = false;

4
wpilibOldCommands/src/main/native/include/frc/buttons/JoystickButton.h
View File

@@ -12,12 +12,12 @@ namespace frc {
class JoystickButton : public Button {
public:
JoystickButton(GenericHID* joystick, int buttonNumber);
virtual ~JoystickButton() = default;
~JoystickButton() override = default;
JoystickButton(JoystickButton&&) = default;
JoystickButton& operator=(JoystickButton&&) = default;
virtual bool Get();
bool Get() override;
private:
GenericHID* m_joystick;

4
wpilibOldCommands/src/main/native/include/frc/buttons/NetworkButton.h
View File

@@ -19,12 +19,12 @@ class NetworkButton : public Button {
NetworkButton(const wpi::Twine& tableName, const wpi::Twine& field);
NetworkButton(std::shared_ptr<nt::NetworkTable> table,
const wpi::Twine& field);
virtual ~NetworkButton() = default;
~NetworkButton() override = default;
NetworkButton(NetworkButton&&) = default;
NetworkButton& operator=(NetworkButton&&) = default;
virtual bool Get();
bool Get() override;
private:
nt::NetworkTableEntry m_entry;

2
wpilibOldCommands/src/main/native/include/frc/buttons/POVButton.h
View File

@@ -18,7 +18,7 @@ class POVButton : public Button {
* @param povNumber The POV number (@see GenericHID#GetPOV)
*/
POVButton(GenericHID& joystick, int angle, int povNumber = 0);
virtual ~POVButton() = default;
~POVButton() override = default;
POVButton(POVButton&&) = default;
POVButton& operator=(POVButton&&) = default;

4
wpilibOldCommands/src/main/native/include/frc/buttons/PressedButtonScheduler.h
View File

@@ -14,12 +14,12 @@ class Command;
class PressedButtonScheduler : public ButtonScheduler {
public:
PressedButtonScheduler(bool last, Trigger* button, Command* orders);
virtual ~PressedButtonScheduler() = default;
~PressedButtonScheduler() override = default;
PressedButtonScheduler(PressedButtonScheduler&&) = default;
PressedButtonScheduler& operator=(PressedButtonScheduler&&) = default;
virtual void Execute();
void Execute() override;
};
} // namespace frc

4
wpilibOldCommands/src/main/native/include/frc/buttons/ReleasedButtonScheduler.h
View File

@@ -14,12 +14,12 @@ class Command;
class ReleasedButtonScheduler : public ButtonScheduler {
public:
ReleasedButtonScheduler(bool last, Trigger* button, Command* orders);
virtual ~ReleasedButtonScheduler() = default;
~ReleasedButtonScheduler() override = default;
ReleasedButtonScheduler(ReleasedButtonScheduler&&) = default;
ReleasedButtonScheduler& operator=(ReleasedButtonScheduler&&) = default;
virtual void Execute();
void Execute() override;
};
} // namespace frc

4
wpilibOldCommands/src/main/native/include/frc/buttons/ToggleButtonScheduler.h
View File

@@ -14,12 +14,12 @@ class Command;
class ToggleButtonScheduler : public ButtonScheduler {
public:
ToggleButtonScheduler(bool last, Trigger* button, Command* orders);
virtual ~ToggleButtonScheduler() = default;
~ToggleButtonScheduler() override = default;
ToggleButtonScheduler(ToggleButtonScheduler&&) = default;
ToggleButtonScheduler& operator=(ToggleButtonScheduler&&) = default;
virtual void Execute();
void Execute() override;
};
} // namespace frc