Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-25 01:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: modernize-use-override (NFC)

Browse Source 
Add NOLINT to CommandTestBase due to gmock not adding "override" keyword,
which causes warnings on clang.
This commit is contained in:
Peter Johnson
2020-12-28 00:10:13 -08:00
parent 4cc0706b06
commit d11a3a6380
89 changed files with 156 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wpilibc/src/main/native/include/frc/DigitalSource.h
View File

@@ -25,8 +25,8 @@ class DigitalSource : public InterruptableSensorBase {
DigitalSource(DigitalSource&&) = default;
DigitalSource& operator=(DigitalSource&&) = default;
virtual HAL_Handle GetPortHandleForRouting() const = 0;
virtual AnalogTriggerType GetAnalogTriggerTypeForRouting() const = 0;
HAL_Handle GetPortHandleForRouting() const override = 0;
AnalogTriggerType GetAnalogTriggerTypeForRouting() const override = 0;
virtual bool IsAnalogTrigger() const = 0;
virtual int GetChannel() const = 0;
};

2
wpilibc/src/main/native/include/frc/GenericHID.h
View File

@@ -44,7 +44,7 @@ class GenericHID : public ErrorBase {
enum JoystickHand { kLeftHand = 0, kRightHand = 1 };
explicit GenericHID(int port);
virtual ~GenericHID() = default;
~GenericHID() override = default;
GenericHID(GenericHID&&) = default;
GenericHID& operator=(GenericHID&&) = default;

2
wpilibc/src/main/native/include/frc/InterruptableSensorBase.h
View File

@@ -35,7 +35,7 @@ class InterruptableSensorBase : public ErrorBase {
/**
* Free the resources for an interrupt event.
*/
virtual ~InterruptableSensorBase();
~InterruptableSensorBase() override;
InterruptableSensorBase(InterruptableSensorBase&&) = default;
InterruptableSensorBase& operator=(InterruptableSensorBase&&) = default;

2
wpilibc/src/main/native/include/frc/IterativeRobot.h
View File

@@ -28,7 +28,7 @@ class IterativeRobot : public IterativeRobotBase {
"Use TimedRobot instead. It's a drop-in replacement that provides more "
"regular execution periods.")
IterativeRobot();
virtual ~IterativeRobot() = default;
~IterativeRobot() override = default;
/**
* Provide an alternate "main loop" via StartCompetition().

2
wpilibc/src/main/native/include/frc/IterativeRobotBase.h
View File

@@ -178,7 +178,7 @@ class IterativeRobotBase : public RobotBase {
*/
explicit IterativeRobotBase(units::second_t period);
virtual ~IterativeRobotBase() = default;
~IterativeRobotBase() override = default;
protected:
IterativeRobotBase(IterativeRobotBase&&) = default;

2
wpilibc/src/main/native/include/frc/Joystick.h
View File

@@ -39,7 +39,7 @@ class Joystick : public GenericHID {
*/
explicit Joystick(int port);
virtual ~Joystick() = default;
~Joystick() override = default;
Joystick(Joystick&&) = default;
Joystick& operator=(Joystick&&) = default;

2
wpilibc/src/main/native/include/frc/MotorSafety.h
View File

@@ -21,7 +21,7 @@ namespace frc {
class MotorSafety : public ErrorBase {
public:
MotorSafety();
virtual ~MotorSafety();
~MotorSafety() override;
MotorSafety(MotorSafety&& rhs);
MotorSafety& operator=(MotorSafety&& rhs);

2
wpilibc/src/main/native/include/frc/Notifier.h
View File

@@ -62,7 +62,7 @@ class Notifier : public ErrorBase {
/**
* Free the resources for a timer event.
*/
virtual ~Notifier();
~Notifier() override;
Notifier(Notifier&& rhs);
Notifier& operator=(Notifier&& rhs);

2
wpilibc/src/main/native/include/frc/PIDBase.h
View File

@@ -65,7 +65,7 @@ class PIDBase : public PIDInterface,
PIDBase(double p, double i, double d, double f, PIDSource& source,
PIDOutput& output);
virtual ~PIDBase() = default;
~PIDBase() override = default;
/**
* Return the current PID result.

2
wpilibc/src/main/native/include/frc/Preferences.h
View File

@@ -226,7 +226,7 @@ class Preferences : public ErrorBase {
protected:
Preferences();
virtual ~Preferences() = default;
~Preferences() override = default;
Preferences(Preferences&&) = default;
Preferences& operator=(Preferences&&) = default;

2
wpilibc/src/main/native/include/frc/Resource.h
View File

@@ -28,7 +28,7 @@ namespace frc {
*/
class Resource : public ErrorBase {
public:
virtual ~Resource() = default;
~Resource() override = default;
/**
* Factory method to create a Resource allocation-tracker *if* needed.

2
wpilibc/src/main/native/include/frc/RobotDrive.h
View File

@@ -126,7 +126,7 @@ class RobotDrive : public MotorSafety {
std::shared_ptr<SpeedController> frontRightMotor,
std::shared_ptr<SpeedController> rearRightMotor);
virtual ~RobotDrive() = default;
~RobotDrive() override = default;
RobotDrive(RobotDrive&&) = default;
RobotDrive& operator=(RobotDrive&&) = default;

2
wpilibc/src/main/native/include/frc/SerialPort.h
View File

@@ -87,7 +87,7 @@ class SerialPort : public ErrorBase {
int dataBits = 8, Parity parity = kParity_None,
StopBits stopBits = kStopBits_One);
~SerialPort();
~SerialPort() override;
SerialPort(SerialPort&& rhs) = default;
SerialPort& operator=(SerialPort&& rhs) = default;

2
wpilibc/src/main/native/include/frc/XboxController.h
View File

@@ -29,7 +29,7 @@ class XboxController : public GenericHID {
*/
explicit XboxController(int port);
virtual ~XboxController() = default;
~XboxController() override = default;
XboxController(XboxController&&) = default;
XboxController& operator=(XboxController&&) = default;

2
wpilibc/src/main/native/include/frc/filters/Filter.h
View File

@@ -23,7 +23,7 @@ class Filter : public PIDSource {
explicit Filter(PIDSource& source);
WPI_DEPRECATED("This class is no longer used.")
explicit Filter(std::shared_ptr<PIDSource> source);
virtual ~Filter() = default;
~Filter() override = default;
Filter(Filter&&) = default;
Filter& operator=(Filter&&) = default;

2
wpilibc/src/main/native/include/frc/interfaces/Potentiometer.h
View File

@@ -14,7 +14,7 @@ namespace frc {
class Potentiometer : public PIDSource {
public:
Potentiometer() = default;
virtual ~Potentiometer() = default;
~Potentiometer() override = default;
Potentiometer(Potentiometer&&) = default;
Potentiometer& operator=(Potentiometer&&) = default;

2
wpilibc/src/main/native/include/frc/shuffleboard/ShuffleboardComponent.h
View File

@@ -29,7 +29,7 @@ class ShuffleboardComponent : public ShuffleboardComponentBase {
ShuffleboardComponent(ShuffleboardContainer& parent, const wpi::Twine& title,
const wpi::Twine& type = "");
virtual ~ShuffleboardComponent() = default;
~ShuffleboardComponent() override = default;
/**
* Sets custom properties for this component. Property names are

2
wpilibc/src/main/native/include/frc/shuffleboard/ShuffleboardComponentBase.h
View File

@@ -27,7 +27,7 @@ class ShuffleboardComponentBase : public virtual ShuffleboardValue {
const wpi::Twine& title,
const wpi::Twine& type = "");
virtual ~ShuffleboardComponentBase() = default;
~ShuffleboardComponentBase() override = default;
void SetType(const wpi::Twine& type);

2
wpilibc/src/main/native/include/frc/shuffleboard/ShuffleboardContainer.h
View File

@@ -45,7 +45,7 @@ class ShuffleboardContainer : public virtual ShuffleboardValue,
ShuffleboardContainer(ShuffleboardContainer&& rhs) = default;
virtual ~ShuffleboardContainer() = default;
~ShuffleboardContainer() override = default;
/**
* Gets the components that are direct children of this container.

2
wpilibc/src/main/native/include/frc/smartdashboard/SmartDashboard.h
View File

@@ -432,7 +432,7 @@ class SmartDashboard : public ErrorBase,
static void UpdateValues();
private:
virtual ~SmartDashboard() = default;
~SmartDashboard() override = default;
static detail::ListenerExecutor listenerExecutor;
};