Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-27 02:01:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] Fix large text message splitting (#6263)

Browse Source 
The written amount wasn't being tracked in the common case, so bulk
announcements after a subscribe would result in a very large WebSocket
frame.
This commit is contained in:
Peter Johnson
2024-01-19 23:15:25 -08:00
committed by GitHub
parent 24a24c9051
commit d653408873
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ntcore/src/main/native/cpp/net/WebSocketConnection.cpp
View File

@@ -52,7 +52,10 @@ class WebSocketConnection::Stream final : public wpi::raw_ostream {
void WebSocketConnection::Stream::write_impl(const char* data, size_t len) {
if (data == m_conn.m_bufs.back().base) {
// flush_nonempty() case
size_t amt = len - m_conn.m_bufs.back().len;
m_conn.m_bufs.back().len = len;
m_conn.m_framePos += amt;
m_conn.m_written += amt;
if (!m_disableAlloc) {
#ifdef NT_ENABLE_WS_FRAG
m_conn.m_frames.back().opcode &= ~wpi::WebSocket::kFlagFin;