Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-23 01:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename tests for consistency (#3592)

Browse Source 
I started with the output of styleguide#217, then renamed a few classes
to fix compilation.

ntcore's StorageTest needed some manual renaming since it put the Test
word in the middle instead of at the end.

One limitation of wpiformat is test cases that were only named "Test"
were unmodified, and an error was generated. These test cases were
manually given more descriptive names:

* TimedRobotTest mode test cases had "Mode" appended to the name. Java
  tests were renamed to match.
* UvAsyncTest and UvAsyncFunctionTest cases were given alternate names
This commit is contained in:
Tyler Veness
2021-09-21 06:12:50 -07:00
committed by GitHub
parent 54ca474dba
commit d6f185d8e5
41 changed files with 399 additions and 398 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wpiutil/src/test/native/cpp/sigslot/function-traits.cpp
View File

@@ -116,7 +116,7 @@ static_assert(is_callable_v<t, o8>, "");
namespace wpi {
TEST(Signal, FunctionTraits) {
TEST(SignalTest, FunctionTraits) {
auto l1 = [](int, char, float) {};
auto l2 = [&](int, char, float) mutable {};
auto l3 = [&](auto...) mutable {};

4
wpiutil/src/test/native/cpp/sigslot/recursive.cpp
View File

@@ -63,7 +63,7 @@ struct object {
namespace wpi {
TEST(Signal, Recursive) {
TEST(SignalTest, Recursive) {
object<int> i1(-1);
object<int> i2(10);
@@ -75,7 +75,7 @@ TEST(Signal, Recursive) {
ASSERT_EQ(i1.v, i2.v);
}
TEST(Signal, SelfRecursive) {
TEST(SignalTest, SelfRecursive) {
int i = 0;
wpi::sig::Signal_r<int> s;

10
wpiutil/src/test/native/cpp/sigslot/signal-extended.cpp
View File

@@ -68,7 +68,7 @@ struct o {
namespace wpi {
TEST(SignalExtended, FreeConnection) {
TEST(SignalExtendedTest, FreeConnection) {
sum = 0;
Signal<int> sig;
sig.connect_extended(f);
@@ -79,7 +79,7 @@ TEST(SignalExtended, FreeConnection) {
ASSERT_EQ(sum, 1);
}
TEST(SignalExtended, StaticConnection) {
TEST(SignalExtendedTest, StaticConnection) {
sum = 0;
Signal<int> sig;
sig.connect_extended(&s::sf);
@@ -90,7 +90,7 @@ TEST(SignalExtended, StaticConnection) {
ASSERT_EQ(sum, 1);
}
TEST(SignalExtended, PmfConnection) {
TEST(SignalExtendedTest, PmfConnection) {
sum = 0;
Signal<int> sig;
s p;
@@ -102,7 +102,7 @@ TEST(SignalExtended, PmfConnection) {
ASSERT_EQ(sum, 1);
}
TEST(SignalExtended, FunctionObjectConnection) {
TEST(SignalExtendedTest, FunctionObjectConnection) {
sum = 0;
Signal<int> sig;
sig.connect_extended(o{});
@@ -113,7 +113,7 @@ TEST(SignalExtended, FunctionObjectConnection) {
ASSERT_EQ(sum, 1);
}
TEST(SignalExtended, LambdaConnection) {
TEST(SignalExtendedTest, LambdaConnection) {
sum = 0;
Signal<int> sig;

4
wpiutil/src/test/native/cpp/sigslot/signal-threaded.cpp
View File

@@ -68,7 +68,7 @@ void connect_emit(Signal_mt<int>& sig) {
namespace wpi {
TEST(Signal, ThreadedMix) {
TEST(SignalTest, ThreadedMix) {
sum = 0;
Signal_mt<int> sig;
@@ -83,7 +83,7 @@ TEST(Signal, ThreadedMix) {
}
}
TEST(Signal, ThreadedEmission) {
TEST(SignalTest, ThreadedEmission) {
sum = 0;
Signal_mt<int> sig;

8
wpiutil/src/test/native/cpp/sigslot/signal-tracking.cpp
View File

@@ -72,7 +72,7 @@ static_assert(trait::is_callable_v<trait::typelist<int>, decltype(&s::f1),
namespace wpi {
TEST(Signal, TrackShared) {
TEST(SignalTest, TrackShared) {
sum = 0;
Signal<int> sig;
@@ -95,7 +95,7 @@ TEST(Signal, TrackShared) {
ASSERT_EQ(sum, 5);
}
TEST(Signal, TrackOther) {
TEST(SignalTest, TrackOther) {
sum = 0;
Signal<int> sig;
@@ -118,7 +118,7 @@ TEST(Signal, TrackOther) {
ASSERT_EQ(sum, 5);
}
TEST(Signal, TrackOverloadedFunctionObject) {
TEST(SignalTest, TrackOverloadedFunctionObject) {
sum = 0;
Signal<int> sig;
Signal<double> sig1;
@@ -143,7 +143,7 @@ TEST(Signal, TrackOverloadedFunctionObject) {
ASSERT_EQ(sum, 5);
}
TEST(Signal, TrackGenericLambda) {
TEST(SignalTest, TrackGenericLambda) {
std::stringstream s;
auto f = [&](auto a, auto... args) {

42
wpiutil/src/test/native/cpp/sigslot/signal.cpp
View File

@@ -100,7 +100,7 @@ struct o8 {
namespace wpi {
TEST(Signal, FreeConnection) {
TEST(SignalTest, FreeConnection) {
sum = 0;
Signal<int> sig;
@@ -113,7 +113,7 @@ TEST(Signal, FreeConnection) {
ASSERT_EQ(sum, 4);
}
TEST(Signal, StaticConnection) {
TEST(SignalTest, StaticConnection) {
sum = 0;
Signal<int> sig;
@@ -126,7 +126,7 @@ TEST(Signal, StaticConnection) {
ASSERT_EQ(sum, 4);
}
TEST(Signal, PmfConnection) {
TEST(SignalTest, PmfConnection) {
sum = 0;
Signal<int> sig;
s p;
@@ -144,7 +144,7 @@ TEST(Signal, PmfConnection) {
ASSERT_EQ(sum, 8);
}
TEST(Signal, ConstPmfConnection) {
TEST(SignalTest, ConstPmfConnection) {
sum = 0;
Signal<int> sig;
const s p;
@@ -158,7 +158,7 @@ TEST(Signal, ConstPmfConnection) {
ASSERT_EQ(sum, 4);
}
TEST(Signal, FunctionObjectConnection) {
TEST(SignalTest, FunctionObjectConnection) {
sum = 0;
Signal<int> sig;
@@ -175,7 +175,7 @@ TEST(Signal, FunctionObjectConnection) {
ASSERT_EQ(sum, 8);
}
TEST(Signal, OverloadedFunctionObjectConnection) {
TEST(SignalTest, OverloadedFunctionObjectConnection) {
sum = 0;
Signal<int> sig;
Signal<double> sig1;
@@ -189,7 +189,7 @@ TEST(Signal, OverloadedFunctionObjectConnection) {
ASSERT_EQ(sum, 5);
}
TEST(Signal, LambdaConnection) {
TEST(SignalTest, LambdaConnection) {
sum = 0;
Signal<int> sig;
@@ -202,7 +202,7 @@ TEST(Signal, LambdaConnection) {
ASSERT_EQ(sum, 4);
}
TEST(Signal, GenericLambdaConnection) {
TEST(SignalTest, GenericLambdaConnection) {
std::stringstream s;
auto f = [&](auto a, auto... args) {
@@ -229,7 +229,7 @@ TEST(Signal, GenericLambdaConnection) {
ASSERT_EQ(s.str(), "1foo4.1");
}
TEST(Signal, LvalueEmission) {
TEST(SignalTest, LvalueEmission) {
sum = 0;
Signal<int> sig;
@@ -243,7 +243,7 @@ TEST(Signal, LvalueEmission) {
ASSERT_EQ(sum, 4);
}
TEST(Signal, Mutation) {
TEST(SignalTest, Mutation) {
int res = 0;
Signal<int&> sig;
@@ -256,7 +256,7 @@ TEST(Signal, Mutation) {
ASSERT_EQ(res, 4);
}
TEST(Signal, CompatibleArgs) {
TEST(SignalTest, CompatibleArgs) {
long ll = 0; // NOLINT(runtime/int)
std::string ss;
short ii = 0; // NOLINT(runtime/int)
@@ -276,7 +276,7 @@ TEST(Signal, CompatibleArgs) {
ASSERT_EQ(ii, 1);
}
TEST(Signal, Disconnection) {
TEST(SignalTest, Disconnection) {
// test removing only connected
{
sum = 0;
@@ -328,7 +328,7 @@ TEST(Signal, Disconnection) {
}
}
TEST(Signal, ScopedConnection) {
TEST(SignalTest, ScopedConnection) {
sum = 0;
Signal<int> sig;
@@ -361,7 +361,7 @@ TEST(Signal, ScopedConnection) {
ASSERT_EQ(sum, 4);
}
TEST(Signal, ConnectionBlocking) {
TEST(SignalTest, ConnectionBlocking) {
sum = 0;
Signal<int> sig;
@@ -379,7 +379,7 @@ TEST(Signal, ConnectionBlocking) {
ASSERT_EQ(sum, 8);
}
TEST(Signal, ConnectionBlocker) {
TEST(SignalTest, ConnectionBlocker) {
sum = 0;
Signal<int> sig;
@@ -398,7 +398,7 @@ TEST(Signal, ConnectionBlocker) {
ASSERT_EQ(sum, 8);
}
TEST(Signal, SignalBlocking) {
TEST(SignalTest, SignalBlocking) {
sum = 0;
Signal<int> sig;
@@ -416,7 +416,7 @@ TEST(Signal, SignalBlocking) {
ASSERT_EQ(sum, 6);
}
TEST(Signal, AllDisconnection) {
TEST(SignalTest, AllDisconnection) {
sum = 0;
Signal<int> sig;
@@ -430,7 +430,7 @@ TEST(Signal, AllDisconnection) {
ASSERT_EQ(sum, 3);
}
TEST(Signal, ConnectionCopyingMoving) {
TEST(SignalTest, ConnectionCopyingMoving) {
sum = 0;
Signal<int> sig;
@@ -459,7 +459,7 @@ TEST(Signal, ConnectionCopyingMoving) {
ASSERT_EQ(sum, 9);
}
TEST(Signal, ScopedConnectionMoving) {
TEST(SignalTest, ScopedConnectionMoving) {
sum = 0;
Signal<int> sig;
@@ -485,7 +485,7 @@ TEST(Signal, ScopedConnectionMoving) {
ASSERT_EQ(sum, 10);
}
TEST(Signal, SignalMoving) {
TEST(SignalTest, SignalMoving) {
sum = 0;
Signal<int> sig;
@@ -525,7 +525,7 @@ struct object {
Signal<T> s;
};
TEST(Signal, Loop) {
TEST(SignalTest, Loop) {
object<int> i1(0);
object<int> i2(3);