[wpiutil] Upgrade to fmt 10.2.1, add wpi::print (#6161)

We now use a wrapper (wpi::print) to catch exceptions since we can't patch
std::print() to not throw when we ultimately migrate to it.

fmtlib and std format/print throw the same exceptions and always have. We previously patched fmt::print() to not throw a write failure exception, but we can't do that for std::print(); wpi::print() is the migration plan.
This commit is contained in:
Tyler Veness
2024-05-12 06:25:42 -07:00
committed by GitHub
parent 6c9dcc157e
commit d88c71ffdc
99 changed files with 1374 additions and 1130 deletions

View File

@@ -13,7 +13,9 @@
#include <thread>
#include <fmt/format.h>
#include <fmt/ranges.h>
#include <wpi/Synchronization.h>
#include <wpi/print.h>
#include <wpi/timestamp.h>
#include "ntcore.h"
@@ -43,7 +45,7 @@ int main(int argc, char* argv[]) {
nt::SetEntryValue(myValue, nt::Value::MakeString("Hello World"));
fmt::print("{}\n", nt::GetEntryValue(myValue).GetString());
wpi::print("{}\n", nt::GetEntryValue(myValue).GetString());
}
void PrintTimes(std::vector<int64_t>& times) {
@@ -57,9 +59,9 @@ void PrintTimes(std::vector<int64_t>& times) {
std::inner_product(times.begin(), times.end(), times.begin(), 0);
double stdev = std::sqrt(sq_sum / times.size() - mean * mean);
fmt::print("min: {} max: {}, mean: {}, stdev: {}\n", min, max, mean, stdev);
fmt::print("min 10: {}\n", fmt::join(times.begin(), times.begin() + 10, ","));
fmt::print("max 10: {}\n", fmt::join(times.end() - 10, times.end(), ","));
wpi::print("min: {} max: {}, mean: {}, stdev: {}\n", min, max, mean, stdev);
wpi::print("min 10: {}\n", fmt::join(times.begin(), times.begin() + 10, ","));
wpi::print("max 10: {}\n", fmt::join(times.end() - 10, times.end(), ","));
}
// benchmark
@@ -115,11 +117,11 @@ void bench() {
}
auto stop = std::chrono::high_resolution_clock::now();
fmt::print("total time: {}us\n",
wpi::print("total time: {}us\n",
std::chrono::duration_cast<std::chrono::microseconds>(stop - start)
.count());
PrintTimes(times);
fmt::print("-- Flush --\n");
wpi::print("-- Flush --\n");
PrintTimes(flushTimes);
}
@@ -188,11 +190,11 @@ void bench2() {
}
auto stop = std::chrono::high_resolution_clock::now();
fmt::print("total time: {}us\n",
wpi::print("total time: {}us\n",
std::chrono::duration_cast<std::chrono::microseconds>(stop - start)
.count());
PrintTimes(times);
fmt::print("-- Flush --\n");
wpi::print("-- Flush --\n");
PrintTimes(flushTimes);
}

View File

@@ -4,10 +4,10 @@
#include "LoggerImpl.h"
#include <fmt/format.h>
#include <wpi/Logger.h>
#include <wpi/SmallVector.h>
#include <wpi/fs.h>
#include <wpi/print.h>
#include "IListenerStorage.h"
@@ -16,7 +16,7 @@ using namespace nt;
static void DefaultLogger(unsigned int level, const char* file,
unsigned int line, const char* msg) {
if (level == wpi::WPI_LOG_INFO) {
fmt::print(stderr, "NT: {}\n", msg);
wpi::print(stderr, "NT: {}\n", msg);
return;
}
@@ -30,7 +30,7 @@ static void DefaultLogger(unsigned int level, const char* file,
} else {
return;
}
fmt::print(stderr, "NT: {}: {} ({}:{})\n", levelmsg, msg, file, line);
wpi::print(stderr, "NT: {}: {} ({}:{})\n", levelmsg, msg, file, line);
}
static constexpr unsigned int kFlagCritical = 1u << 16;

View File

@@ -4,8 +4,8 @@
#include "networktables/NetworkTableInstance.h"
#include <fmt/format.h>
#include <wpi/SmallVector.h>
#include <wpi/print.h>
#include "networktables/BooleanArrayTopic.h"
#include "networktables/BooleanTopic.h"
@@ -105,7 +105,7 @@ NT_Listener NetworkTableInstance::AddListener(Topic topic,
unsigned int eventMask,
ListenerCallback listener) {
if (::nt::GetInstanceFromHandle(topic.GetHandle()) != m_handle) {
fmt::print(stderr, "AddListener: topic is not from this instance\n");
wpi::print(stderr, "AddListener: topic is not from this instance\n");
return 0;
}
return ::nt::AddListener(topic.GetHandle(), eventMask, std::move(listener));
@@ -115,7 +115,7 @@ NT_Listener NetworkTableInstance::AddListener(Subscriber& subscriber,
unsigned int eventMask,
ListenerCallback listener) {
if (::nt::GetInstanceFromHandle(subscriber.GetHandle()) != m_handle) {
fmt::print(stderr, "AddListener: subscriber is not from this instance\n");
wpi::print(stderr, "AddListener: subscriber is not from this instance\n");
return 0;
}
return ::nt::AddListener(subscriber.GetHandle(), eventMask,
@@ -126,7 +126,7 @@ NT_Listener NetworkTableInstance::AddListener(const NetworkTableEntry& entry,
int eventMask,
ListenerCallback listener) {
if (::nt::GetInstanceFromHandle(entry.GetHandle()) != m_handle) {
fmt::print(stderr, "AddListener: entry is not from this instance\n");
wpi::print(stderr, "AddListener: entry is not from this instance\n");
return 0;
}
return ::nt::AddListener(entry.GetHandle(), eventMask, std::move(listener));
@@ -136,7 +136,7 @@ NT_Listener NetworkTableInstance::AddListener(MultiSubscriber& subscriber,
int eventMask,
ListenerCallback listener) {
if (::nt::GetInstanceFromHandle(subscriber.GetHandle()) != m_handle) {
fmt::print(stderr, "AddListener: subscriber is not from this instance\n");
wpi::print(stderr, "AddListener: subscriber is not from this instance\n");
return 0;
}
return ::nt::AddListener(subscriber.GetHandle(), eventMask,