Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] NetworkClient: Add IsLoopClosing() guard in deferred disconnect timer (#8936)

Browse Source 
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Vasista Vovveti
2026-06-05 15:01:44 -07:00
committed by GitHub
parent e085c3e8b3
commit d941be905e
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ntcore/src/main/native/cpp/NetworkClient.cpp
View File

@@ -285,6 +285,13 @@ void NetworkClient::WsConnected(wpi::net::WebSocket& ws, uv::Tcp& tcp,
uv::Timer::SingleShot(
m_loop, uv::Timer::Time{0},
[this, reason = std::string{reason}, keepws = ws.shared_from_this()] {
// Check that the loop is not shutting down. keepws->GetStream()
// would dereference the underlying uv::Tcp which may have been
// destroyed after Handle::Close() released its self-reference.
// m_loop is safe to access as long as `this` is alive.
if (m_loop.IsClosing()) {
return;
}
DoDisconnect(reason);
});
}