mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-26 01:51:41 +00:00
Java cleanups (#1776)
* Remove extra ';'s * Remove unnecessary conversions to String * Use StandardCharsets object * Replace infinite while with check for interrupted thread * Remove redundant local vars * Remove redundant throws clause * Remove redundant primitive wrapping * Fix malformed Nested class test * Remove unnecessary unboxing * Remove unnecessary explicit type argument * Replace lambdas with method references * Replace statement lambdas with expression lambdas * Replace null check with method call * Replace number comparison with method call * Fix broken javadoc comments * Replace Arrays.asList with singletonLists * Remove excessive lambda usage * Remove redundant string operation * Remove redundant type casts * Remove unnecessary returns * Remove redundant suppressions * Fix unresolved file reference * static analysis fixes
This commit is contained in:
committed by
Peter Johnson
parent
39561751fc
commit
df12fc2a86
@@ -1,5 +1,5 @@
|
||||
/*----------------------------------------------------------------------------*/
|
||||
/* Copyright (c) 2014-2018 FIRST. All Rights Reserved. */
|
||||
/* Copyright (c) 2014-2019 FIRST. All Rights Reserved. */
|
||||
/* Open Source Software - may be modified and shared by FRC teams. The code */
|
||||
/* must be accompanied by the FIRST BSD license file in the root directory of */
|
||||
/* the project. */
|
||||
@@ -51,7 +51,7 @@ public class PCMTest extends AbstractComsSetup {
|
||||
private static DigitalInput fakeSolenoid2;
|
||||
|
||||
@BeforeClass
|
||||
public static void setUpBeforeClass() throws Exception {
|
||||
public static void setUpBeforeClass() {
|
||||
compressor = new Compressor();
|
||||
|
||||
fakePressureSwitch = new DigitalOutput(11);
|
||||
@@ -62,7 +62,7 @@ public class PCMTest extends AbstractComsSetup {
|
||||
}
|
||||
|
||||
@AfterClass
|
||||
public static void tearDownAfterClass() throws Exception {
|
||||
public static void tearDownAfterClass() {
|
||||
compressor.close();
|
||||
|
||||
fakePressureSwitch.close();
|
||||
@@ -73,7 +73,7 @@ public class PCMTest extends AbstractComsSetup {
|
||||
}
|
||||
|
||||
@Before
|
||||
public void reset() throws Exception {
|
||||
public void reset() {
|
||||
compressor.stop();
|
||||
fakePressureSwitch.set(false);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user