Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Java cleanups (#1776)

Browse Source 
* Remove extra ';'s
* Remove unnecessary conversions to String
* Use StandardCharsets object
* Replace infinite while with check for interrupted thread
* Remove redundant local vars
* Remove redundant throws clause
* Remove redundant primitive wrapping
* Fix malformed Nested class test
* Remove unnecessary unboxing
* Remove unnecessary explicit type argument
* Replace lambdas with method references
* Replace statement lambdas with expression lambdas
* Replace null check with method call
* Replace number comparison with method call
* Fix broken javadoc comments
* Replace Arrays.asList with singletonLists
* Remove excessive lambda usage
* Remove redundant string operation
* Remove redundant type casts
* Remove unnecessary returns
* Remove redundant suppressions
* Fix unresolved file reference
* static analysis fixes
This commit is contained in:
Austin Shalit
2019-08-01 01:19:48 -04:00
committed by Peter Johnson
parent 39561751fc
commit df12fc2a86
43 changed files with 129 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PIDTest.java
View File

@@ -94,18 +94,18 @@ public class PIDTest extends AbstractComsSetup {
}
@BeforeClass
public static void setUpBeforeClass() throws Exception {
public static void setUpBeforeClass() {
}
@AfterClass
public static void tearDownAfterClass() throws Exception {
public static void tearDownAfterClass() {
logger.fine("TearDownAfterClass: " + me.getType());
me.teardown();
me = null;
}
@Before
public void setUp() throws Exception {
public void setUp() {
logger.fine("Setup: " + me.getType());
me.setup();
m_table = NetworkTableInstance.getDefault().getTable("TEST_PID");
@@ -118,7 +118,7 @@ public class PIDTest extends AbstractComsSetup {
}
@After
public void tearDown() throws Exception {
public void tearDown() {
logger.fine("Teardown: " + me.getType());
m_runner.disable();
m_controller.close();
@@ -174,12 +174,12 @@ public class PIDTest extends AbstractComsSetup {
public void testSetSetpoint() {
setupAbsoluteTolerance();
setupOutputRange();
Double reference = 2500.0;
double reference = 2500.0;
m_runner.disable();
m_controller.setSetpoint(reference);
m_runner.enable();
assertEquals("Did not correctly set reference", reference, new Double(m_controller
.getSetpoint()));
assertEquals("Did not correctly set reference", reference, m_controller
.getSetpoint(), 1e-3);
}
@Test(timeout = 10000)