Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[examples,cscore] Don't use assertTimeoutPreemptively in tests (#8951)

Browse Source 
Particularly with short timeouts, this results in spurious failures
under high CPU load.
This commit is contained in:
Peter Johnson
2026-06-05 07:28:51 -07:00
committed by GitHub
parent 98c03baf54
commit e085c3e8b3
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cscore/src/test/java/org/wpilib/vision/camera/UsbCameraTest.java
View File

@@ -5,10 +5,8 @@
package org.wpilib.vision.camera;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTimeoutPreemptively;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.time.Duration;
import java.util.Arrays;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;
@@ -23,16 +21,15 @@ class UsbCameraTest {
@EnabledOnOs(OS.LINUX)
static class ConnectVerbose {
@Test
void setConnectVerboseEnabledTest() {
void setConnectVerboseEnabledTest() throws Exception {
try (UsbCamera camera = new UsbCamera("Nonexistent Camera", getNonexistentCameraDev())) {
camera.setConnectVerbose(1);
CompletableFuture<String> result = new CompletableFuture<>();
CameraServerJNI.setLogger((level, file, line, message) -> result.complete(message), 20);
assertTimeoutPreemptively(
Duration.ofSeconds(5),
() -> assertTrue(result.get().contains("Attempting to connect to USB camera on ")));
assertTrue(
result.get(5, TimeUnit.SECONDS).contains("Attempting to connect to USB camera on "));
}
}