Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[glass] Fix CollapsingHeader in Encoder, PCM, and DeviceTree (#3797)

Browse Source 
The new storage approach was attempting to save both the name and the
open status to the same storage key.
This commit is contained in:
Peter Johnson
2021-12-19 07:35:12 -08:00
committed by GitHub
parent 52b2dd5b89
commit e44ed752ad
3 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
glass/src/lib/native/cpp/hardware/Encoder.cpp
View File

@@ -70,17 +70,17 @@ void glass::DisplayEncoder(EncoderModel* model) {
std::string& name = GetStorage().GetString("name");
char label[128];
if (!name.empty()) {
std::snprintf(label, sizeof(label), "%s [%d,%d]###name", name.c_str(), chA,
chB);
std::snprintf(label, sizeof(label), "%s [%d,%d]###header", name.c_str(),
chA, chB);
} else {
std::snprintf(label, sizeof(label), "Encoder[%d,%d]###name", chA, chB);
std::snprintf(label, sizeof(label), "Encoder[%d,%d]###header", chA, chB);
}
// header
bool open = CollapsingHeader(label);
// context menu to change name
if (PopupEditName("name", &name)) {
if (PopupEditName("header", &name)) {
model->SetName(name);
}