Update and enable PMD 6.3.0 (#1107)

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/ConstantsPortsTest.java

@@ -21,6 +21,7 @@ import static org.junit.Assert.assertEquals;
 public class ConstantsPortsTest extends AbstractComsSetup {
   private static final Logger logger = Logger.getLogger(ConstantsPortsTest.class.getName());
 
+  @Override
   protected Logger getClassLogger() {
     return logger;
   }

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilterTest.java

@@ -22,6 +22,7 @@ public class DigitalGlitchFilterTest extends AbstractComsSetup {
   private static final Logger logger = Logger.getLogger(
       DigitalGlitchFilterTest.class.getName());
 
+  @Override
   protected Logger getClassLogger() {
     return logger;
   }

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PCMTest.java

@@ -269,6 +269,7 @@ public class PCMTest extends AbstractComsSetup {
     solenoid2.close();
   }
 
+  @Override
   protected Logger getClassLogger() {
     return logger;
   }

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/RobotDriveTest.java

@@ -176,6 +176,7 @@ public class RobotDriveTest extends AbstractComsSetup {
     }
   }
 
+  @Override
   protected Logger getClassLogger() {
     return logger;
   }

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/SampleTest.java

@@ -30,6 +30,7 @@ public class SampleTest extends AbstractComsSetup {
 
   static SampleFixture fixture = new SampleFixture();
 
+  @Override
   protected Logger getClassLogger() {
     return logger;
   }

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeCounterSource.java

@@ -30,6 +30,7 @@ public class FakeCounterSource implements AutoCloseable {
       m_encoder = encode;
     }
 
+    @Override
     public void run() {
       m_encoder.m_output.set(false);
       try {
@@ -70,6 +71,7 @@ public class FakeCounterSource implements AutoCloseable {
   /**
    * Destroy Object with minimum memory leak.
    */
+  @Override
   public void close() {
     m_task = null;
     if (m_allocated) {

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeEncoderSource.java

@@ -32,6 +32,7 @@ public class FakeEncoderSource implements AutoCloseable {
       m_encoder = encode;
     }
 
+    @Override
     public void run() {
       final DigitalOutput lead;
       final DigitalOutput lag;
@@ -93,6 +94,7 @@ public class FakeEncoderSource implements AutoCloseable {
   /**
    * Frees the resource.
    */
+  @Override
   public void close() {
     m_task = null;
     if (m_allocatedOutputs) {

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakePotentiometerSource.java

@@ -83,6 +83,7 @@ public class FakePotentiometerSource implements AutoCloseable {
   /**
    * Frees the resouce.
    */
+  @Override
   public void close() {
     if (m_initOutput) {
       m_output.close();

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboardTest.java

@@ -24,6 +24,7 @@ public class SmartDashboardTest extends AbstractComsSetup {
   private static final Logger logger = Logger.getLogger(SmartDashboardTest.class.getName());
   private static final NetworkTable table = NetworkTable.getTable("SmartDashboard");
 
+  @Override
   protected Logger getClassLogger() {
     return logger;
   }