From e89d5eb692a5c5573a1d05e7bdd3ff334a6b31af Mon Sep 17 00:00:00 2001 From: Tyler Veness Date: Mon, 29 Oct 2018 00:09:53 -0700 Subject: [PATCH] Fix stringop truncation warning from GCC 8.2 (#1393) The next line adds a null terminator, but it's cleaner to just do a std::memcpy() since the code already assumes a null terminator exists in the source string. --- hal/src/main/native/sim/DriverStation.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hal/src/main/native/sim/DriverStation.cpp b/hal/src/main/native/sim/DriverStation.cpp index 4224e2bc62..0c9c028405 100644 --- a/hal/src/main/native/sim/DriverStation.cpp +++ b/hal/src/main/native/sim/DriverStation.cpp @@ -149,8 +149,7 @@ char* HAL_GetJoystickName(int32_t joystickNum) { SimDriverStationData->GetJoystickDescriptor(joystickNum, &desc); size_t len = std::strlen(desc.name); char* name = static_cast(std::malloc(len + 1)); - std::strncpy(name, desc.name, len); - name[len] = '\0'; + std::memcpy(name, desc.name, len + 1); return name; }