From ec3cb3dcbaaf90eff031ca742a08f49424b4fb94 Mon Sep 17 00:00:00 2001 From: Tyler Veness Date: Sun, 31 Dec 2023 23:25:05 -0800 Subject: [PATCH] [build] Disable clang-tidy warning about test case names (#6127) These are the warnings being disabled: ``` == clang-tidy /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp == /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:51:16: warning: avoid using "_" in test name "NonInvertibleA_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 51 | TEST(DARETest, NonInvertibleA_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:67:16: warning: avoid using "_" in test name "NonInvertibleA_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 67 | TEST(DARETest, NonInvertibleA_ABQRN) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:89:16: warning: avoid using "_" in test name "InvertibleA_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 89 | TEST(DARETest, InvertibleA_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:101:16: warning: avoid using "_" in test name "InvertibleA_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 101 | TEST(DARETest, InvertibleA_ABQRN) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:118:16: warning: avoid using "_" in test name "FirstGeneralizedEigenvalueOfSTIsStable_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 118 | TEST(DARETest, FirstGeneralizedEigenvalueOfSTIsStable_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:132:16: warning: avoid using "_" in test name "FirstGeneralizedEigenvalueOfSTIsStable_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 132 | TEST(DARETest, FirstGeneralizedEigenvalueOfSTIsStable_ABQRN) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:151:16: warning: avoid using "_" in test name "IdentitySystem_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 151 | TEST(DARETest, IdentitySystem_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:163:16: warning: avoid using "_" in test name "IdentitySystem_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 163 | TEST(DARETest, IdentitySystem_ABQRN) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:176:16: warning: avoid using "_" in test name "MoreInputsThanStates_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 176 | TEST(DARETest, MoreInputsThanStates_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:188:16: warning: avoid using "_" in test name "MoreInputsThanStates_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 188 | TEST(DARETest, MoreInputsThanStates_ABQRN) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:201:16: warning: avoid using "_" in test name "QNotSymmetricPositiveSemidefinite_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 201 | TEST(DARETest, QNotSymmetricPositiveSemidefinite_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:210:16: warning: avoid using "_" in test name "QNotSymmetricPositiveSemidefinite_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 210 | TEST(DARETest, QNotSymmetricPositiveSemidefinite_ABQRN) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:220:16: warning: avoid using "_" in test name "RNotSymmetricPositiveDefinite_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 220 | TEST(DARETest, RNotSymmetricPositiveDefinite_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:232:16: warning: avoid using "_" in test name "RNotSymmetricPositiveDefinite_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 232 | TEST(DARETest, RNotSymmetricPositiveDefinite_ABQRN) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:245:16: warning: avoid using "_" in test name "ABNotStabilizable_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 245 | TEST(DARETest, ABNotStabilizable_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:254:16: warning: avoid using "_" in test name "ABNotStabilizable_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 254 | TEST(DARETest, ABNotStabilizable_ABQRN) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:264:16: warning: avoid using "_" in test name "ACNotDetectable_ABQR" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 264 | TEST(DARETest, ACNotDetectable_ABQR) { | ^ /__w/allwpilib/allwpilib/wpimath/src/test/native/cpp/DARETest.cpp:273:16: warning: avoid using "_" in test name "ACNotDetectable_ABQRN" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name] 273 | TEST(DARETest, ACNotDetectable_ABQRN) { | ^ ``` --- .clang-tidy | 1 - 1 file changed, 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 6f1ae3a6d5..e8fe57b952 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -49,7 +49,6 @@ Checks: google-build-namespaces, google-explicit-constructor, google-global-names-in-headers, - google-readability-avoid-underscore-in-googletest-name, google-readability-casting, google-runtime-operator, misc-definitions-in-headers,