From eedb8910c36b732f7294886921b8d5d72847041b Mon Sep 17 00:00:00 2001 From: Tyler Veness Date: Tue, 2 Jan 2018 09:17:46 -0800 Subject: [PATCH] Removed extra newlines from beginning of Java classes (#859) The content of this PR was generated by styleguide#111. --- wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java | 2 -- wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/AccumulatorResult.java | 1 - .../main/java/edu/wpi/first/wpilibj/AnalogAccelerometer.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogGyro.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogInput.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java | 2 -- .../main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Counter.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/DMC60.java | 1 - .../main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/DoubleSolenoid.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java | 2 -- wpilibj/src/main/java/edu/wpi/first/wpilibj/Encoder.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/GearTooth.java | 1 - .../java/edu/wpi/first/wpilibj/InterruptableSensorBase.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Jaguar.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/MotorSafetyHelper.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Notifier.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/PIDController.java | 2 -- .../main/java/edu/wpi/first/wpilibj/PWMConfigDataResult.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMTalonSRX.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMVictorSPX.java | 1 - .../main/java/edu/wpi/first/wpilibj/PowerDistributionPanel.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Resource.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/SD540.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/SafePWM.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/SampleRobot.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Servo.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Solenoid.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/SolenoidBase.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Spark.java | 1 - .../main/java/edu/wpi/first/wpilibj/SpeedControllerGroup.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Talon.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Threads.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java | 2 -- wpilibj/src/main/java/edu/wpi/first/wpilibj/Utility.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/Victor.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/VictorSP.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Button.java | 1 - .../main/java/edu/wpi/first/wpilibj/buttons/InternalButton.java | 1 - .../main/java/edu/wpi/first/wpilibj/buttons/JoystickButton.java | 1 - .../main/java/edu/wpi/first/wpilibj/buttons/NetworkButton.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/buttons/Trigger.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/can/CANStatus.java | 1 - .../main/java/edu/wpi/first/wpilibj/command/CommandGroup.java | 2 -- .../wpi/first/wpilibj/command/IllegalUseOfCommandException.java | 1 - .../main/java/edu/wpi/first/wpilibj/command/InstantCommand.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/command/PIDCommand.java | 1 - .../main/java/edu/wpi/first/wpilibj/command/PIDSubsystem.java | 1 - .../main/java/edu/wpi/first/wpilibj/command/PrintCommand.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java | 1 - .../main/java/edu/wpi/first/wpilibj/command/StartCommand.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/command/Subsystem.java | 1 - .../main/java/edu/wpi/first/wpilibj/command/WaitCommand.java | 1 - .../java/edu/wpi/first/wpilibj/command/WaitForChildren.java | 1 - .../java/edu/wpi/first/wpilibj/command/WaitUntilCommand.java | 1 - wpilibj/src/main/java/edu/wpi/first/wpilibj/hal/EncoderJNI.java | 1 - .../main/java/edu/wpi/first/wpilibj/livewindow/LiveWindow.java | 1 - .../edu/wpi/first/wpilibj/smartdashboard/SendableChooser.java | 1 - .../java/edu/wpi/first/wpilibj/util/AllocationException.java | 1 - .../main/java/edu/wpi/first/wpilibj/util/BoundaryException.java | 1 - .../edu/wpi/first/wpilibj/util/CheckedAllocationException.java | 1 - .../java/edu/wpi/first/wpilibj/util/HalHandleException.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/util/SortedVector.java | 1 - .../java/edu/wpi/first/wpilibj/util/UncleanStatusException.java | 1 - .../main/java/edu/wpi/first/wpilibj/vision/VisionRunner.java | 1 - .../main/java/edu/wpi/first/wpilibj/vision/VisionThread.java | 1 - .../java/edu/wpi/first/wpilibj/command/AbstractCommandTest.java | 1 - .../edu/wpi/first/wpilibj/command/CommandParallelGroupTest.java | 1 - .../java/edu/wpi/first/wpilibj/command/CommandScheduleTest.java | 1 - .../java/edu/wpi/first/wpilibj/command/CommandTimeoutTest.java | 1 - .../java/edu/wpi/first/wpilibj/command/DefaultCommandTest.java | 2 -- .../java/edu/wpi/first/wpilibj/examples/axiscamera/Robot.java | 1 - .../main/java/edu/wpi/first/wpilibj/examples/gearsbot/OI.java | 1 - .../java/edu/wpi/first/wpilibj/examples/gearsbot/Robot.java | 1 - .../wpilibj/examples/gearsbot/commands/SetDistanceToBox.java | 1 - .../examples/gearsbot/commands/TankDriveWithJoystick.java | 1 - .../wpi/first/wpilibj/examples/gearsbot/subsystems/Claw.java | 1 - .../first/wpilibj/examples/gearsbot/subsystems/DriveTrain.java | 1 - .../first/wpilibj/examples/gearsbot/subsystems/Elevator.java | 1 - .../wpi/first/wpilibj/examples/gearsbot/subsystems/Wrist.java | 1 - .../edu/wpi/first/wpilibj/examples/gettingstarted/Robot.java | 1 - .../main/java/edu/wpi/first/wpilibj/examples/gyro/Robot.java | 1 - .../wpi/first/wpilibj/examples/intermediatevision/Robot.java | 1 - .../java/edu/wpi/first/wpilibj/examples/mecanumdrive/Robot.java | 1 - .../java/edu/wpi/first/wpilibj/examples/motorcontrol/Robot.java | 1 - .../main/java/edu/wpi/first/wpilibj/examples/pacgoat/Robot.java | 1 - .../wpi/first/wpilibj/examples/pacgoat/commands/CloseClaw.java | 1 - .../edu/wpi/first/wpilibj/examples/potentiometerpid/Robot.java | 1 - .../java/edu/wpi/first/wpilibj/examples/quickvision/Robot.java | 1 - .../java/edu/wpi/first/wpilibj/examples/tankdrive/Robot.java | 1 - .../edu/wpi/first/wpilibj/templates/commandbased/Robot.java | 1 - .../java/edu/wpi/first/wpilibj/templates/iterative/Robot.java | 1 - .../main/java/edu/wpi/first/wpilibj/templates/sample/Robot.java | 1 - .../main/java/edu/wpi/first/wpilibj/templates/timed/Robot.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/GyroTest.java | 1 - .../java/edu/wpi/first/wpilibj/command/CommandTestSuite.java | 1 - .../edu/wpi/first/wpilibj/fixtures/DIOCrossConnectFixture.java | 1 - .../wpi/first/wpilibj/fixtures/RelayCrossConnectFixture.java | 1 - .../main/java/edu/wpi/first/wpilibj/fixtures/SampleFixture.java | 1 - .../edu/wpi/first/wpilibj/mockhardware/FakeCounterSource.java | 2 -- .../edu/wpi/first/wpilibj/mockhardware/FakeEncoderSource.java | 2 -- .../java/edu/wpi/first/wpilibj/test/AbstractTestSuiteTest.java | 1 - .../main/java/edu/wpi/first/wpilibj/test/AntJunitLanucher.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/test/RepeatRule.java | 1 - .../src/main/java/edu/wpi/first/wpilibj/test/TestBench.java | 1 - 113 files changed, 122 deletions(-) diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java index aaad4aca64..030b0ea24e 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java @@ -22,7 +22,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; */ @SuppressWarnings({"TypeName", "PMD.UnusedPrivateField"}) public class ADXL345_I2C extends SensorBase implements Accelerometer, Sendable { - private static final byte kAddress = 0x1D; private static final byte kPowerCtlRegister = 0x2D; private static final byte kDataFormatRegister = 0x31; @@ -57,7 +56,6 @@ public class ADXL345_I2C extends SensorBase implements Accelerometer, Sendable { @SuppressWarnings("MemberName") public static class AllAxes { - public double XAxis; public double YAxis; public double ZAxis; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java index fcc2136226..23c77d489d 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java @@ -59,7 +59,6 @@ public class ADXL345_SPI extends SensorBase implements Accelerometer, Sendable { @SuppressWarnings("MemberName") public static class AllAxes { - public double XAxis; public double YAxis; public double ZAxis; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AccumulatorResult.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AccumulatorResult.java index d5e53b9be9..96aa42254f 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AccumulatorResult.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AccumulatorResult.java @@ -11,7 +11,6 @@ package edu.wpi.first.wpilibj; * Structure for holding the values stored in an accumulator. */ public class AccumulatorResult { - /** * The total value accumulated. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogAccelerometer.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogAccelerometer.java index 07a6f5d9cf..0840a4d6a2 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogAccelerometer.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogAccelerometer.java @@ -19,7 +19,6 @@ import static java.util.Objects.requireNonNull; * is calibrated by finding the center value over a period of time. */ public class AnalogAccelerometer extends SensorBase implements PIDSource, Sendable { - private AnalogInput m_analogChannel; private double m_voltsPerG = 1.0; private double m_zeroGVoltage = 2.5; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogGyro.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogGyro.java index 11b769778f..4f42d7ded5 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogGyro.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogGyro.java @@ -24,7 +24,6 @@ import static java.util.Objects.requireNonNull; *

This class is for gyro sensors that connect to an analog input. */ public class AnalogGyro extends GyroBase implements Gyro, PIDSource, Sendable { - private static final double kDefaultVoltsPerDegreePerSecond = 0.007; protected AnalogInput m_analog; private boolean m_channelAllocated = false; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogInput.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogInput.java index 668a278645..32e72671dc 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogInput.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogInput.java @@ -26,7 +26,6 @@ import edu.wpi.first.wpilibj.util.AllocationException; * number of samples to retain the resolution, but get more stable values. */ public class AnalogInput extends SensorBase implements PIDSource, Sendable { - private static final int kAccumulatorSlot = 1; int m_port; // explicit no modifier, private and package accessible. private int m_channel; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java index 0a7197ac3b..a0f6f0b4eb 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java @@ -21,12 +21,10 @@ import edu.wpi.first.wpilibj.util.BoundaryException; * Class for creating and configuring Analog Triggers. */ public class AnalogTrigger extends SensorBase implements Sendable { - /** * Exceptions dealing with improper operation of the Analog trigger. */ public class AnalogTriggerException extends RuntimeException { - /** * Create a new exception with the given message. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java index 793c81aae8..9a2b19937d 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java @@ -41,7 +41,6 @@ import static java.util.Objects.requireNonNull; * limited. */ public class AnalogTriggerOutput extends DigitalSource { - /** * Exceptions dealing with improper operation of the Analog trigger output. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Counter.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Counter.java index d0fa9c2eb3..fbcc2b1c44 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Counter.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Counter.java @@ -29,7 +29,6 @@ import static java.util.Objects.requireNonNull; * before use. */ public class Counter extends SensorBase implements CounterBase, Sendable, PIDSource { - /** * Mode determines how and what the counter counts. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DMC60.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DMC60.java index 9b6d5436c1..7c69f3aabb 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DMC60.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DMC60.java @@ -14,7 +14,6 @@ package edu.wpi.first.wpilibj; * Digilent DMC 60 Speed Controller. */ public class DMC60 extends PWMSpeedController { - /** * Constructor. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java index 36b6271265..e798236340 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilter.java @@ -21,7 +21,6 @@ import edu.wpi.first.wpilibj.hal.HAL; * that an input must remain high or low before it is classified as high or low. */ public class DigitalGlitchFilter extends SensorBase { - /** * Configures the Digital Glitch Filter to its default settings. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java index fdf88cdb2b..2e6b2fa5dd 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java @@ -17,7 +17,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * implemented elsewhere will automatically allocate digital inputs and outputs as required. */ public class DigitalOutput extends SendableBase implements Sendable { - private static final int invalidPwmGenerator = 0; private int m_pwmGenerator = invalidPwmGenerator; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DoubleSolenoid.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DoubleSolenoid.java index 0b68debd28..c67a5aba4b 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DoubleSolenoid.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DoubleSolenoid.java @@ -19,7 +19,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * controlled by two separate channels. */ public class DoubleSolenoid extends SolenoidBase implements Sendable { - /** * Possible values for a DoubleSolenoid. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java index 0a740ecd09..dbafd42fed 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java @@ -19,7 +19,6 @@ import edu.wpi.first.wpilibj.hal.PowerJNI; * Provide access to the network communication data to / from the Driver Station. */ public class DriverStation implements RobotState.Interface { - /** * Number of Joystick Ports. */ @@ -63,7 +62,6 @@ public class DriverStation implements RobotState.Interface { private double m_nextMessageTime = 0.0; private static class DriverStationTask implements Runnable { - private DriverStation m_ds; DriverStationTask(DriverStation ds) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Encoder.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Encoder.java index 472222ac89..14ee013c5f 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Encoder.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Encoder.java @@ -29,7 +29,6 @@ import static java.util.Objects.requireNonNull; * before use. */ public class Encoder extends SensorBase implements CounterBase, PIDSource, Sendable { - public enum IndexingType { kResetWhileHigh(0), kResetWhileLow(1), kResetOnFallingEdge(2), kResetOnRisingEdge(3); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/GearTooth.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/GearTooth.java index 0b392f5612..8b200b0a3c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/GearTooth.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/GearTooth.java @@ -17,7 +17,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * timing in the FPGA to sense direction. */ public class GearTooth extends Counter { - private static final double kGearToothThreshold = 55e-6; /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/InterruptableSensorBase.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/InterruptableSensorBase.java index e2da074f51..b8710f1501 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/InterruptableSensorBase.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/InterruptableSensorBase.java @@ -15,7 +15,6 @@ import edu.wpi.first.wpilibj.util.AllocationException; * Base for sensors to be used with interrupts. */ public abstract class InterruptableSensorBase extends SensorBase { - @SuppressWarnings("JavadocMethod") public enum WaitResult { kTimeout(0x0), kRisingEdge(0x1), kFallingEdge(0x100), kBoth(0x101); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Jaguar.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Jaguar.java index 80f3b944b9..3e018f5539 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Jaguar.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Jaguar.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.hal.HAL; * Texas Instruments / Vex Robotics Jaguar Speed Controller as a PWM device. */ public class Jaguar extends PWMSpeedController { - /** * Constructor. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/MotorSafetyHelper.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/MotorSafetyHelper.java index 752d23021a..afd2868b13 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/MotorSafetyHelper.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/MotorSafetyHelper.java @@ -17,7 +17,6 @@ import java.util.Set; * whenever the motors value is updated. */ public final class MotorSafetyHelper { - private double m_expiration; private boolean m_enabled; private double m_stopTime; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Notifier.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Notifier.java index d913133239..6e628c408e 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Notifier.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Notifier.java @@ -13,7 +13,6 @@ import java.util.concurrent.locks.ReentrantLock; import edu.wpi.first.wpilibj.hal.NotifierJNI; public class Notifier { - // The thread waiting on the HAL alarm. private final Thread m_thread; // The lock for the process information. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PIDController.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PIDController.java index bfdc118b55..bf4e425bf9 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PIDController.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PIDController.java @@ -27,7 +27,6 @@ import static java.util.Objects.requireNonNull; * given set of PID constants. */ public class PIDController extends SendableBase implements PIDInterface, Sendable, Controller { - public static final double kDefaultPeriod = .05; private static int instances = 0; @SuppressWarnings("MemberName") @@ -120,7 +119,6 @@ public class PIDController extends SendableBase implements PIDInterface, Sendabl } private class PIDTask extends TimerTask { - private PIDController m_controller; PIDTask(PIDController controller) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMConfigDataResult.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMConfigDataResult.java index 80ac6500cd..3c8a17b332 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMConfigDataResult.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMConfigDataResult.java @@ -11,7 +11,6 @@ package edu.wpi.first.wpilibj; * Structure for holding the config data result for PWM. */ public class PWMConfigDataResult { - PWMConfigDataResult(int max, int deadbandMax, int center, int deadbandMin, int min) { this.max = max; this.deadbandMax = deadbandMax; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMTalonSRX.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMTalonSRX.java index bb315e06df..02000386c5 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMTalonSRX.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMTalonSRX.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.hal.HAL; * Cross the Road Electronics (CTRE) Talon SRX Speed Controller with PWM control. */ public class PWMTalonSRX extends PWMSpeedController { - /** * Constructor for a PWMTalonSRX connected via PWM. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMVictorSPX.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMVictorSPX.java index 51b7049563..46e00e9518 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMVictorSPX.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PWMVictorSPX.java @@ -14,7 +14,6 @@ package edu.wpi.first.wpilibj; * Cross the Road Electronics (CTRE) Victor SPX Speed Controller with PWM control. */ public class PWMVictorSPX extends PWMSpeedController { - /** * Constructor for a PWMVictorSPX connected via PWM. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PowerDistributionPanel.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PowerDistributionPanel.java index 1e57a2e616..05c7e4678c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PowerDistributionPanel.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PowerDistributionPanel.java @@ -15,7 +15,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * Panel over CAN. */ public class PowerDistributionPanel extends SensorBase implements Sendable { - private final int m_module; /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java index 39da731ef8..4ce7c0f0d2 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Preferences.java @@ -32,7 +32,6 @@ import static java.util.Objects.requireNonNull; * with all the key-value pairs.

*/ public class Preferences { - /** * The Preferences table name. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java index 56a6c446d6..eecc6db74d 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java @@ -34,7 +34,6 @@ public class Relay extends SendableBase implements MotorSafety, Sendable { * which the relay is set. */ public class InvalidValueException extends RuntimeException { - /** * Create a new exception with the given message. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Resource.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Resource.java index 2f1f7a9def..09ff6e990a 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Resource.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Resource.java @@ -24,7 +24,6 @@ import edu.wpi.first.wpilibj.util.CheckedAllocationException; * unload/reload. */ public final class Resource { - private static Resource resourceList = null; private final boolean[] m_numAllocated; private final int m_size; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java index 854656b00d..2f3f0f1ac2 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/RobotDrive.java @@ -25,7 +25,6 @@ import static java.util.Objects.requireNonNull; */ @Deprecated public class RobotDrive implements MotorSafety { - protected MotorSafetyHelper m_safetyHelper; /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SD540.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SD540.java index 6c4b3cbb4b..96d94c33ab 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SD540.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SD540.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.hal.HAL; * Mindsensors SD540 Speed Controller. */ public class SD540 extends PWMSpeedController { - /** * Common initialization code called by all constructors. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java index dd119c8521..1fb5ec3015 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java @@ -17,7 +17,6 @@ import edu.wpi.first.wpilibj.hal.SPIJNI; * Represents a SPI bus port. */ public class SPI { - public enum Port { kOnboardCS0(0), kOnboardCS1(1), kOnboardCS2(2), kOnboardCS3(3), kMXP(4); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SafePWM.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SafePWM.java index 1d86f1ee45..8c95889dba 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SafePWM.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SafePWM.java @@ -11,7 +11,6 @@ package edu.wpi.first.wpilibj; * Manages a PWM object. */ public class SafePWM extends PWM implements MotorSafety { - private final MotorSafetyHelper m_safetyHelper; /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SampleRobot.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SampleRobot.java index dc5bf992d7..00b16d197b 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SampleRobot.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SampleRobot.java @@ -30,7 +30,6 @@ import edu.wpi.first.wpilibj.livewindow.LiveWindow; */ @Deprecated public class SampleRobot extends RobotBase { - private boolean m_robotMainOverridden = true; /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java index b4446944e5..98846aca3c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SerialPort.java @@ -25,7 +25,6 @@ import edu.wpi.first.wpilibj.hal.SerialPortJNI; * http://www.ni.com/pdf/manuals/370132c.pdf */ public class SerialPort { - private byte m_port; public enum Port { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Servo.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Servo.java index 5c2517787c..54938914f3 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Servo.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Servo.java @@ -18,7 +18,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * in the FIRST Kit of Parts in 2008. */ public class Servo extends PWM { - private static final double kMaxServoAngle = 180.0; private static final double kMinServoAngle = 0.0; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Solenoid.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Solenoid.java index c63c888bca..ab5446c59c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Solenoid.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Solenoid.java @@ -19,7 +19,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * device within the current spec of the PCM. */ public class Solenoid extends SolenoidBase implements Sendable { - private final int m_channel; // The channel to control. private int m_solenoidHandle; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SolenoidBase.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SolenoidBase.java index e81820acc4..67248ddea2 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SolenoidBase.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SolenoidBase.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.hal.SolenoidJNI; * classes. */ public abstract class SolenoidBase extends SendableBase { - protected final int m_moduleNumber; // The number of the solenoid module being used. /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Spark.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Spark.java index e6274e35a8..6e03636fa6 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Spark.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Spark.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.hal.HAL; * REV Robotics SPARK Speed Controller. */ public class Spark extends PWMSpeedController { - /** * Common initialization code called by all constructors. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SpeedControllerGroup.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SpeedControllerGroup.java index 53c4cca9ec..7c3c8dc7c7 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SpeedControllerGroup.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SpeedControllerGroup.java @@ -13,7 +13,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * Allows multiple {@link SpeedController} objects to be linked together. */ public class SpeedControllerGroup extends SendableBase implements SpeedController { - private boolean m_isInverted = false; private final SpeedController[] m_speedControllers; private static int instances = 0; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Talon.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Talon.java index 6cb46d8cac..8a933b5a76 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Talon.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Talon.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.hal.HAL; * Cross the Road Electronics (CTRE) Talon and Talon SR Speed Controller. */ public class Talon extends PWMSpeedController { - /** * Constructor for a Talon (original or Talon SR). * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Threads.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Threads.java index 1b89ea1701..2c293fd290 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Threads.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Threads.java @@ -10,7 +10,6 @@ package edu.wpi.first.wpilibj; import edu.wpi.first.wpilibj.hal.ThreadsJNI; public class Threads { - /** * Get the thread priority for the current thread. * @return The current thread priority. Scaled 1-99. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java index f5b028a5db..3af20a7ff6 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Ultrasonic.java @@ -23,7 +23,6 @@ import static java.util.Objects.requireNonNull; * flight). */ public class Ultrasonic extends SensorBase implements PIDSource, Sendable { - /** * The units to return when PIDGet is called. */ @@ -67,7 +66,6 @@ public class Ultrasonic extends SensorBase implements PIDSource, Sendable { * sensors!! */ private class UltrasonicChecker extends Thread { - @Override public synchronized void run() { Ultrasonic ultrasonic = null; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Utility.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Utility.java index 0a9e44c5f1..06239a0444 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Utility.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Utility.java @@ -15,7 +15,6 @@ import edu.wpi.first.wpilibj.hal.HALUtil; */ @Deprecated public final class Utility { - private Utility() { } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Victor.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Victor.java index 0c6d0de727..7c4cbb8679 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Victor.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Victor.java @@ -15,7 +15,6 @@ import edu.wpi.first.wpilibj.hal.HAL; * be used with this class but may need to be calibrated per the Victor 884 user manual. */ public class Victor extends PWMSpeedController { - /** * Constructor. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/VictorSP.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/VictorSP.java index 2ae3bfc305..663d271111 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/VictorSP.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/VictorSP.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.hal.HAL; * VEX Robotics Victor SP Speed Controller. */ public class VictorSP extends PWMSpeedController { - /** * Constructor. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Button.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Button.java index 3bac7f8748..769604e281 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Button.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Button.java @@ -20,7 +20,6 @@ import edu.wpi.first.wpilibj.command.Command; * wrapper around Trigger with the method names renamed to fit the Button object use. */ public abstract class Button extends Trigger { - /** * Starts the given command whenever the button is newly pressed. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/InternalButton.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/InternalButton.java index fc73bb979b..c0c5b2aee7 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/InternalButton.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/InternalButton.java @@ -12,7 +12,6 @@ package edu.wpi.first.wpilibj.buttons; * Also includes a setting for whether or not it should invert its value. */ public class InternalButton extends Button { - private boolean m_pressed; private boolean m_inverted; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/JoystickButton.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/JoystickButton.java index e364e5ec39..a041b9acbd 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/JoystickButton.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/JoystickButton.java @@ -13,7 +13,6 @@ import edu.wpi.first.wpilibj.GenericHID; * A {@link Button} that gets its state from a {@link GenericHID}. */ public class JoystickButton extends Button { - private final GenericHID m_joystick; private final int m_buttonNumber; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/NetworkButton.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/NetworkButton.java index 3d354f8909..ad54758c18 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/NetworkButton.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/NetworkButton.java @@ -15,7 +15,6 @@ import edu.wpi.first.networktables.NetworkTableInstance; * A {@link Button} that uses a {@link NetworkTable} boolean field. */ public class NetworkButton extends Button { - private final NetworkTableEntry m_entry; public NetworkButton(String table, String field) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Trigger.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Trigger.java index 6f6f5b7193..82abc150d4 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Trigger.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/buttons/Trigger.java @@ -24,7 +24,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * the full functionality of the Trigger class. */ public abstract class Trigger extends SendableBase { - private volatile boolean m_sendablePressed = false; /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/can/CANStatus.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/can/CANStatus.java index f85abe33e4..598735b2ef 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/can/CANStatus.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/can/CANStatus.java @@ -11,7 +11,6 @@ package edu.wpi.first.wpilibj.can; * Structure for holding the result of a CAN Status request. */ public class CANStatus { - /** * The utilization of the CAN Bus. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java index 2644f55ff8..acd249a153 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/CommandGroup.java @@ -32,7 +32,6 @@ import static java.util.Objects.requireNonNull; * @see IllegalUseOfCommandException */ public class CommandGroup extends Command { - /** * The commands in this group (stored in entries). */ @@ -380,7 +379,6 @@ public class CommandGroup extends Command { } private static class Entry { - private static final int IN_SEQUENCE = 0; private static final int BRANCH_PEER = 1; private static final int BRANCH_CHILD = 2; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/IllegalUseOfCommandException.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/IllegalUseOfCommandException.java index 1e7dbb0bac..3416a586a0 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/IllegalUseOfCommandException.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/IllegalUseOfCommandException.java @@ -19,7 +19,6 @@ package edu.wpi.first.wpilibj.command; * a new child.

*/ public class IllegalUseOfCommandException extends RuntimeException { - /** * Instantiates an {@link IllegalUseOfCommandException}. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/InstantCommand.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/InstantCommand.java index f885fef65b..0fd7e186d1 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/InstantCommand.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/InstantCommand.java @@ -14,7 +14,6 @@ package edu.wpi.first.wpilibj.command; * {@link Command isFinished}. */ public class InstantCommand extends Command { - public InstantCommand() { } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PIDCommand.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PIDCommand.java index 9a987aa3dc..f4dd5eacdd 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PIDCommand.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PIDCommand.java @@ -22,7 +22,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * ended/interrupted.

*/ public abstract class PIDCommand extends Command implements Sendable { - /** * The internal {@link PIDController}. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PIDSubsystem.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PIDSubsystem.java index 55487b3106..922c96d72a 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PIDSubsystem.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PIDSubsystem.java @@ -23,7 +23,6 @@ import edu.wpi.first.wpilibj.Sendable; * programmer. */ public abstract class PIDSubsystem extends Subsystem implements Sendable { - /** * The internal {@link PIDController}. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PrintCommand.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PrintCommand.java index 2d78ffe441..a4381d21cd 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PrintCommand.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/PrintCommand.java @@ -13,7 +13,6 @@ package edu.wpi.first.wpilibj.command; * it reaches a certain point. */ public class PrintCommand extends InstantCommand { - /** * The message to print out. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java index 2c9b3a0fc9..c70b94dfe2 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/Scheduler.java @@ -31,7 +31,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * @see Command */ public class Scheduler extends SendableBase implements Sendable { - /** * The Singleton Instance. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/StartCommand.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/StartCommand.java index b77c987f25..a195a719e7 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/StartCommand.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/StartCommand.java @@ -12,7 +12,6 @@ package edu.wpi.first.wpilibj.command; * when it is initialized and will finish immediately. */ public class StartCommand extends InstantCommand { - /** * The command to fork. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/Subsystem.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/Subsystem.java index b529a62757..b5883fe1a7 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/Subsystem.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/Subsystem.java @@ -29,7 +29,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SendableBuilder; * @see Command */ public abstract class Subsystem extends SendableBase implements Sendable { - /** * Whether or not getDefaultCommand() was called. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitCommand.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitCommand.java index 652fc0c4db..0dcdbc5947 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitCommand.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitCommand.java @@ -14,7 +14,6 @@ package edu.wpi.first.wpilibj.command; * @see CommandGroup */ public class WaitCommand extends TimedCommand { - /** * Instantiates a {@link WaitCommand} with the given timeout. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitForChildren.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitForChildren.java index 0c75e5ec02..857be12fff 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitForChildren.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitForChildren.java @@ -16,7 +16,6 @@ package edu.wpi.first.wpilibj.command; * to finish, before continuing in the main {@link CommandGroup} sequence. */ public class WaitForChildren extends Command { - protected boolean isFinished() { return getGroup() == null || getGroup().m_children.isEmpty(); } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitUntilCommand.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitUntilCommand.java index 274400f901..de671ef3f5 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitUntilCommand.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/command/WaitUntilCommand.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.Timer; * some value, then continue to the next command. */ public class WaitUntilCommand extends Command { - private double m_time; public WaitUntilCommand(double time) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/hal/EncoderJNI.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/hal/EncoderJNI.java index aaa3684f90..63224117c8 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/hal/EncoderJNI.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/hal/EncoderJNI.java @@ -8,7 +8,6 @@ package edu.wpi.first.wpilibj.hal; public class EncoderJNI extends JNIWrapper { - public static native int initializeEncoder(int digitalSourceHandleA, int analogTriggerTypeA, int digitalSourceHandleB, int analogTriggerTypeB, boolean reverseDirection, int encodingType); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/livewindow/LiveWindow.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/livewindow/LiveWindow.java index 378f1d86bb..a3d3ba505c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/livewindow/LiveWindow.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/livewindow/LiveWindow.java @@ -23,7 +23,6 @@ import edu.wpi.first.wpilibj.Sendable; * LiveWindow. */ public class LiveWindow { - private static class Component { Component(Sendable sendable, Sendable parent) { m_sendable = sendable; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableChooser.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableChooser.java index 752845f998..ef58dbf498 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableChooser.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableChooser.java @@ -29,7 +29,6 @@ import static java.util.Objects.requireNonNull; * @param The type of the values to be stored */ public class SendableChooser extends SendableBase implements Sendable { - /** * The key for the default value. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/AllocationException.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/AllocationException.java index a472ad1c55..4fa3b618f0 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/AllocationException.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/AllocationException.java @@ -11,7 +11,6 @@ package edu.wpi.first.wpilibj.util; * Exception indicating that the resource is already allocated. */ public class AllocationException extends RuntimeException { - /** * Create a new AllocationException. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/BoundaryException.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/BoundaryException.java index 0422dcd450..413aab05a6 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/BoundaryException.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/BoundaryException.java @@ -11,7 +11,6 @@ package edu.wpi.first.wpilibj.util; * This exception represents an error in which a lower limit was set as higher than an upper limit. */ public class BoundaryException extends RuntimeException { - /** * Create a new exception with the given message. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/CheckedAllocationException.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/CheckedAllocationException.java index 656a69ad71..b4e05a2c1c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/CheckedAllocationException.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/CheckedAllocationException.java @@ -12,7 +12,6 @@ package edu.wpi.first.wpilibj.util; * resource class. */ public class CheckedAllocationException extends Exception { - /** * Create a new CheckedAllocationException. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/HalHandleException.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/HalHandleException.java index 1262e874bf..130ec84d71 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/HalHandleException.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/HalHandleException.java @@ -11,7 +11,6 @@ package edu.wpi.first.wpilibj.util; * Exception indicating that an error has occured with a HAL Handle. */ public class HalHandleException extends RuntimeException { - /** * Create a new HalHandleException. * diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/SortedVector.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/SortedVector.java index 984d95c727..605a978f44 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/SortedVector.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/SortedVector.java @@ -13,7 +13,6 @@ import java.util.Vector; * A vector that is sorted. */ public class SortedVector extends Vector { - /** * Interface used to determine the order to place sorted objects. */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/UncleanStatusException.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/UncleanStatusException.java index 4b745ebe2c..6c3140f65a 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/UncleanStatusException.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/util/UncleanStatusException.java @@ -11,7 +11,6 @@ package edu.wpi.first.wpilibj.util; * Exception for bad status codes from the chip object. */ public final class UncleanStatusException extends IllegalStateException { - private final int m_statusCode; /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/vision/VisionRunner.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/vision/VisionRunner.java index 2f44ebf563..62930aea47 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/vision/VisionRunner.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/vision/VisionRunner.java @@ -23,7 +23,6 @@ import org.opencv.core.Mat; * @see edu.wpi.first.wpilibj.vision */ public class VisionRunner

{ - private final CvSink m_cvSink = new CvSink("VisionRunner CvSink"); private final P m_pipeline; private final Mat m_image = new Mat(); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/vision/VisionThread.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/vision/VisionThread.java index 8c7839f614..769cab0518 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/vision/VisionThread.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/vision/VisionThread.java @@ -19,7 +19,6 @@ import edu.wpi.cscore.VideoSource; * @see Thread#setDaemon(boolean) */ public class VisionThread extends Thread { - /** * Creates a vision thread that continuously runs a {@link VisionPipeline}. * diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/AbstractCommandTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/AbstractCommandTest.java index ffe214b9c1..587f81f4d2 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/AbstractCommandTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/AbstractCommandTest.java @@ -18,7 +18,6 @@ import static org.junit.Assert.fail; * The basic test for all {@link Command} tests. */ public abstract class AbstractCommandTest { - @Before public void commandSetup() { UnitTestUtility.setupMockBase(); diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandParallelGroupTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandParallelGroupTest.java index 71861bd880..6e18243220 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandParallelGroupTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandParallelGroupTest.java @@ -13,7 +13,6 @@ import org.junit.Test; * Ported from the old CrioTest Classes. */ public class CommandParallelGroupTest extends AbstractCommandTest { - /** * Simple Parallel Command Group With 2 commands one command terminates first. */ diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandScheduleTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandScheduleTest.java index 26d6be10cd..98a4f6e99c 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandScheduleTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandScheduleTest.java @@ -13,7 +13,6 @@ import org.junit.Test; * Ported from the old CrioTest Classes. */ public class CommandScheduleTest extends AbstractCommandTest { - /** * Simple scheduling of a command and making sure the command is run and successfully terminates. */ diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandTimeoutTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandTimeoutTest.java index 40c321d2e1..402f1ff89d 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandTimeoutTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/CommandTimeoutTest.java @@ -13,7 +13,6 @@ import org.junit.Test; * Test a {@link Command} that times out. */ public class CommandTimeoutTest extends AbstractCommandTest { - /** * Command 2 second Timeout Test. */ diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/DefaultCommandTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/DefaultCommandTest.java index c8f0f34058..06c09c2269 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/DefaultCommandTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/command/DefaultCommandTest.java @@ -13,8 +13,6 @@ import org.junit.Test; * Tests the {@link Command} library. */ public class DefaultCommandTest extends AbstractCommandTest { - - /** * Testing of default commands where the interrupting command ends itself. */ diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/axiscamera/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/axiscamera/Robot.java index 33d48db042..47844da25c 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/axiscamera/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/axiscamera/Robot.java @@ -24,7 +24,6 @@ import org.opencv.imgproc.Imgproc; * processing. */ public class Robot extends IterativeRobot { - Thread m_visionThread; @Override diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/OI.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/OI.java index 3c197022f8..82356510b4 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/OI.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/OI.java @@ -24,7 +24,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; * interface to the commands and command groups that allow control of the robot. */ public class OI { - private Joystick m_joystick = new Joystick(0); public OI() { diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/Robot.java index 75e7ceb2df..74d3e82d37 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/Robot.java @@ -26,7 +26,6 @@ import edu.wpi.first.wpilibj.examples.gearsbot.subsystems.Wrist; * directory. */ public class Robot extends IterativeRobot { - Command m_autonomousCommand; public static DriveTrain m_drivetrain; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/commands/SetDistanceToBox.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/commands/SetDistanceToBox.java index b96aa67f83..80214b9c39 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/commands/SetDistanceToBox.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/commands/SetDistanceToBox.java @@ -20,7 +20,6 @@ import edu.wpi.first.wpilibj.examples.gearsbot.Robot; * encoders. */ public class SetDistanceToBox extends Command { - private PIDController m_pid; public SetDistanceToBox(double distance) { diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/commands/TankDriveWithJoystick.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/commands/TankDriveWithJoystick.java index d4e0ee895e..c3f169ff55 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/commands/TankDriveWithJoystick.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/commands/TankDriveWithJoystick.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.examples.gearsbot.Robot; * Have the robot drive tank style using the PS3 Joystick until interrupted. */ public class TankDriveWithJoystick extends Command { - public TankDriveWithJoystick() { requires(Robot.m_drivetrain); } diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Claw.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Claw.java index 3e4d3e4ca6..789ead0980 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Claw.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Claw.java @@ -17,7 +17,6 @@ import edu.wpi.first.wpilibj.command.Subsystem; * don't stall. */ public class Claw extends Subsystem { - private Victor m_motor = new Victor(7); private DigitalInput m_contact = new DigitalInput(5); diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/DriveTrain.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/DriveTrain.java index ee679ed097..8fcb5e4c0b 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/DriveTrain.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/DriveTrain.java @@ -26,7 +26,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; * and a gyro. */ public class DriveTrain extends Subsystem { - private SpeedController m_leftMotor = new SpeedControllerGroup(new Spark(0), new Spark(1)); private SpeedController m_rightMotor diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Elevator.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Elevator.java index 583ed83d82..7cb5a0992c 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Elevator.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Elevator.java @@ -19,7 +19,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; * world do to minor differences. */ public class Elevator extends PIDSubsystem { - private Victor m_motor; private AnalogPotentiometer m_pot; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Wrist.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Wrist.java index 3fa6bce39e..0bf4413571 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Wrist.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gearsbot/subsystems/Wrist.java @@ -18,7 +18,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; * of a linear joint. */ public class Wrist extends PIDSubsystem { - private Victor m_motor; private AnalogPotentiometer m_pot; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gettingstarted/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gettingstarted/Robot.java index 39cd0de590..590fa1eda9 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gettingstarted/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gettingstarted/Robot.java @@ -21,7 +21,6 @@ import edu.wpi.first.wpilibj.drive.DifferentialDrive; * directory. */ public class Robot extends IterativeRobot { - private DifferentialDrive m_robotDrive = new DifferentialDrive(new Spark(0), new Spark(1)); private Joystick m_stick = new Joystick(0); diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gyro/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gyro/Robot.java index 4cc98911a5..176ed13bab 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gyro/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/gyro/Robot.java @@ -19,7 +19,6 @@ import edu.wpi.first.wpilibj.drive.DifferentialDrive; * backwards while the gyro is used for direction keeping. */ public class Robot extends IterativeRobot { - private static final double kAngleSetpoint = 0.0; private static final double kP = 0.005; // propotional turning constant diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/intermediatevision/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/intermediatevision/Robot.java index a4ee8b4ee5..2fc5dfaf31 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/intermediatevision/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/intermediatevision/Robot.java @@ -24,7 +24,6 @@ import org.opencv.imgproc.Imgproc; * processing. */ public class Robot extends IterativeRobot { - Thread m_visionThread; @Override diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/mecanumdrive/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/mecanumdrive/Robot.java index 9e7813d653..374e6a21d7 100755 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/mecanumdrive/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/mecanumdrive/Robot.java @@ -17,7 +17,6 @@ import edu.wpi.first.wpilibj.drive.MecanumDrive; * class. */ public class Robot extends IterativeRobot { - private static final int kFrontLeftChannel = 2; private static final int kRearLeftChannel = 3; private static final int kFrontRightChannel = 1; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/motorcontrol/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/motorcontrol/Robot.java index 8b4844ef29..d8644c648d 100755 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/motorcontrol/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/motorcontrol/Robot.java @@ -21,7 +21,6 @@ import edu.wpi.first.wpilibj.Spark; * range from -1 to 1 making it easy to work together. */ public class Robot extends IterativeRobot { - private static final int kMotorPort = 0; private static final int kJoystickPort = 0; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/Robot.java index 01eb26c0e1..d58ddf122f 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/Robot.java @@ -31,7 +31,6 @@ import edu.wpi.first.wpilibj.examples.pacgoat.subsystems.Shooter; * directory. */ public class Robot extends IterativeRobot { - Command m_autonomousCommand; public static OI oi; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/commands/CloseClaw.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/commands/CloseClaw.java index 7ee69f8850..f1a921ef24 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/commands/CloseClaw.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/pacgoat/commands/CloseClaw.java @@ -18,7 +18,6 @@ import edu.wpi.first.wpilibj.examples.pacgoat.Robot; * detect that. */ public class CloseClaw extends InstantCommand { - public CloseClaw() { requires(Robot.collector); } diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/potentiometerpid/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/potentiometerpid/Robot.java index 230091e811..adf0675268 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/potentiometerpid/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/potentiometerpid/Robot.java @@ -20,7 +20,6 @@ import edu.wpi.first.wpilibj.Joystick; * mechanism. */ public class Robot extends IterativeRobot { - private static final int kPotChannel = 1; private static final int kMotorChannel = 7; private static final int kJoystickChannel = 0; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/quickvision/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/quickvision/Robot.java index b27172107b..05c230ecca 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/quickvision/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/quickvision/Robot.java @@ -17,7 +17,6 @@ import edu.wpi.first.wpilibj.IterativeRobot; * the robotInit() method in your program. */ public class Robot extends IterativeRobot { - @Override public void robotInit() { CameraServer.getInstance().startAutomaticCapture(); diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/tankdrive/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/tankdrive/Robot.java index 5ea527cdb0..ab377d7494 100755 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/tankdrive/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/tankdrive/Robot.java @@ -17,7 +17,6 @@ import edu.wpi.first.wpilibj.drive.DifferentialDrive; * it contains the code necessary to operate a robot with tank drive. */ public class Robot extends IterativeRobot { - private DifferentialDrive m_myRobot; private Joystick m_leftStick; private Joystick m_rightStick; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/commandbased/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/commandbased/Robot.java index c5b3f4ca1e..8386b6f904 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/commandbased/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/commandbased/Robot.java @@ -23,7 +23,6 @@ import edu.wpi.first.wpilibj.templates.commandbased.subsystems.ExampleSubsystem; * project. */ public class Robot extends TimedRobot { - public static final ExampleSubsystem kExampleSubsystem = new ExampleSubsystem(); public static OI m_oi; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/iterative/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/iterative/Robot.java index 1eee908215..e4deab82c4 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/iterative/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/iterative/Robot.java @@ -19,7 +19,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; * project. */ public class Robot extends IterativeRobot { - private static final String kDefaultAuto = "Default"; private static final String kCustomAuto = "My Auto"; private String m_autoSelected; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/sample/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/sample/Robot.java index ce33ff0476..99474c452a 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/sample/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/sample/Robot.java @@ -33,7 +33,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; * Command-Based instead if you're new. */ public class Robot extends SampleRobot { - private static final String kDefaultAuto = "Default"; private static final String kCustomAuto = "My Auto"; diff --git a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/timed/Robot.java b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/timed/Robot.java index 22c17f3f33..db095c5891 100644 --- a/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/timed/Robot.java +++ b/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/templates/timed/Robot.java @@ -19,7 +19,6 @@ import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; * project. */ public class Robot extends TimedRobot { - private static final String kDefaultAuto = "Default"; private static final String kCustomAuto = "My Auto"; private String m_autoSelected; diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/GyroTest.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/GyroTest.java index c81cfec6df..639cf0327c 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/GyroTest.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/GyroTest.java @@ -23,7 +23,6 @@ import static org.junit.Assert.assertEquals; * Tests that the {@link TiltPanCameraFixture}. */ public class GyroTest extends AbstractComsSetup { - private static final Logger logger = Logger.getLogger(GyroTest.class.getName()); public static final double TEST_ANGLE = 90.0; diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/command/CommandTestSuite.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/command/CommandTestSuite.java index dffb31719c..10e1cb01cf 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/command/CommandTestSuite.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/command/CommandTestSuite.java @@ -21,5 +21,4 @@ import edu.wpi.first.wpilibj.test.AbstractTestSuite; CommandSequentialGroupTest.class, CommandSupersedeTest.class, CommandTimeoutTest.class, ConditionalCommandTest.class, DefaultCommandTest.class}) public class CommandTestSuite extends AbstractTestSuite { - } diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/DIOCrossConnectFixture.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/DIOCrossConnectFixture.java index 7974b1463a..4eb7fb460e 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/DIOCrossConnectFixture.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/DIOCrossConnectFixture.java @@ -17,7 +17,6 @@ import edu.wpi.first.wpilibj.DigitalOutput; * Connects a digital input to a digital output. */ public class DIOCrossConnectFixture implements ITestFixture { - private static final Logger logger = Logger.getLogger(DIOCrossConnectFixture.class.getName()); private final DigitalInput m_input; diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/RelayCrossConnectFixture.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/RelayCrossConnectFixture.java index 31e104a6c9..e444bbbd7d 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/RelayCrossConnectFixture.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/RelayCrossConnectFixture.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.Relay; * A connection between a {@link Relay} and two {@link DigitalInput DigitalInputs}. */ public abstract class RelayCrossConnectFixture implements ITestFixture { - private DigitalInput m_inputOne; private DigitalInput m_inputTwo; private Relay m_relay; diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/SampleFixture.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/SampleFixture.java index 9ae7a60f5d..d90ae51f1c 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/SampleFixture.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/fixtures/SampleFixture.java @@ -13,7 +13,6 @@ package edu.wpi.first.wpilibj.fixtures; * test. */ public class SampleFixture implements ITestFixture { - @Override public boolean setup() { /* diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeCounterSource.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeCounterSource.java index acbf76e01b..9d4ef9565c 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeCounterSource.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeCounterSource.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.Timer; * Simulates an encoder for testing purposes. */ public class FakeCounterSource { - private Thread m_task; private int m_count; private int m_milliSec; @@ -25,7 +24,6 @@ public class FakeCounterSource { * Thread object that allows emulation of an encoder. */ private class EncoderThread extends Thread { - FakeCounterSource m_encoder; EncoderThread(FakeCounterSource encode) { diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeEncoderSource.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeEncoderSource.java index 13f7dbafda..954b59ade0 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeEncoderSource.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/mockhardware/FakeEncoderSource.java @@ -14,7 +14,6 @@ import edu.wpi.first.wpilibj.Timer; * Emulates a quadrature encoder. */ public class FakeEncoderSource { - private Thread m_task; private int m_count; private int m_milliSec; @@ -27,7 +26,6 @@ public class FakeEncoderSource { * Thread object that allows emulation of a quadrature encoder. */ private class QuadEncoderThread extends Thread { - FakeEncoderSource m_encoder; QuadEncoderThread(FakeEncoderSource encode) { diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AbstractTestSuiteTest.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AbstractTestSuiteTest.java index 4f91ae4245..2d325f933f 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AbstractTestSuiteTest.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AbstractTestSuiteTest.java @@ -30,7 +30,6 @@ import static org.junit.Assert.assertEquals; */ @SuppressWarnings("MultipleTopLevelClasses") public class AbstractTestSuiteTest { - @Ignore("Prevents ANT from trying to run these as tests") @RunWith(Suite.class) @SuiteClasses({FirstSampleTest.class, SecondSampleTest.class, ThirdSampleTest.class, diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AntJunitLanucher.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AntJunitLanucher.java index 9408b9a1c6..ab9b9f1fda 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AntJunitLanucher.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AntJunitLanucher.java @@ -21,7 +21,6 @@ import java.io.File; * results for Jenkins. */ public class AntJunitLanucher { - /** * Main entry point for jenkins. * diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/RepeatRule.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/RepeatRule.java index 5687d5a72e..cf4c3d09a0 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/RepeatRule.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/RepeatRule.java @@ -36,7 +36,6 @@ public class RepeatRule implements TestRule { private static class RepeatStatement extends Statement { - private final int m_times; private final Statement m_statement; diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java index b27f9d7537..2cba9ee279 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java @@ -38,7 +38,6 @@ import edu.wpi.first.wpilibj.fixtures.TiltPanCameraFixture; * TestBench}. */ public final class TestBench { - /** * The time that it takes to have a motor go from rotating at full speed to completely stopped. */