Fix newer GCC/clang compiler warnings (#1718)

This commit is contained in:
Peter Johnson
2019-06-14 18:32:27 -07:00
committed by GitHub
parent 0120f31247
commit f07569df19
3 changed files with 7 additions and 15 deletions

View File

@@ -448,7 +448,7 @@ void UsbCameraImpl::DeviceDisconnect() {
// Unmap buffers
for (int i = 0; i < kNumBuffers; ++i)
m_buffers[i] = std::move(UsbCameraBuffer{});
m_buffers[i] = UsbCameraBuffer{};
// Close device
close(fd);
@@ -534,11 +534,11 @@ void UsbCameraImpl::DeviceConnect() {
SDEBUG4("buf " << i << " length=" << buf.length
<< " offset=" << buf.m.offset);
m_buffers[i] = std::move(UsbCameraBuffer(fd, buf.length, buf.m.offset));
m_buffers[i] = UsbCameraBuffer(fd, buf.length, buf.m.offset);
if (!m_buffers[i].m_data) {
SWARNING("could not map buffer " << i);
// release other buffers
for (int j = 0; j < i; ++j) m_buffers[j] = std::move(UsbCameraBuffer{});
for (int j = 0; j < i; ++j) m_buffers[j] = UsbCameraBuffer{};
close(fd);
m_fd = -1;
return;