Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-30 02:31:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing compiler flags and fix warnings (#4889)

Browse Source 
This makes the build fail on warnings. It caught two out-of-bounds reads
and a deprecation warning.
This commit is contained in:
Tyler Veness
2023-01-01 08:14:19 -08:00
committed by GitHub
parent 42fc4cb6bc
commit f0fa8205ac
9 changed files with 28 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wpilibcExamples/CMakeLists.txt
View File

@@ -10,6 +10,7 @@ foreach(example ${EXAMPLES})
file(GLOB_RECURSE sources src/main/cpp/examples/${example}/cpp/*.cpp
src/main/cpp/examples/${example}/c/*.c)
add_executable(${example} ${sources})
wpilib_target_warnings(${example})
target_include_directories(${example} PUBLIC src/main/cpp/examples/${example}/include)
target_link_libraries(${example} wpilibc wpilibNewCommands)
@@ -28,6 +29,7 @@ foreach(template ${TEMPLATES})
file(GLOB_RECURSE sources src/main/cpp/templates/${template}/cpp/*.cpp
src/main/cpp/templates/${template}/c/*.c)
add_executable(${template} ${sources})
wpilib_target_warnings(${template})
target_include_directories(${template} PUBLIC src/main/cpp/templates/${template}/include)
target_link_libraries(${template} wpilibc wpilibNewCommands)
endforeach()

2
wpilibcExamples/src/main/cpp/examples/MecanumDrivePoseEstimator/include/ExampleGlobalMeasurementSensor.h
View File

@@ -19,6 +19,6 @@ class ExampleGlobalMeasurementSensor {
return frc::Pose2d{estimatedRobotPose.X() + units::meter_t{randVec(0)},
estimatedRobotPose.Y() + units::meter_t{randVec(1)},
estimatedRobotPose.Rotation() +
frc::Rotation2d{units::radian_t{randVec(3)}}};
frc::Rotation2d{units::radian_t{randVec(2)}}};
}
};

2
wpilibcExamples/src/main/cpp/examples/RomiReference/include/RobotContainer.h
View File

@@ -51,7 +51,7 @@ class RobotContainer {
OnBoardIO::ChannelMode::INPUT};
// Example button
frc2::Button m_onboardButtonA{
frc2::Trigger m_onboardButtonA{
[this] { return m_onboardIO.GetButtonAPressed(); }};
// Autonomous commands.

2
wpilibcExamples/src/main/cpp/examples/SwerveDrivePoseEstimator/include/ExampleGlobalMeasurementSensor.h
View File

@@ -19,6 +19,6 @@ class ExampleGlobalMeasurementSensor {
return frc::Pose2d{estimatedRobotPose.X() + units::meter_t{randVec(0)},
estimatedRobotPose.Y() + units::meter_t{randVec(1)},
estimatedRobotPose.Rotation() +
frc::Rotation2d{units::radian_t{randVec(3)}}};
frc::Rotation2d{units::radian_t{randVec(2)}}};
}
};