diff --git a/hal/src/main/java/edu/wpi/first/hal/util/AllocationException.java b/hal/src/main/java/edu/wpi/first/hal/util/AllocationException.java index e9f9a9103b..3591a5f7a8 100644 --- a/hal/src/main/java/edu/wpi/first/hal/util/AllocationException.java +++ b/hal/src/main/java/edu/wpi/first/hal/util/AllocationException.java @@ -5,7 +5,6 @@ package edu.wpi.first.hal.util; /** Exception indicating that the resource is already allocated. */ -@SuppressWarnings("serial") public class AllocationException extends RuntimeException { /** * Create a new AllocationException. diff --git a/hal/src/main/java/edu/wpi/first/hal/util/BoundaryException.java b/hal/src/main/java/edu/wpi/first/hal/util/BoundaryException.java index 683980dc91..bbecbbec3b 100644 --- a/hal/src/main/java/edu/wpi/first/hal/util/BoundaryException.java +++ b/hal/src/main/java/edu/wpi/first/hal/util/BoundaryException.java @@ -7,7 +7,6 @@ package edu.wpi.first.hal.util; /** * This exception represents an error in which a lower limit was set as higher than an upper limit. */ -@SuppressWarnings("serial") public class BoundaryException extends RuntimeException { /** * Create a new exception with the given message. diff --git a/hal/src/main/java/edu/wpi/first/hal/util/CheckedAllocationException.java b/hal/src/main/java/edu/wpi/first/hal/util/CheckedAllocationException.java index 6155f17d38..81de150a05 100644 --- a/hal/src/main/java/edu/wpi/first/hal/util/CheckedAllocationException.java +++ b/hal/src/main/java/edu/wpi/first/hal/util/CheckedAllocationException.java @@ -8,7 +8,6 @@ package edu.wpi.first.hal.util; * Exception indicating that the resource is already allocated This is meant to be thrown by the * resource class. */ -@SuppressWarnings("serial") public class CheckedAllocationException extends Exception { /** * Create a new CheckedAllocationException. diff --git a/hal/src/main/java/edu/wpi/first/hal/util/HalHandleException.java b/hal/src/main/java/edu/wpi/first/hal/util/HalHandleException.java index 65c11f5f41..aee93bb135 100644 --- a/hal/src/main/java/edu/wpi/first/hal/util/HalHandleException.java +++ b/hal/src/main/java/edu/wpi/first/hal/util/HalHandleException.java @@ -5,7 +5,6 @@ package edu.wpi.first.hal.util; /** Exception indicating that an error has occurred with a HAL Handle. */ -@SuppressWarnings("serial") public class HalHandleException extends RuntimeException { /** * Create a new HalHandleException. diff --git a/hal/src/main/java/edu/wpi/first/hal/util/UncleanStatusException.java b/hal/src/main/java/edu/wpi/first/hal/util/UncleanStatusException.java index 90650fce5b..7be73b4f1b 100644 --- a/hal/src/main/java/edu/wpi/first/hal/util/UncleanStatusException.java +++ b/hal/src/main/java/edu/wpi/first/hal/util/UncleanStatusException.java @@ -5,7 +5,6 @@ package edu.wpi.first.hal.util; /** Exception for bad status codes from the chip object. */ -@SuppressWarnings("serial") public final class UncleanStatusException extends IllegalStateException { private final int m_statusCode; diff --git a/shared/java/javacommon.gradle b/shared/java/javacommon.gradle index 084af483aa..0065886fe3 100644 --- a/shared/java/javacommon.gradle +++ b/shared/java/javacommon.gradle @@ -103,7 +103,11 @@ tasks.withType(JavaCompile).configureEach { '-encoding', 'UTF8', "-Werror", - "-Xlint:deprecation,removal", + "-Xlint:all", + // ignore AutoCloseable warnings + "-Xlint:-try", + // ignore missing serialVersionUID warnings + "-Xlint:-serial", ] } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16448_IMU.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16448_IMU.java index 4ac4b4f3e2..cc14a77c97 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16448_IMU.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16448_IMU.java @@ -351,8 +351,7 @@ public class ADIS16448_IMU implements AutoCloseable, NTSendable { /** */ private static int toInt(int... buf) { - return (int) - ((buf[0] & 0xFF) << 24 | (buf[1] & 0xFF) << 16 | (buf[2] & 0xFF) << 8 | (buf[3] & 0xFF)); + return (buf[0] & 0xFF) << 24 | (buf[1] & 0xFF) << 16 | (buf[2] & 0xFF) << 8 | (buf[3] & 0xFF); } /** */ diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16470_IMU.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16470_IMU.java index 8bafa1a237..7741d0118b 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16470_IMU.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADIS16470_IMU.java @@ -392,8 +392,7 @@ public class ADIS16470_IMU implements AutoCloseable, NTSendable { * @return */ private static int toInt(int... buf) { - return (int) - ((buf[0] & 0xFF) << 24 | (buf[1] & 0xFF) << 16 | (buf[2] & 0xFF) << 8 | (buf[3] & 0xFF)); + return (buf[0] & 0xFF) << 24 | (buf[1] & 0xFF) << 16 | (buf[2] & 0xFF) << 8 | (buf[3] & 0xFF); } /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java index d5825c1865..8baa508120 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java @@ -16,7 +16,6 @@ import edu.wpi.first.wpilibj.AnalogTriggerOutput.AnalogTriggerType; /** Class for creating and configuring Analog Triggers. */ public class AnalogTrigger implements Sendable, AutoCloseable { /** Exceptions dealing with improper operation of the Analog trigger. */ - @SuppressWarnings("serial") public static class AnalogTriggerException extends RuntimeException { /** * Create a new exception with the given message. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java index 0f513b4490..f54c0815b8 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTriggerOutput.java @@ -40,7 +40,6 @@ import edu.wpi.first.util.sendable.SendableBuilder; */ public class AnalogTriggerOutput extends DigitalSource implements Sendable { /** Exceptions dealing with improper operation of the Analog trigger output. */ - @SuppressWarnings("serial") public static class AnalogTriggerOutputException extends RuntimeException { /** * Create a new exception with the given message. diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java index 05efebde07..592dbc0225 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Relay.java @@ -31,7 +31,6 @@ public class Relay extends MotorSafety implements Sendable, AutoCloseable { * This class represents errors in trying to set relay values contradictory to the direction to * which the relay is set. */ - @SuppressWarnings("serial") public static class InvalidValueException extends RuntimeException { /** * Create a new exception with the given message. diff --git a/wpimath/src/main/java/edu/wpi/first/math/spline/SplineParameterizer.java b/wpimath/src/main/java/edu/wpi/first/math/spline/SplineParameterizer.java index 88afc6d9ae..02e988feff 100644 --- a/wpimath/src/main/java/edu/wpi/first/math/spline/SplineParameterizer.java +++ b/wpimath/src/main/java/edu/wpi/first/math/spline/SplineParameterizer.java @@ -57,7 +57,6 @@ public final class SplineParameterizer { } } - @SuppressWarnings("serial") public static class MalformedSplineException extends RuntimeException { /** * Create a new exception with the given message. diff --git a/wpimath/src/main/java/edu/wpi/first/math/system/NumericalIntegration.java b/wpimath/src/main/java/edu/wpi/first/math/system/NumericalIntegration.java index 274b10af54..06a781559b 100644 --- a/wpimath/src/main/java/edu/wpi/first/math/system/NumericalIntegration.java +++ b/wpimath/src/main/java/edu/wpi/first/math/system/NumericalIntegration.java @@ -24,7 +24,7 @@ public final class NumericalIntegration { * @param dtSeconds The time over which to integrate. * @return the integration of dx/dt = f(x) for dt. */ - @SuppressWarnings("ParameterName") + @SuppressWarnings({"ParameterName", "overloads"}) public static double rk4(DoubleFunction f, double x, double dtSeconds) { final var h = dtSeconds; final var k1 = f.apply(x); @@ -44,7 +44,7 @@ public final class NumericalIntegration { * @param dtSeconds The time over which to integrate. * @return The result of Runge Kutta integration (4th order). */ - @SuppressWarnings("ParameterName") + @SuppressWarnings({"ParameterName", "overloads"}) public static double rk4( BiFunction f, double x, Double u, double dtSeconds) { final var h = dtSeconds; @@ -68,7 +68,7 @@ public final class NumericalIntegration { * @param dtSeconds The time over which to integrate. * @return the integration of dx/dt = f(x, u) for dt. */ - @SuppressWarnings({"ParameterName", "MethodTypeParameterName"}) + @SuppressWarnings({"ParameterName", "MethodTypeParameterName", "overloads"}) public static Matrix rk4( BiFunction, Matrix, Matrix> f, Matrix x, @@ -93,7 +93,7 @@ public final class NumericalIntegration { * @param dtSeconds The time over which to integrate. * @return 4th order Runge-Kutta integration of dx/dt = f(x) for dt. */ - @SuppressWarnings({"ParameterName", "MethodTypeParameterName"}) + @SuppressWarnings({"ParameterName", "MethodTypeParameterName", "overloads"}) public static Matrix rk4( Function, Matrix> f, Matrix x, double dtSeconds) { final var h = dtSeconds; diff --git a/wpimath/src/main/java/edu/wpi/first/math/trajectory/TrajectoryGenerator.java b/wpimath/src/main/java/edu/wpi/first/math/trajectory/TrajectoryGenerator.java index 0827c15b90..244851df48 100644 --- a/wpimath/src/main/java/edu/wpi/first/math/trajectory/TrajectoryGenerator.java +++ b/wpimath/src/main/java/edu/wpi/first/math/trajectory/TrajectoryGenerator.java @@ -263,7 +263,6 @@ public final class TrajectoryGenerator { } // Work around type erasure signatures - @SuppressWarnings("serial") public static class ControlVectorList extends ArrayList { public ControlVectorList(int initialCapacity) { super(initialCapacity); diff --git a/wpimath/src/main/java/edu/wpi/first/math/trajectory/TrajectoryParameterizer.java b/wpimath/src/main/java/edu/wpi/first/math/trajectory/TrajectoryParameterizer.java index 28c4153211..d96faccfc2 100644 --- a/wpimath/src/main/java/edu/wpi/first/math/trajectory/TrajectoryParameterizer.java +++ b/wpimath/src/main/java/edu/wpi/first/math/trajectory/TrajectoryParameterizer.java @@ -320,7 +320,6 @@ public final class TrajectoryParameterizer { } } - @SuppressWarnings("serial") public static class TrajectoryGenerationException extends RuntimeException { public TrajectoryGenerationException(String message) { super(message); diff --git a/wpiutil/src/main/java/edu/wpi/first/util/datalog/DataLogReader.java b/wpiutil/src/main/java/edu/wpi/first/util/datalog/DataLogReader.java index 15c2db39e3..29b4d6f3e2 100644 --- a/wpiutil/src/main/java/edu/wpi/first/util/datalog/DataLogReader.java +++ b/wpiutil/src/main/java/edu/wpi/first/util/datalog/DataLogReader.java @@ -144,7 +144,7 @@ public class DataLogReader implements Iterable { int size = 0; for (int i = 0; i < sizeLen; i++) { - size |= ((int) (m_buf.get(pos + 1 + entryLen + i) & 0xff)) << (i * 8); + size |= (m_buf.get(pos + 1 + entryLen + i) & 0xff) << (i * 8); } return pos + headerLen + size; }