diff --git a/wpilibOldCommands/src/main/native/include/frc/PIDBase.h b/wpilibOldCommands/src/main/native/include/frc/PIDBase.h index 52048bfed3..f118cc1b21 100644 --- a/wpilibOldCommands/src/main/native/include/frc/PIDBase.h +++ b/wpilibOldCommands/src/main/native/include/frc/PIDBase.h @@ -10,7 +10,6 @@ #include #include -#include "frc/Base.h" #include "frc/LinearFilter.h" #include "frc/PIDInterface.h" #include "frc/PIDOutput.h" diff --git a/wpilibOldCommands/src/main/native/include/frc/PIDController.h b/wpilibOldCommands/src/main/native/include/frc/PIDController.h index 05f881f73d..d852611b0b 100644 --- a/wpilibOldCommands/src/main/native/include/frc/PIDController.h +++ b/wpilibOldCommands/src/main/native/include/frc/PIDController.h @@ -10,7 +10,6 @@ #include #include -#include "frc/Base.h" #include "frc/Controller.h" #include "frc/Notifier.h" #include "frc/PIDBase.h" diff --git a/wpilibOldCommands/src/main/native/include/frc/PIDOutput.h b/wpilibOldCommands/src/main/native/include/frc/PIDOutput.h index 67e72eb517..98c4af4bcc 100644 --- a/wpilibOldCommands/src/main/native/include/frc/PIDOutput.h +++ b/wpilibOldCommands/src/main/native/include/frc/PIDOutput.h @@ -4,8 +4,6 @@ #pragma once -#include "frc/Base.h" - namespace frc { /** diff --git a/wpilibc/src/main/native/cpp/AnalogAccelerometer.cpp b/wpilibc/src/main/native/cpp/AnalogAccelerometer.cpp index 246675dd4b..db291cebb8 100644 --- a/wpilibc/src/main/native/cpp/AnalogAccelerometer.cpp +++ b/wpilibc/src/main/native/cpp/AnalogAccelerometer.cpp @@ -5,8 +5,8 @@ #include "frc/AnalogAccelerometer.h" #include +#include -#include "frc/Base.h" #include "frc/Errors.h" #include "frc/smartdashboard/SendableBuilder.h" #include "frc/smartdashboard/SendableRegistry.h" @@ -19,7 +19,7 @@ AnalogAccelerometer::AnalogAccelerometer(int channel) } AnalogAccelerometer::AnalogAccelerometer(AnalogInput* channel) - : m_analogInput(channel, NullDeleter()) { + : m_analogInput(channel, wpi::NullDeleter()) { if (!channel) { throw FRC_MakeError(err::NullParameter, "{}", "channel"); } diff --git a/wpilibc/src/main/native/cpp/AnalogEncoder.cpp b/wpilibc/src/main/native/cpp/AnalogEncoder.cpp index f1b5db14af..77552c9b06 100644 --- a/wpilibc/src/main/native/cpp/AnalogEncoder.cpp +++ b/wpilibc/src/main/native/cpp/AnalogEncoder.cpp @@ -4,8 +4,9 @@ #include "frc/AnalogEncoder.h" +#include + #include "frc/AnalogInput.h" -#include "frc/Base.h" #include "frc/Counter.h" #include "frc/Errors.h" #include "frc/smartdashboard/SendableBuilder.h" @@ -16,14 +17,14 @@ AnalogEncoder::AnalogEncoder(int channel) : AnalogEncoder(std::make_shared(channel)) {} AnalogEncoder::AnalogEncoder(AnalogInput& analogInput) - : m_analogInput{&analogInput, NullDeleter{}}, + : m_analogInput{&analogInput, wpi::NullDeleter{}}, m_analogTrigger{m_analogInput.get()}, m_counter{} { Init(); } AnalogEncoder::AnalogEncoder(AnalogInput* analogInput) - : m_analogInput{analogInput, NullDeleter{}}, + : m_analogInput{analogInput, wpi::NullDeleter{}}, m_analogTrigger{m_analogInput.get()}, m_counter{} { Init(); diff --git a/wpilibc/src/main/native/cpp/AnalogGyro.cpp b/wpilibc/src/main/native/cpp/AnalogGyro.cpp index fc3bdf5ef1..eaf8c52dde 100644 --- a/wpilibc/src/main/native/cpp/AnalogGyro.cpp +++ b/wpilibc/src/main/native/cpp/AnalogGyro.cpp @@ -10,10 +10,10 @@ #include #include #include +#include #include #include "frc/AnalogInput.h" -#include "frc/Base.h" #include "frc/Errors.h" #include "frc/Timer.h" #include "frc/smartdashboard/SendableBuilder.h" @@ -27,8 +27,8 @@ AnalogGyro::AnalogGyro(int channel) } AnalogGyro::AnalogGyro(AnalogInput* channel) - : AnalogGyro( - std::shared_ptr(channel, NullDeleter())) {} + : AnalogGyro(std::shared_ptr( + channel, wpi::NullDeleter())) {} AnalogGyro::AnalogGyro(std::shared_ptr channel) : m_analog(channel) { diff --git a/wpilibc/src/main/native/cpp/AnalogPotentiometer.cpp b/wpilibc/src/main/native/cpp/AnalogPotentiometer.cpp index 8237658dbc..2863adca64 100644 --- a/wpilibc/src/main/native/cpp/AnalogPotentiometer.cpp +++ b/wpilibc/src/main/native/cpp/AnalogPotentiometer.cpp @@ -6,7 +6,8 @@ #include -#include "frc/Base.h" +#include + #include "frc/RobotController.h" #include "frc/smartdashboard/SendableBuilder.h" #include "frc/smartdashboard/SendableRegistry.h" @@ -23,7 +24,7 @@ AnalogPotentiometer::AnalogPotentiometer(int channel, double fullRange, AnalogPotentiometer::AnalogPotentiometer(AnalogInput* input, double fullRange, double offset) : AnalogPotentiometer( - std::shared_ptr(input, NullDeleter()), + std::shared_ptr(input, wpi::NullDeleter()), fullRange, offset) {} AnalogPotentiometer::AnalogPotentiometer(std::shared_ptr input, diff --git a/wpilibc/src/main/native/cpp/AnalogTrigger.cpp b/wpilibc/src/main/native/cpp/AnalogTrigger.cpp index 309dfba62c..2311eea6cc 100644 --- a/wpilibc/src/main/native/cpp/AnalogTrigger.cpp +++ b/wpilibc/src/main/native/cpp/AnalogTrigger.cpp @@ -7,9 +7,9 @@ #include #include +#include #include "frc/AnalogInput.h" -#include "frc/Base.h" #include "frc/DutyCycle.h" #include "frc/Errors.h" #include "frc/smartdashboard/SendableRegistry.h" @@ -108,7 +108,8 @@ bool AnalogTrigger::GetTriggerState() { std::shared_ptr AnalogTrigger::CreateOutput( AnalogTriggerType type) const { return std::shared_ptr( - new AnalogTriggerOutput(*this, type), NullDeleter()); + new AnalogTriggerOutput(*this, type), + wpi::NullDeleter()); } void AnalogTrigger::InitSendable(SendableBuilder& builder) { diff --git a/wpilibc/src/main/native/cpp/Counter.cpp b/wpilibc/src/main/native/cpp/Counter.cpp index 0c50787af3..210cf8fb25 100644 --- a/wpilibc/src/main/native/cpp/Counter.cpp +++ b/wpilibc/src/main/native/cpp/Counter.cpp @@ -8,9 +8,9 @@ #include #include +#include #include "frc/AnalogTrigger.h" -#include "frc/Base.h" #include "frc/DigitalInput.h" #include "frc/Errors.h" #include "frc/smartdashboard/SendableBuilder.h" @@ -54,9 +54,9 @@ Counter::Counter(EncodingType encodingType, DigitalSource* upSource, DigitalSource* downSource, bool inverted) : Counter(encodingType, std::shared_ptr(upSource, - NullDeleter()), + wpi::NullDeleter()), std::shared_ptr(downSource, - NullDeleter()), + wpi::NullDeleter()), inverted) {} Counter::Counter(EncodingType encodingType, @@ -103,7 +103,7 @@ void Counter::SetUpSource(int channel) { void Counter::SetUpSource(AnalogTrigger* analogTrigger, AnalogTriggerType triggerType) { SetUpSource(std::shared_ptr(analogTrigger, - NullDeleter()), + wpi::NullDeleter()), triggerType); } @@ -113,8 +113,8 @@ void Counter::SetUpSource(std::shared_ptr analogTrigger, } void Counter::SetUpSource(DigitalSource* source) { - SetUpSource( - std::shared_ptr(source, NullDeleter())); + SetUpSource(std::shared_ptr( + source, wpi::NullDeleter())); } void Counter::SetUpSource(std::shared_ptr source) { @@ -128,8 +128,8 @@ void Counter::SetUpSource(std::shared_ptr source) { } void Counter::SetUpSource(DigitalSource& source) { - SetUpSource( - std::shared_ptr(&source, NullDeleter())); + SetUpSource(std::shared_ptr( + &source, wpi::NullDeleter())); } void Counter::SetUpSourceEdge(bool risingEdge, bool fallingEdge) { @@ -157,8 +157,8 @@ void Counter::SetDownSource(int channel) { void Counter::SetDownSource(AnalogTrigger* analogTrigger, AnalogTriggerType triggerType) { - SetDownSource(std::shared_ptr(analogTrigger, - NullDeleter()), + SetDownSource(std::shared_ptr( + analogTrigger, wpi::NullDeleter()), triggerType); } @@ -168,13 +168,13 @@ void Counter::SetDownSource(std::shared_ptr analogTrigger, } void Counter::SetDownSource(DigitalSource* source) { - SetDownSource( - std::shared_ptr(source, NullDeleter())); + SetDownSource(std::shared_ptr( + source, wpi::NullDeleter())); } void Counter::SetDownSource(DigitalSource& source) { - SetDownSource( - std::shared_ptr(&source, NullDeleter())); + SetDownSource(std::shared_ptr( + &source, wpi::NullDeleter())); } void Counter::SetDownSource(std::shared_ptr source) { diff --git a/wpilibc/src/main/native/cpp/DutyCycle.cpp b/wpilibc/src/main/native/cpp/DutyCycle.cpp index 045bd0243a..022b6864ba 100644 --- a/wpilibc/src/main/native/cpp/DutyCycle.cpp +++ b/wpilibc/src/main/native/cpp/DutyCycle.cpp @@ -6,8 +6,8 @@ #include #include +#include -#include "frc/Base.h" #include "frc/DigitalSource.h" #include "frc/Errors.h" #include "frc/smartdashboard/SendableBuilder.h" @@ -15,7 +15,7 @@ using namespace frc; DutyCycle::DutyCycle(DigitalSource* source) - : m_source{source, NullDeleter()} { + : m_source{source, wpi::NullDeleter()} { if (!m_source) { throw FRC_MakeError(err::NullParameter, "{}", "source"); } @@ -23,7 +23,7 @@ DutyCycle::DutyCycle(DigitalSource* source) } DutyCycle::DutyCycle(DigitalSource& source) - : m_source{&source, NullDeleter()} { + : m_source{&source, wpi::NullDeleter()} { InitDutyCycle(); } diff --git a/wpilibc/src/main/native/cpp/DutyCycleEncoder.cpp b/wpilibc/src/main/native/cpp/DutyCycleEncoder.cpp index 49b3cc79a0..dac3fbf137 100644 --- a/wpilibc/src/main/native/cpp/DutyCycleEncoder.cpp +++ b/wpilibc/src/main/native/cpp/DutyCycleEncoder.cpp @@ -4,7 +4,8 @@ #include "frc/DutyCycleEncoder.h" -#include "frc/Base.h" +#include + #include "frc/Counter.h" #include "frc/DigitalInput.h" #include "frc/DigitalSource.h" @@ -21,12 +22,12 @@ DutyCycleEncoder::DutyCycleEncoder(int channel) } DutyCycleEncoder::DutyCycleEncoder(DutyCycle& dutyCycle) - : m_dutyCycle{&dutyCycle, NullDeleter{}} { + : m_dutyCycle{&dutyCycle, wpi::NullDeleter{}} { Init(); } DutyCycleEncoder::DutyCycleEncoder(DutyCycle* dutyCycle) - : m_dutyCycle{dutyCycle, NullDeleter{}} { + : m_dutyCycle{dutyCycle, wpi::NullDeleter{}} { Init(); } diff --git a/wpilibc/src/main/native/cpp/Encoder.cpp b/wpilibc/src/main/native/cpp/Encoder.cpp index 0ede129505..975056b636 100644 --- a/wpilibc/src/main/native/cpp/Encoder.cpp +++ b/wpilibc/src/main/native/cpp/Encoder.cpp @@ -8,8 +8,8 @@ #include #include +#include -#include "frc/Base.h" #include "frc/DigitalInput.h" #include "frc/Errors.h" #include "frc/smartdashboard/SendableBuilder.h" @@ -29,8 +29,8 @@ Encoder::Encoder(int aChannel, int bChannel, bool reverseDirection, Encoder::Encoder(DigitalSource* aSource, DigitalSource* bSource, bool reverseDirection, EncodingType encodingType) - : m_aSource(aSource, NullDeleter()), - m_bSource(bSource, NullDeleter()) { + : m_aSource(aSource, wpi::NullDeleter()), + m_bSource(bSource, wpi::NullDeleter()) { if (!m_aSource) { throw FRC_MakeError(err::NullParameter, "{}", "aSource"); } @@ -42,8 +42,8 @@ Encoder::Encoder(DigitalSource* aSource, DigitalSource* bSource, Encoder::Encoder(DigitalSource& aSource, DigitalSource& bSource, bool reverseDirection, EncodingType encodingType) - : m_aSource(&aSource, NullDeleter()), - m_bSource(&bSource, NullDeleter()) { + : m_aSource(&aSource, wpi::NullDeleter()), + m_bSource(&bSource, wpi::NullDeleter()) { InitEncoder(reverseDirection, encodingType); } diff --git a/wpilibc/src/main/native/cpp/Ultrasonic.cpp b/wpilibc/src/main/native/cpp/Ultrasonic.cpp index e484f46147..9f8e9292a3 100644 --- a/wpilibc/src/main/native/cpp/Ultrasonic.cpp +++ b/wpilibc/src/main/native/cpp/Ultrasonic.cpp @@ -7,8 +7,8 @@ #include #include +#include -#include "frc/Base.h" #include "frc/Counter.h" #include "frc/DigitalInput.h" #include "frc/DigitalOutput.h" @@ -36,8 +36,8 @@ Ultrasonic::Ultrasonic(int pingChannel, int echoChannel) } Ultrasonic::Ultrasonic(DigitalOutput* pingChannel, DigitalInput* echoChannel) - : m_pingChannel(pingChannel, NullDeleter()), - m_echoChannel(echoChannel, NullDeleter()), + : m_pingChannel(pingChannel, wpi::NullDeleter()), + m_echoChannel(echoChannel, wpi::NullDeleter()), m_counter(m_echoChannel) { if (!pingChannel) { throw FRC_MakeError(err::NullParameter, "{}", "pingChannel"); @@ -49,8 +49,8 @@ Ultrasonic::Ultrasonic(DigitalOutput* pingChannel, DigitalInput* echoChannel) } Ultrasonic::Ultrasonic(DigitalOutput& pingChannel, DigitalInput& echoChannel) - : m_pingChannel(&pingChannel, NullDeleter()), - m_echoChannel(&echoChannel, NullDeleter()), + : m_pingChannel(&pingChannel, wpi::NullDeleter()), + m_echoChannel(&echoChannel, wpi::NullDeleter()), m_counter(m_echoChannel) { Initialize(); } diff --git a/wpilibc/src/main/native/cpp/drive/RobotDriveBase.cpp b/wpilibc/src/main/native/cpp/drive/RobotDriveBase.cpp index 3b03c3a75a..005eb08b7d 100644 --- a/wpilibc/src/main/native/cpp/drive/RobotDriveBase.cpp +++ b/wpilibc/src/main/native/cpp/drive/RobotDriveBase.cpp @@ -10,7 +10,6 @@ #include -#include "frc/Base.h" #include "frc/motorcontrol/MotorController.h" using namespace frc; diff --git a/wpilibc/src/main/native/include/frc/RobotBase.h b/wpilibc/src/main/native/include/frc/RobotBase.h index b314e9f677..e0c1592fef 100644 --- a/wpilibc/src/main/native/include/frc/RobotBase.h +++ b/wpilibc/src/main/native/include/frc/RobotBase.h @@ -13,7 +13,6 @@ #include #include -#include "frc/Base.h" #include "frc/Errors.h" namespace frc { diff --git a/wpilibc/src/main/native/include/frc/Base.h b/wpiutil/src/main/native/include/wpi/NullDeleter.h similarity index 86% rename from wpilibc/src/main/native/include/frc/Base.h rename to wpiutil/src/main/native/include/wpi/NullDeleter.h index 686e7459e0..26146e5ea6 100644 --- a/wpilibc/src/main/native/include/frc/Base.h +++ b/wpiutil/src/main/native/include/wpi/NullDeleter.h @@ -4,8 +4,7 @@ #pragma once -/** WPILib FRC namespace */ -namespace frc { +namespace wpi { // A struct to use as a deleter when a std::shared_ptr must wrap a raw pointer // that is being deleted by someone else. @@ -14,4 +13,4 @@ struct NullDeleter { void operator()(T*) const noexcept {}; }; -} // namespace frc +} // namespace wpi