Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-30 02:31:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Finish clang-tidy cleanups (#3003)

Browse Source 
* Add .clang-tidy configuration.
* A separate .clang-tidy is used for hal includes to suppress modernize-use-using
  (as these are C headers).
* Add NOLINT where necessary for a clean run.
* Add clang-tidy job to lint-format workflow.  This workflow is now only run on PRs.
  To reduce runtime, clang-tidy is only run on files changed in the PR.

Two wpilibc changes; both are unlikely to break user code:
* BuiltInAccelerometer: Make SetRange() final
* Counter: Make SetMaxPeriod() final

After these cleanups, the only file that does not run cleanly is
cscore_raw_cv.h due to it not being standalone.
This commit is contained in:
Peter Johnson
2021-01-01 10:27:49 -08:00
committed by GitHub
parent d741101fe3
commit f5e0fc3e9a
49 changed files with 314 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
simulation/halsim_ws_core/src/main/native/include/WSHalProviders.h
View File

@@ -16,11 +16,11 @@
namespace wpilibws {
typedef void (*HALCbRegisterIndexedFunc)(int32_t index,
HAL_NotifyCallback callback,
using HALCbRegisterIndexedFunc = void (*)(int32_t index,
HAL_NotifyCallback callback,
void* param, HAL_Bool initialNotify);
using HALCbRegisterSingleFunc = void (*)(HAL_NotifyCallback callback,
void* param, HAL_Bool initialNotify);
typedef void (*HALCbRegisterSingleFunc)(HAL_NotifyCallback callback,
void* param, HAL_Bool initialNotify);
// provider generates diffs based on values
class HALSimWSHalProvider : public HALSimWSBaseProvider {

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_AddressableLED.h
View File

@@ -12,7 +12,7 @@ class HALSimWSProviderAddressableLED : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderAddressableLED();
~HALSimWSProviderAddressableLED() override;
protected:
void RegisterCallbacks() override;

4
simulation/halsim_ws_core/src/main/native/include/WSProvider_Analog.h
View File

@@ -21,7 +21,7 @@ class HALSimWSProviderAnalogIn : public HALSimWSHalChanProvider {
protected:
void RegisterCallbacks() override;
void CancelCallbacks() override;
void CancelCallbacks() final;
void DoCancelCallbacks();
private:
@@ -45,7 +45,7 @@ class HALSimWSProviderAnalogOut : public HALSimWSHalChanProvider {
protected:
void RegisterCallbacks() override;
void CancelCallbacks() override;
void CancelCallbacks() final;
void DoCancelCallbacks();
private:

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_PCM.h
View File

@@ -14,7 +14,7 @@ class HALSimWSProviderPCM : public HALSimWSHalChanProvider {
static void Initialize(WSRegisterFunc webRegisterFunc);
using HALSimWSHalChanProvider::HALSimWSHalChanProvider;
~HALSimWSProviderPCM();
~HALSimWSProviderPCM() override;
protected:
void RegisterCallbacks() override;

2
simulation/halsim_ws_core/src/main/native/include/WSProvider_Solenoid.h
View File

@@ -16,7 +16,7 @@ class HALSimWSProviderSolenoid : public HALSimWSHalProvider {
explicit HALSimWSProviderSolenoid(int32_t pcmChannel, int32_t solenoidChannel,
const std::string& key,
const std::string& type);
~HALSimWSProviderSolenoid();
~HALSimWSProviderSolenoid() override;
protected:
void RegisterCallbacks() override;