Update LiveWindow to provide continuous telemetry. (#771)

LiveWindow.updateValues() is now called from IterativeRobotBase on every
loop iteration.  Telemetry for all WPILib classes is enabled by default;
it can be disabled for specific classes using LiveWindow.disableTelemetry(),
or all telemetry can be disabled using LiveWindow.disableAllTelemetry().

This necessitated changing the hook methodology into other classes to
be more property-based rather than each class providing multiple functions.
This had the benefit of reducing boilerplate and increasing consistency.

- Remove NamedSendable, add name to Sendable.

- Provide SendableBase abstract class.

- Deprecate LiveWindow addSensor/addActuator interfaces.

- Add LiveWindow support to drive classes.

- Add addChild() helper functions to Subsystem.

- Fix inheritance hierarchy.  Now only sensors inherit from SensorBase.
  Other devices inherit from some combination of SendableBase, ErrorBase, or
  nothing.
This commit is contained in:
Peter Johnson
2017-12-04 23:28:33 -08:00
committed by GitHub
parent 3befc7015b
commit f9bece2ffb
213 changed files with 3704 additions and 3758 deletions

View File

@@ -8,15 +8,13 @@
#pragma once
#include <memory>
#include <string>
#include <HAL/Types.h>
#include <llvm/raw_ostream.h>
#include "LiveWindow/LiveWindowSendable.h"
#include "ErrorBase.h"
#include "MotorSafety.h"
#include "SensorBase.h"
#include "networktables/NetworkTableEntry.h"
#include "SmartDashboard/SendableBase.h"
namespace frc {
@@ -34,13 +32,13 @@ class MotorSafetyHelper;
* independently for something that does not care about voltage polarity (like
* a solenoid).
*/
class Relay : public MotorSafety, public SensorBase, public LiveWindowSendable {
class Relay : public MotorSafety, public ErrorBase, public SendableBase {
public:
enum Value { kOff, kOn, kForward, kReverse };
enum Direction { kBothDirections, kForwardOnly, kReverseOnly };
explicit Relay(int channel, Direction direction = kBothDirections);
virtual ~Relay();
~Relay() override;
void Set(Value value);
Value Get() const;
@@ -54,15 +52,7 @@ class Relay : public MotorSafety, public SensorBase, public LiveWindowSendable {
void SetSafetyEnabled(bool enabled) override;
void GetDescription(llvm::raw_ostream& desc) const override;
void UpdateTable() override;
void StartLiveWindowMode() override;
void StopLiveWindowMode() override;
std::string GetSmartDashboardType() const override;
void InitTable(std::shared_ptr<nt::NetworkTable> subTable) override;
protected:
nt::NetworkTableEntry m_valueEntry;
NT_EntryListener m_valueListener = 0;
void InitSendable(SendableBuilder& builder) override;
private:
int m_channel;