Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove percent tolerance from PID controller

Browse Source 
It breaks the unit system badly; the tolerance member variable has
different units depending on percent vs absolute. Absolute tolerance is
a lot more natural than percent tolerance anyway.
This commit is contained in:
Tyler Veness
2019-08-25 13:01:51 -07:00
committed by Peter Johnson
parent 0ca8d667d2
commit ff8b8f0a8a
29 changed files with 121 additions and 507 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PIDTest.java
View File

@@ -117,8 +117,8 @@ public class PIDTest extends AbstractComsSetup {
me.reset();
}
private void setupAbsoluteTolerance() {
m_controller.setAbsoluteTolerance(absoluteTolerance);
private void setupTolerance() {
m_controller.setTolerance(absoluteTolerance);
}
private void setupOutputRange() {
@@ -127,7 +127,7 @@ public class PIDTest extends AbstractComsSetup {
@Test
public void testInitialSettings() {
setupAbsoluteTolerance();
setupTolerance();
setupOutputRange();
double reference = 2500.0;
m_controller.setSetpoint(reference);
@@ -143,7 +143,7 @@ public class PIDTest extends AbstractComsSetup {
@Test
public void testSetSetpoint() {
setupAbsoluteTolerance();
setupTolerance();
setupOutputRange();
double reference = 2500.0;
m_controller.setSetpoint(reference);
@@ -152,7 +152,7 @@ public class PIDTest extends AbstractComsSetup {
@Test(timeout = 10000)
public void testRotateToTarget() {
setupAbsoluteTolerance();
setupTolerance();
setupOutputRange();
double reference = 1000.0;
assertEquals(pidData() + "did not start at 0", 0, me.getMotor().get(), 0);