allwpilib

Team2890/allwpilib

Fork 0

mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00

Commit Graph

Author	SHA1	Message	Date
Peter Johnson	b9b31069cc	Fix C++ POVButton (#2294 ) Also add unit test.	2020-01-20 21:35:19 -08:00
Oblarg	cba21a768f	Fix C++ JoystickButton and POVButton (#2259 ) C++ JoystickButton and POVButton were both nonfunctional due to slicing when trigger passes itself by value to the button scheduler it creates. Fix is to remove the virtual Get() method entirely and use only the m_isActive functor; since the subclass now passes the button condition back as a functor to the base class, in which it's stored as a member, it will now still work after being sliced.	2020-01-12 14:57:28 -08:00
Thad House	509819d83f	Split the two command implementations into separate libraries (#2012 ) This will allow us at the user code side to determine to include old commands, new commands or both.	2019-11-01 21:58:54 -07:00

Author

SHA1

Message

Date

Peter Johnson

b9b31069cc

Fix C++ POVButton (#2294 )

Also add unit test.

2020-01-20 21:35:19 -08:00

Oblarg

cba21a768f

Fix C++ JoystickButton and POVButton (#2259 )

C++ JoystickButton and POVButton were both nonfunctional due to slicing when trigger passes itself by value to the button scheduler it creates.

Fix is to remove the virtual Get() method entirely and use only the m_isActive functor; since the subclass now passes the button condition back as a functor to the base class, in which it's stored as a member, it will now still work after being sliced.

2020-01-12 14:57:28 -08:00

Thad House

509819d83f

Split the two command implementations into separate libraries (#2012 )

This will allow us at the user code side to determine to include old commands, new commands or both.

2019-11-01 21:58:54 -07:00

3 Commits