7 Commits

Author	SHA1	Message	Date
Peter Johnson	b78f115fcf	Work around VS2019 16.4.0 bugs (#2171) ... Work around frontend bug in scoped_lock and code generation bug in reverse_iterator in gtest. See https://github.com/google/googletest/pull/2635	2019-12-14 10:48:19 -08:00
Tyler Veness	62be0392b6	Replace std::lock_guard and std::lock with std::scoped_lock (#1758) ... std::scoped_lock was introduced in C++17 and is strictly better than std::lock_guard as it supports locking any number of mutexes safely. It's also easier to use than std::lock for locking multiple mutexes at once.	2019-07-08 22:58:39 -07:00
Tyler Veness	841ef5d739	Remove template types from lock RAII wrapper usages (#1756) ... C++17 has template type autodeduction. These wrappers include std::lock_guard and std::unique_lock.	2019-07-07 19:17:14 -07:00
Peter Johnson	0abae17653	cscore: Refactor sink and source creation ... Also make sources and sinks members of Instance private, with appropriate accessor functions.	2018-11-09 23:33:55 -08:00
Peter Johnson	e27d6d7bb8	cscore: Change impl to only one singleton (#1398) ... This avoids a number of shutdown use-after-free races by controlling the destruction order. It also is a prerequisite to making the internal interfaces mockable for unit testing.	2018-10-31 20:22:58 -07:00
Peter Johnson	f84018af5f	Move entirety of llvm namespace to wpi namespace. ... During shared library loading, a different libLLVM can be pulled in, causing llvm symbols from dependent libraries to resolve to that library instead of this one. This has been seen in the wild with the Mesa OpenGL implementation in JavaFX applications (see wpilibsuite/shuffleboard#361). This is clearly a very breaking change. For some level of backwards compatibility, a namespace alias from llvm to wpi is performed in the "llvm" headers. Unfortunately, forward declarations of llvm classes will still break, but compilers seem to generate clear error messages in those cases ("namespace alias 'llvm' not allowed here, assuming 'wpi'"). This change also moves all the wpiutil headers to a single "wpi" subdirectory from the previously split "llvm", "support", "tcpsockets", and "udpsockets". Shim headers will be added for backwards compatibility in a later commit.	2018-04-30 10:22:54 -07:00
Peter Johnson	ea73c10cd8	Prepare cscore for merge into allwpilib.	2018-04-27 19:43:49 -07:00