sciencewhiz
d20594db0d
Fix typos ( #4839 )
2022-12-21 08:53:00 -06:00
Tyler Veness
a791470de7
Clean up Java warning suppressions ( #4433 )
...
Checkstyle naming conventions were changed to allow most of what's in
wpimath. Naming rules were disabled completely in wpimath since almost
all suppressions are for math notation.
2022-09-24 00:13:55 -07:00
Tyler Veness
7269a170fb
Upgrade maven deps to latest versions and fix new linter errors ( #3772 )
...
This also makes the Gradle build work with JDK 17.
The extra JVM args in gradle.properties works around a bug with spotless
and JDK 17: https://github.com/diffplug/spotless/issues/834
PMD.CloseResource was ignored because it's almost always a false
positive, and there are many of them.
2021-12-09 12:20:08 -08:00
Tyler Veness
95dd20a151
[build] Enable spotbugs ( #3601 )
...
Benign spotbugs warnings were suppressed, and all others were fixed. Bug
descriptions are documented here:
https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html
Co-authored-by: Austin Shalit <austinshalit@gmail.com >
2021-09-24 16:04:02 -07:00
Austin Shalit
65b2359b27
[build] Add spotless for other files ( #3007 )
...
Adds spotless formatting for Gradle, xml, md, and gitignore files.
yml linting is not performed as it requires a dependency on npm.
2020-12-30 16:17:20 -08:00
Peter Johnson
a751fa22d2
[build] Apply spotless for java formatting ( #1768 )
...
Update checkstyle config to be compatible with spotless.
Co-authored-by: Austin Shalit <austinshalit@gmail.com >
2020-12-29 22:45:16 -08:00
Austin Shalit
6e1919414e
[build] Bring naming checkstyle rules up to date with Google Style guide ( #1781 )
...
Also update Checkstyle to 8.38.
Google changed their style guide from the last time we imported it. This PR brings in those naming changes. The change they made is allowing single letter member, parameter, and local variable names. They also added a lambda naming scheme and I thought it would be good to bring that in too.
2020-12-29 09:27:48 -08:00
Thad House
3cbec411c7
[build] Add package declaration check to checkstyle ( #2446 )
...
Co-authored-by: Austin Shalit <austinshalit@gmail.com >
2020-06-26 11:10:34 -07:00
Austin Shalit
4ebae17123
Enforce leading/trailing zeros in Java numeric constants ( #2105 )
...
Enforce that integer literals must not have leading zeros and that floating point literals must have leading or trailing zeros in Java.
2019-11-20 20:13:15 -08:00
Thad House
e716c36b89
Fix Nat.java generation to be incremental ( #1831 )
...
Also generate the imports.
2019-08-20 21:03:44 -07:00
Thad House
b9fa3a4398
Update to 2019 RoboRIO and 2019 v4 image ( #1352 )
...
Also make updates for Java 11:
* Disable errorprone plugin (currently broken on Java 11)
* Update checkstyle to 8.12
* Update pmd to 6.7.0
2018-10-07 18:11:57 -07:00
Austin Shalit
40cc743cc7
Enable checkstyle on cscore, ntcore, wpiutil ( #1032 )
...
Also update to version 8.10.
2018-05-24 00:31:04 -04:00
Tyler Veness
d8c8643b52
Format HTML and XML files ( #944 )
...
Generated by wpilibsuite/styleguide#52 .
2018-05-15 23:58:20 -07:00
Austin Shalit
2fc60680f4
Remove RedundantModifiers ( #578 )
2017-10-17 21:47:55 -07:00
Austin Shalit
ddd5aeba19
Checkstyle 8.1 ( #584 )
...
Added a few checks too:
- SimplifyBooleanExpression
- SimplifyBooleanReturn
- StringLiteralEquality
- UnnecessaryParentheses
2017-07-28 22:24:05 -07:00
Austin Shalit
7187e005d4
Add Checkstyle WhitespaceAfter check ( #466 )
2017-05-06 23:22:16 -07:00
Austin Shalit
c30057e923
Remove unused imports ( #387 )
2016-12-05 21:36:52 -08:00
Jonathan Leitschuh
a834fff7b2
Applies Google Styleguide to Java parts of the library ( #23 )
...
This was partially applied to simulation but
simulation is a bit of a mess and has a lot of duplicated code.
2016-05-20 09:07:40 -07:00
