From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: PJ Reiniger Date: Sat, 7 May 2022 22:09:18 -0400 Subject: [PATCH 01/35] Remove StringRef, ArrayRef, and Optional --- llvm/include/llvm/ADT/PointerUnion.h | 1 - llvm/include/llvm/ADT/SmallString.h | 101 ++++++++++-------- llvm/include/llvm/ADT/SmallVector.h | 7 +- llvm/include/llvm/Support/Chrono.h | 10 +- llvm/include/llvm/Support/Compiler.h | 2 +- llvm/include/llvm/Support/ConvertUTF.h | 31 +++--- llvm/include/llvm/Support/ErrorHandling.h | 9 +- llvm/include/llvm/Support/VersionTuple.h | 6 -- .../llvm/Support/Windows/WindowsSupport.h | 4 +- llvm/include/llvm/Support/raw_ostream.h | 46 ++++---- llvm/lib/Support/ConvertUTFWrapper.cpp | 39 +++---- llvm/lib/Support/ErrorHandling.cpp | 13 ++- llvm/lib/Support/SmallVector.cpp | 5 +- llvm/lib/Support/raw_ostream.cpp | 25 +++-- llvm/unittests/ADT/DenseMapTest.cpp | 29 +---- llvm/unittests/ADT/FunctionExtrasTest.cpp | 12 +-- llvm/unittests/ADT/SmallPtrSetTest.cpp | 1 - llvm/unittests/ADT/SmallStringTest.cpp | 50 ++++----- llvm/unittests/ADT/SmallVectorTest.cpp | 30 ++---- llvm/unittests/Support/ConvertUTFTest.cpp | 42 ++++---- 20 files changed, 211 insertions(+), 252 deletions(-) diff --git a/llvm/include/llvm/ADT/PointerUnion.h b/llvm/include/llvm/ADT/PointerUnion.h index cdbd76d7f505be277c3886cc821fb60336cbec59..23394db93cfed492bb1747eb9c8c55ed9230120d 100644 --- a/llvm/include/llvm/ADT/PointerUnion.h +++ b/llvm/include/llvm/ADT/PointerUnion.h @@ -17,7 +17,6 @@ #include "llvm/ADT/DenseMapInfo.h" #include "llvm/ADT/PointerIntPair.h" -#include "llvm/ADT/STLExtras.h" #include "llvm/Support/Casting.h" #include "llvm/Support/PointerLikeTypeTraits.h" #include diff --git a/llvm/include/llvm/ADT/SmallString.h b/llvm/include/llvm/ADT/SmallString.h index be3193c6ef9beba622f39e3e76cd0f0c6dd422b0..9fab1a7726bc6745296f5ebb24aee4055408e5f5 100644 --- a/llvm/include/llvm/ADT/SmallString.h +++ b/llvm/include/llvm/ADT/SmallString.h @@ -15,8 +15,9 @@ #define LLVM_ADT_SMALLSTRING_H #include "llvm/ADT/SmallVector.h" -#include "llvm/ADT/StringRef.h" #include +#include +#include namespace llvm { @@ -28,11 +29,11 @@ public: /// Default ctor - Initialize to empty. SmallString() = default; - /// Initialize from a StringRef. - SmallString(StringRef S) : SmallVector(S.begin(), S.end()) {} + /// Initialize from a std::string_view. + SmallString(std::string_view S) : SmallVector(S.begin(), S.end()) {} - /// Initialize by concatenating a list of StringRefs. - SmallString(std::initializer_list Refs) + /// Initialize by concatenating a list of std::string_views. + SmallString(std::initializer_list Refs) : SmallVector() { this->append(Refs); } @@ -47,13 +48,13 @@ public: using SmallVector::assign; - /// Assign from a StringRef. - void assign(StringRef RHS) { + /// Assign from a std::string_view. + void assign(std::string_view RHS) { SmallVectorImpl::assign(RHS.begin(), RHS.end()); } - /// Assign from a list of StringRefs. - void assign(std::initializer_list Refs) { + /// Assign from a list of std::string_views. + void assign(std::initializer_list Refs) { this->clear(); append(Refs); } @@ -64,19 +65,19 @@ public: using SmallVector::append; - /// Append from a StringRef. - void append(StringRef RHS) { + /// Append from a std::string_view. + void append(std::string_view RHS) { SmallVectorImpl::append(RHS.begin(), RHS.end()); } - /// Append from a list of StringRefs. - void append(std::initializer_list Refs) { + /// Append from a list of std::string_views. + void append(std::initializer_list Refs) { size_t CurrentSize = this->size(); size_t SizeNeeded = CurrentSize; - for (const StringRef &Ref : Refs) + for (const std::string_view &Ref : Refs) SizeNeeded += Ref.size(); this->resize_for_overwrite(SizeNeeded); - for (const StringRef &Ref : Refs) { + for (const std::string_view &Ref : Refs) { std::copy(Ref.begin(), Ref.end(), this->begin() + CurrentSize); CurrentSize += Ref.size(); } @@ -89,26 +90,28 @@ public: /// Check for string equality. This is more efficient than compare() when /// the relative ordering of inequal strings isn't needed. - [[nodiscard]] bool equals(StringRef RHS) const { return str() == RHS; } + [[nodiscard]] bool equals(std::string_view RHS) const { return str() == RHS; } /// Check for string equality, ignoring case. - [[nodiscard]] bool equals_insensitive(StringRef RHS) const { + [[nodiscard]] bool equals_insensitive(std::string_view RHS) const { return str().equals_insensitive(RHS); } /// compare - Compare two strings; the result is negative, zero, or positive /// if this string is lexicographically less than, equal to, or greater than /// the \p RHS. - [[nodiscard]] int compare(StringRef RHS) const { return str().compare(RHS); } + [[nodiscard]] int compare(std::string_view RHS) const { + return str().compare(RHS); + } /// compare_insensitive - Compare two strings, ignoring case. - [[nodiscard]] int compare_insensitive(StringRef RHS) const { + [[nodiscard]] int compare_insensitive(std::string_view RHS) const { return str().compare_insensitive(RHS); } /// compare_numeric - Compare two strings, treating sequences of digits as /// numbers. - [[nodiscard]] int compare_numeric(StringRef RHS) const { + [[nodiscard]] int compare_numeric(std::string_view RHS) const { return str().compare_numeric(RHS); } @@ -116,14 +119,14 @@ public: /// @name String Predicates /// @{ - /// starts_with - Check if this string starts with the given \p Prefix. - [[nodiscard]] bool starts_with(StringRef Prefix) const { - return str().starts_with(Prefix); + /// startswith - Check if this string starts with the given \p Prefix. + [[nodiscard]] bool startswith(std::string_view Prefix) const { + return str().startswith(Prefix); } - /// ends_with - Check if this string ends with the given \p Suffix. - [[nodiscard]] bool ends_with(StringRef Suffix) const { - return str().ends_with(Suffix); + /// endswith - Check if this string ends with the given \p Suffix. + [[nodiscard]] bool endswith(std::string_view Suffix) const { + return str().endswith(Suffix); } /// @} @@ -142,7 +145,7 @@ public: /// /// \returns The index of the first occurrence of \p Str, or npos if not /// found. - [[nodiscard]] size_t find(StringRef Str, size_t From = 0) const { + [[nodiscard]] size_t find(std::string_view Str, size_t From = 0) const { return str().find(Str, From); } @@ -150,7 +153,8 @@ public: /// /// \returns The index of the last occurrence of \p C, or npos if not /// found. - [[nodiscard]] size_t rfind(char C, size_t From = StringRef::npos) const { + [[nodiscard]] size_t rfind(char C, + size_t From = std::string_view::npos) const { return str().rfind(C, From); } @@ -158,7 +162,9 @@ public: /// /// \returns The index of the last occurrence of \p Str, or npos if not /// found. - [[nodiscard]] size_t rfind(StringRef Str) const { return str().rfind(Str); } + [[nodiscard]] size_t rfind(std::string_view Str) const { + return str().rfind(Str); + } /// Find the first character in the string that is \p C, or npos if not /// found. Same as find. @@ -170,7 +176,8 @@ public: /// not found. /// /// Complexity: O(size() + Chars.size()) - [[nodiscard]] size_t find_first_of(StringRef Chars, size_t From = 0) const { + [[nodiscard]] size_t find_first_of(std::string_view Chars, + size_t From = 0) const { return str().find_first_of(Chars, From); } @@ -184,15 +191,15 @@ public: /// \p Chars, or npos if not found. /// /// Complexity: O(size() + Chars.size()) - [[nodiscard]] size_t find_first_not_of(StringRef Chars, + [[nodiscard]] size_t find_first_not_of(std::string_view Chars, size_t From = 0) const { return str().find_first_not_of(Chars, From); } /// Find the last character in the string that is \p C, or npos if not /// found. - [[nodiscard]] size_t find_last_of(char C, - size_t From = StringRef::npos) const { + [[nodiscard]] size_t find_last_of( + char C, size_t From = std::string_view::npos) const { return str().find_last_of(C, From); } @@ -200,8 +207,8 @@ public: /// found. /// /// Complexity: O(size() + Chars.size()) - [[nodiscard]] size_t find_last_of(StringRef Chars, - size_t From = StringRef::npos) const { + [[nodiscard]] size_t find_last_of( + std::string_view Chars, size_t From = std::string_view::npos) const { return str().find_last_of(Chars, From); } @@ -214,7 +221,9 @@ public: /// Return the number of non-overlapped occurrences of \p Str in the /// string. - [[nodiscard]] size_t count(StringRef Str) const { return str().count(Str); } + [[nodiscard]] size_t count(std::string_view Str) const { + return str().count(Str); + } /// @} /// @name Substring Operations @@ -229,8 +238,8 @@ public: /// \param N The number of characters to included in the substring. If \p N /// exceeds the number of characters remaining in the string, the string /// suffix (starting with \p Start) will be returned. - [[nodiscard]] StringRef substr(size_t Start, - size_t N = StringRef::npos) const { + [[nodiscard]] std::string_view substr( + size_t Start, size_t N = std::string_view::npos) const { return str().substr(Start, N); } @@ -244,15 +253,15 @@ public: /// substring. If this is npos, or less than \p Start, or exceeds the /// number of characters remaining in the string, the string suffix /// (starting with \p Start) will be returned. - [[nodiscard]] StringRef slice(size_t Start, size_t End) const { + [[nodiscard]] std::string_view slice(size_t Start, size_t End) const { return str().slice(Start, End); } // Extra methods. - /// Explicit conversion to StringRef. - [[nodiscard]] StringRef str() const { - return StringRef(this->data(), this->size()); + /// Explicit conversion to std::string_view. + [[nodiscard]] std::string_view str() const { + return std::string_view(this->begin(), this->size()); } // TODO: Make this const, if it's safe... @@ -262,20 +271,20 @@ public: return this->data(); } - /// Implicit conversion to StringRef. - operator StringRef() const { return str(); } + /// Implicit conversion to std::string_view. + operator std::string_view() const { return str(); } explicit operator std::string() const { return std::string(this->data(), this->size()); } // Extra operators. - SmallString &operator=(StringRef RHS) { + SmallString &operator=(std::string_view RHS) { this->assign(RHS); return *this; } - SmallString &operator+=(StringRef RHS) { + SmallString &operator+=(std::string_view RHS) { this->append(RHS.begin(), RHS.end()); return *this; } diff --git a/llvm/include/llvm/ADT/SmallVector.h b/llvm/include/llvm/ADT/SmallVector.h index bd3e887e36bce4129d95099e84e833adc6a82cee..be06bb817e24e723265f9a8038d94123de1fc53c 100644 --- a/llvm/include/llvm/ADT/SmallVector.h +++ b/llvm/include/llvm/ADT/SmallVector.h @@ -27,13 +27,12 @@ #include #include #include +#include #include #include namespace llvm { -template class ArrayRef; - template class iterator_range; template @@ -114,7 +113,7 @@ template struct SmallVectorAlignmentAndSize { }; /// This is the part of SmallVectorTemplateBase which does not depend on whether -/// the type T is a POD. The extra dummy template argument is used by ArrayRef +/// the type T is a POD. The extra dummy template argument is used by span /// to avoid unnecessarily requiring T to be complete. template class SmallVectorTemplateCommon @@ -1229,7 +1228,7 @@ public: template ::value>> - explicit SmallVector(ArrayRef A) : SmallVectorImpl(N) { + explicit SmallVector(span A) : SmallVectorImpl(N) { this->append(A.begin(), A.end()); } diff --git a/llvm/include/llvm/Support/Chrono.h b/llvm/include/llvm/Support/Chrono.h index 71859af7c7e4a595140475daf356744f52d14d24..9c9ba7002310eba5113c14957f769702c61f4326 100644 --- a/llvm/include/llvm/Support/Chrono.h +++ b/llvm/include/llvm/Support/Chrono.h @@ -91,7 +91,7 @@ raw_ostream &operator<<(raw_ostream &OS, sys::UtcTime<> TP); template <> struct format_provider> { static void format(const sys::TimePoint<> &TP, llvm::raw_ostream &OS, - StringRef Style); + std::string_view Style); }; template <> struct format_provider> { @@ -148,7 +148,7 @@ private: return duration_cast>(D).count(); } - static std::pair consumeUnit(StringRef &Style, + static std::pair consumeUnit(std::string_view &Style, const Dur &D) { using namespace std::chrono; if (Style.consume_front("ns")) @@ -166,7 +166,7 @@ private: return {D.count(), detail::unit::value}; } - static bool consumeShowUnit(StringRef &Style) { + static bool consumeShowUnit(std::string_view &Style) { if (Style.empty()) return true; if (Style.consume_front("-")) @@ -178,9 +178,9 @@ private: } public: - static void format(const Dur &D, llvm::raw_ostream &Stream, StringRef Style) { + static void format(const Dur &D, llvm::raw_ostream &Stream, std::string_view Style) { InternalRep count; - StringRef unit; + std::string_view unit; std::tie(count, unit) = consumeUnit(Style, D); bool show_unit = consumeShowUnit(Style); diff --git a/llvm/include/llvm/Support/Compiler.h b/llvm/include/llvm/Support/Compiler.h index dc8b5389069ebfe217d323fb9c75d6e0fe7d5b8e..021d1d29368deb330418ff4e08fbf3931e4b7453 100644 --- a/llvm/include/llvm/Support/Compiler.h +++ b/llvm/include/llvm/Support/Compiler.h @@ -406,7 +406,7 @@ #endif /// LLVM_GSL_POINTER - Apply this to non-owning classes like -/// StringRef to enable lifetime warnings. +/// std::string_view to enable lifetime warnings. #if LLVM_HAS_CPP_ATTRIBUTE(gsl::Pointer) #define LLVM_GSL_POINTER [[gsl::Pointer]] #else diff --git a/llvm/include/llvm/Support/ConvertUTF.h b/llvm/include/llvm/Support/ConvertUTF.h index c892bb3c03cb569994429649bdbb96e4118dcef1..5c0e3009c25446a34882fb98329b1d955231bb39 100644 --- a/llvm/include/llvm/Support/ConvertUTF.h +++ b/llvm/include/llvm/Support/ConvertUTF.h @@ -107,10 +107,9 @@ #include #include - -#if defined(_WIN32) +#include +#include #include -#endif // Wrap everything in namespace llvm so that programs can link with llvm and // their own version of the unicode libraries. @@ -204,12 +203,10 @@ unsigned getNumBytesForUTF8(UTF8 firstByte); /*************************************************************************/ /* Below are LLVM-specific wrappers of the functions above. */ -template class ArrayRef; template class SmallVectorImpl; -class StringRef; /** - * Convert an UTF8 StringRef to UTF8, UTF16, or UTF32 depending on + * Convert an UTF8 string_view to UTF8, UTF16, or UTF32 depending on * WideCharWidth. The converted data is written to ResultPtr, which needs to * point to at least WideCharWidth * (Source.Size() + 1) bytes. On success, * ResultPtr will point one after the end of the copied string. On failure, @@ -217,14 +214,14 @@ class StringRef; * the first character which could not be converted. * \return true on success. */ -bool ConvertUTF8toWide(unsigned WideCharWidth, llvm::StringRef Source, +bool ConvertUTF8toWide(unsigned WideCharWidth, std::string_view Source, char *&ResultPtr, const UTF8 *&ErrorPtr); /** -* Converts a UTF-8 StringRef to a std::wstring. +* Converts a UTF-8 string_view to a std::wstring. * \return true on success. */ -bool ConvertUTF8toWide(llvm::StringRef Source, std::wstring &Result); +bool ConvertUTF8toWide(std::string_view Source, std::wstring &Result); /** * Converts a UTF-8 C-string to a std::wstring. @@ -282,7 +279,7 @@ inline ConversionResult convertUTF8Sequence(const UTF8 **source, * Returns true if a blob of text starts with a UTF-16 big or little endian byte * order mark. */ -bool hasUTF16ByteOrderMark(ArrayRef SrcBytes); +bool hasUTF16ByteOrderMark(span SrcBytes); /** * Converts a stream of raw bytes assumed to be UTF16 into a UTF8 std::string. @@ -291,7 +288,7 @@ bool hasUTF16ByteOrderMark(ArrayRef SrcBytes); * \param [out] Out Converted UTF-8 is stored here on success. * \returns true on success */ -bool convertUTF16ToUTF8String(ArrayRef SrcBytes, std::string &Out); +bool convertUTF16ToUTF8String(span SrcBytes, std::string &Out); /** * Converts a UTF16 string into a UTF8 std::string. @@ -300,7 +297,7 @@ bool convertUTF16ToUTF8String(ArrayRef SrcBytes, std::string &Out); * \param [out] Out Converted UTF-8 is stored here on success. * \returns true on success */ -bool convertUTF16ToUTF8String(ArrayRef Src, std::string &Out); +bool convertUTF16ToUTF8String(span Src, std::string &Out); /** * Converts a stream of raw bytes assumed to be UTF32 into a UTF8 std::string. @@ -309,7 +306,7 @@ bool convertUTF16ToUTF8String(ArrayRef Src, std::string &Out); * \param [out] Out Converted UTF-8 is stored here on success. * \returns true on success */ -bool convertUTF32ToUTF8String(ArrayRef SrcBytes, std::string &Out); +bool convertUTF32ToUTF8String(span SrcBytes, std::string &Out); /** * Converts a UTF32 string into a UTF8 std::string. @@ -318,22 +315,22 @@ bool convertUTF32ToUTF8String(ArrayRef SrcBytes, std::string &Out); * \param [out] Out Converted UTF-8 is stored here on success. * \returns true on success */ -bool convertUTF32ToUTF8String(ArrayRef Src, std::string &Out); +bool convertUTF32ToUTF8String(span Src, std::string &Out); /** * Converts a UTF-8 string into a UTF-16 string with native endianness. * * \returns true on success */ -bool convertUTF8ToUTF16String(StringRef SrcUTF8, +bool convertUTF8ToUTF16String(std::string_view SrcUTF8, SmallVectorImpl &DstUTF16); #if defined(_WIN32) namespace sys { namespace windows { -std::error_code UTF8ToUTF16(StringRef utf8, SmallVectorImpl &utf16); +std::error_code UTF8ToUTF16(std::string_view utf8, SmallVectorImpl &utf16); /// Convert to UTF16 from the current code page used in the system -std::error_code CurCPToUTF16(StringRef utf8, SmallVectorImpl &utf16); +std::error_code CurCPToUTF16(std::string_view utf8, SmallVectorImpl &utf16); std::error_code UTF16ToUTF8(const wchar_t *utf16, size_t utf16_len, SmallVectorImpl &utf8); /// Convert from UTF16 to the current code page used in the system diff --git a/llvm/include/llvm/Support/ErrorHandling.h b/llvm/include/llvm/Support/ErrorHandling.h index 9c8e3448f3a03e3540adb8b9dd730c77dd9b20ba..68c27a8c67c4f378b92cfa726659ef7824b56dea 100644 --- a/llvm/include/llvm/Support/ErrorHandling.h +++ b/llvm/include/llvm/Support/ErrorHandling.h @@ -15,10 +15,10 @@ #define LLVM_SUPPORT_ERRORHANDLING_H #include "llvm/Support/Compiler.h" +#include +#include namespace llvm { - class StringRef; - class Twine; /// An error handler callback. typedef void (*fatal_error_handler_t)(void *user_data, @@ -67,12 +67,11 @@ namespace llvm { /// standard error, followed by a newline. /// After the error handler is called this function will call abort(), it /// does not return. -/// NOTE: The std::string variant was removed to avoid a dependency. [[noreturn]] void report_fatal_error(const char *reason, bool gen_crash_diag = true); -[[noreturn]] void report_fatal_error(StringRef reason, +[[noreturn]] void report_fatal_error(const std::string &reason, bool gen_crash_diag = true); -[[noreturn]] void report_fatal_error(const Twine &reason, +[[noreturn]] void report_fatal_error(std::string_view reason, bool gen_crash_diag = true); /// Installs a new bad alloc error handler that should be used whenever a diff --git a/llvm/include/llvm/Support/VersionTuple.h b/llvm/include/llvm/Support/VersionTuple.h index 0a4623f049d28825530bf50c8acfe85deaed96ba..e1cdce77ce8659305c99a21e01f9b3cc3481a5fd 100644 --- a/llvm/include/llvm/Support/VersionTuple.h +++ b/llvm/include/llvm/Support/VersionTuple.h @@ -23,7 +23,6 @@ namespace llvm { template class HashBuilder; class raw_ostream; -class StringRef; /// Represents a version number in the form major[.minor[.subminor[.build]]]. class VersionTuple { @@ -180,11 +179,6 @@ public: /// Retrieve a string representation of the version number. std::string getAsString() const; - - /// Try to parse the given string as a version number. - /// \returns \c true if the string does not match the regular expression - /// [0-9]+(\.[0-9]+){0,3} - bool tryParse(StringRef string); }; /// Print a version number. diff --git a/llvm/include/llvm/Support/Windows/WindowsSupport.h b/llvm/include/llvm/Support/Windows/WindowsSupport.h index 6f5aae2485c525f100eace5316b3e53e7b4fa544..83d5586ae8a77ec585e7e59df3075ca59cfb9d0c 100644 --- a/llvm/include/llvm/Support/Windows/WindowsSupport.h +++ b/llvm/include/llvm/Support/Windows/WindowsSupport.h @@ -33,8 +33,6 @@ #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringExtras.h" -#include "llvm/ADT/StringRef.h" -#include "llvm/ADT/Twine.h" #include "llvm/Config/llvm-config.h" // Get build system configuration settings #include "llvm/Support/Allocator.h" #include "llvm/Support/Chrono.h" @@ -72,7 +70,7 @@ bool MakeErrMsg(std::string *ErrMsg, const std::string &prefix); [[noreturn]] inline void ReportLastErrorFatal(const char *Msg) { std::string ErrMsg; MakeErrMsg(&ErrMsg, Msg); - llvm::report_fatal_error(Twine(ErrMsg)); + llvm::report_fatal_error(ErrMsg); } template diff --git a/llvm/include/llvm/Support/raw_ostream.h b/llvm/include/llvm/Support/raw_ostream.h index d3b411590e7fd796913aca8517020d02aa2559cc..c43c68c9114d8cd564484b190456b0069818dc87 100644 --- a/llvm/include/llvm/Support/raw_ostream.h +++ b/llvm/include/llvm/Support/raw_ostream.h @@ -14,13 +14,12 @@ #define LLVM_SUPPORT_RAW_OSTREAM_H #include "llvm/ADT/SmallVector.h" -#include "llvm/ADT/StringRef.h" -#include "llvm/Support/DataTypes.h" #include #include #include #include #include +#include #include #include #include @@ -221,7 +220,22 @@ public: return *this; } - raw_ostream &operator<<(StringRef Str) { + raw_ostream &operator<<(span Arr) { + // Inline fast path, particularly for arrays with a known length. + size_t Size = Arr.size(); + + // Make sure we can use the fast path. + if (Size > (size_t)(OutBufEnd - OutBufCur)) + return write(Arr.data(), Size); + + if (Size) { + memcpy(OutBufCur, Arr.data(), Size); + OutBufCur += Size; + } + return *this; + } + + raw_ostream &operator<<(std::string_view Str) { // Inline fast path, particularly for strings with a known length. size_t Size = Str.size(); @@ -254,7 +268,7 @@ public: // Inline fast path, particularly for constant strings where a sufficiently // smart compiler will simplify strlen. - return this->operator<<(StringRef(Str)); + return this->operator<<(std::string_view(Str)); } raw_ostream &operator<<(const std::string &Str) { @@ -262,10 +276,6 @@ public: return write(Str.data(), Str.length()); } - raw_ostream &operator<<(const std::string_view &Str) { - return write(Str.data(), Str.length()); - } - raw_ostream &operator<<(const SmallVectorImpl &Str) { return write(Str.data(), Str.size()); } @@ -298,7 +308,7 @@ public: /// Output \p Str, turning '\\', '\t', '\n', '"', and anything that doesn't /// satisfy llvm::isPrint into an escape sequence. - raw_ostream &write_escaped(StringRef Str, bool UseHexEscapes = false); + raw_ostream &write_escaped(std::string_view Str, bool UseHexEscapes = false); raw_ostream &write(unsigned char C); raw_ostream &write(const char *Ptr, size_t Size); @@ -511,14 +521,14 @@ public: /// As a special case, if Filename is "-", then the stream will use /// STDOUT_FILENO instead of opening a file. This will not close the stdout /// descriptor. - raw_fd_ostream(StringRef Filename, std::error_code &EC); - raw_fd_ostream(StringRef Filename, std::error_code &EC, + raw_fd_ostream(std::string_view Filename, std::error_code &EC); + raw_fd_ostream(std::string_view Filename, std::error_code &EC, sys::fs::CreationDisposition Disp); - raw_fd_ostream(StringRef Filename, std::error_code &EC, + raw_fd_ostream(std::string_view Filename, std::error_code &EC, sys::fs::FileAccess Access); - raw_fd_ostream(StringRef Filename, std::error_code &EC, + raw_fd_ostream(std::string_view Filename, std::error_code &EC, sys::fs::OpenFlags Flags); - raw_fd_ostream(StringRef Filename, std::error_code &EC, + raw_fd_ostream(std::string_view Filename, std::error_code &EC, sys::fs::CreationDisposition Disp, sys::fs::FileAccess Access, sys::fs::OpenFlags Flags); @@ -630,7 +640,7 @@ public: /// Open the specified file for reading/writing/seeking. If an error occurs, /// information about the error is put into EC, and the stream should be /// immediately destroyed. - raw_fd_stream(StringRef Filename, std::error_code &EC); + raw_fd_stream(std::string_view Filename, std::error_code &EC); raw_fd_stream(int fd, bool shouldClose); @@ -716,8 +726,8 @@ public: void flush() = delete; - /// Return a StringRef for the vector contents. - StringRef str() const { return StringRef(OS.data(), OS.size()); } + /// Return a std::string_view for the vector contents. + std::string_view str() const { return std::string_view(OS.data(), OS.size()); } SmallVectorImpl &buffer() { return OS; } void reserveExtraSpace(uint64_t ExtraSize) override { @@ -835,7 +845,7 @@ class Error; /// for other names. For raw_fd_ostream instances, the stream writes to /// a temporary file. The final output file is atomically replaced with the /// temporary file after the \p Write function is finished. -Error writeToOutput(StringRef OutputFileName, +Error writeToOutput(std::string_view OutputFileName, std::function Write); raw_ostream &operator<<(raw_ostream &OS, std::nullopt_t); diff --git a/llvm/lib/Support/ConvertUTFWrapper.cpp b/llvm/lib/Support/ConvertUTFWrapper.cpp index 4952fe65d77675aeae8f4f5fdad7b47863e36ca5..d53462e742e61d3476915d5b2c5aa63772e78a8a 100644 --- a/llvm/lib/Support/ConvertUTFWrapper.cpp +++ b/llvm/lib/Support/ConvertUTFWrapper.cpp @@ -6,23 +6,24 @@ // //===----------------------------------------------------------------------===// -#include "llvm/ADT/ArrayRef.h" -#include "llvm/ADT/StringRef.h" #include "llvm/Support/ConvertUTF.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/SwapByteOrder.h" +#include #include +#include #include namespace llvm { -bool ConvertUTF8toWide(unsigned WideCharWidth, llvm::StringRef Source, +bool ConvertUTF8toWide(unsigned WideCharWidth, std::string_view Source, char *&ResultPtr, const UTF8 *&ErrorPtr) { assert(WideCharWidth == 1 || WideCharWidth == 2 || WideCharWidth == 4); ConversionResult result = conversionOK; // Copy the character span over. if (WideCharWidth == 1) { - const UTF8 *Pos = reinterpret_cast(Source.begin()); - if (!isLegalUTF8String(&Pos, reinterpret_cast(Source.end()))) { + const UTF8 *Pos = reinterpret_cast(Source.data()); + if (!isLegalUTF8String(&Pos, reinterpret_cast(Source.data() + Source.size()))) { result = sourceIllegal; ErrorPtr = Pos; } else { @@ -75,12 +76,12 @@ bool ConvertCodePointToUTF8(unsigned Source, char *&ResultPtr) { return true; } -bool hasUTF16ByteOrderMark(ArrayRef S) { +bool hasUTF16ByteOrderMark(span S) { return (S.size() >= 2 && ((S[0] == '\xff' && S[1] == '\xfe') || (S[0] == '\xfe' && S[1] == '\xff'))); } -bool convertUTF16ToUTF8String(ArrayRef SrcBytes, std::string &Out) { +bool convertUTF16ToUTF8String(span SrcBytes, std::string &Out) { assert(Out.empty()); // Error out on an uneven byte count. @@ -131,14 +132,14 @@ bool convertUTF16ToUTF8String(ArrayRef SrcBytes, std::string &Out) { return true; } -bool convertUTF16ToUTF8String(ArrayRef Src, std::string &Out) { +bool convertUTF16ToUTF8String(span Src, std::string &Out) { return convertUTF16ToUTF8String( - llvm::ArrayRef(reinterpret_cast(Src.data()), + span(reinterpret_cast(Src.data()), Src.size() * sizeof(UTF16)), Out); } -bool convertUTF32ToUTF8String(ArrayRef SrcBytes, std::string &Out) { +bool convertUTF32ToUTF8String(span SrcBytes, std::string &Out) { assert(Out.empty()); // Error out on an uneven byte count. @@ -189,14 +190,14 @@ bool convertUTF32ToUTF8String(ArrayRef SrcBytes, std::string &Out) { return true; } -bool convertUTF32ToUTF8String(ArrayRef Src, std::string &Out) { +bool convertUTF32ToUTF8String(span Src, std::string &Out) { return convertUTF32ToUTF8String( - llvm::ArrayRef(reinterpret_cast(Src.data()), + span(reinterpret_cast(Src.data()), Src.size() * sizeof(UTF32)), Out); } -bool convertUTF8ToUTF16String(StringRef SrcUTF8, +bool convertUTF8ToUTF16String(std::string_view SrcUTF8, SmallVectorImpl &DstUTF16) { assert(DstUTF16.empty()); @@ -207,8 +208,8 @@ bool convertUTF8ToUTF16String(StringRef SrcUTF8, return true; } - const UTF8 *Src = reinterpret_cast(SrcUTF8.begin()); - const UTF8 *SrcEnd = reinterpret_cast(SrcUTF8.end()); + const UTF8 *Src = reinterpret_cast(SrcUTF8.data()); + const UTF8 *SrcEnd = reinterpret_cast(SrcUTF8.data() + SrcUTF8.size()); // Allocate the same number of UTF-16 code units as UTF-8 code units. Encoding // as UTF-16 should always require the same amount or less code units than the @@ -239,7 +240,7 @@ static_assert(sizeof(wchar_t) == 1 || sizeof(wchar_t) == 2 || "Expected wchar_t to be 1, 2, or 4 bytes"); template -static inline bool ConvertUTF8toWideInternal(llvm::StringRef Source, +static inline bool ConvertUTF8toWideInternal(std::string_view Source, TResult &Result) { // Even in the case of UTF-16, the number of bytes in a UTF-8 string is // at least as large as the number of elements in the resulting wide @@ -255,7 +256,7 @@ static inline bool ConvertUTF8toWideInternal(llvm::StringRef Source, return true; } -bool ConvertUTF8toWide(llvm::StringRef Source, std::wstring &Result) { +bool ConvertUTF8toWide(std::string_view Source, std::wstring &Result) { return ConvertUTF8toWideInternal(Source, Result); } @@ -264,7 +265,7 @@ bool ConvertUTF8toWide(const char *Source, std::wstring &Result) { Result.clear(); return true; } - return ConvertUTF8toWide(llvm::StringRef(Source), Result); + return ConvertUTF8toWide(std::string_view(Source), Result); } bool convertWideToUTF8(const std::wstring &Source, std::string &Result) { @@ -279,7 +280,7 @@ bool convertWideToUTF8(const std::wstring &Source, std::string &Result) { return true; } else if (sizeof(wchar_t) == 2) { return convertUTF16ToUTF8String( - llvm::ArrayRef(reinterpret_cast(Source.data()), + span(reinterpret_cast(Source.data()), Source.size()), Result); } else if (sizeof(wchar_t) == 4) { diff --git a/llvm/lib/Support/ErrorHandling.cpp b/llvm/lib/Support/ErrorHandling.cpp index afe3b37cc343195e9ea12a68077d6b9d7506d5bb..d4ca266f3c1f98337499fba4fd0675e49a7dcf18 100644 --- a/llvm/lib/Support/ErrorHandling.cpp +++ b/llvm/lib/Support/ErrorHandling.cpp @@ -14,7 +14,6 @@ #include "llvm/Support/ErrorHandling.h" #include "llvm-c/ErrorHandling.h" #include "llvm/ADT/SmallVector.h" -#include "llvm/ADT/Twine.h" #include "llvm/Config/config.h" #include "llvm/Config/llvm-config.h" // for LLVM_ENABLE_THREADS #include "llvm/Support/Debug.h" @@ -81,14 +80,14 @@ void llvm::remove_fatal_error_handler() { } void llvm::report_fatal_error(const char *Reason, bool GenCrashDiag) { - report_fatal_error(Twine(Reason), GenCrashDiag); + report_fatal_error(std::string_view(Reason), GenCrashDiag); } -void llvm::report_fatal_error(StringRef Reason, bool GenCrashDiag) { - report_fatal_error(Twine(Reason), GenCrashDiag); +void llvm::report_fatal_error(const std::string &Reason, bool GenCrashDiag) { + report_fatal_error(std::string_view(Reason), GenCrashDiag); } -void llvm::report_fatal_error(const Twine &Reason, bool GenCrashDiag) { +void llvm::report_fatal_error(std::string_view Reason, bool GenCrashDiag) { llvm::fatal_error_handler_t handler = nullptr; void* handlerData = nullptr; { @@ -102,7 +101,7 @@ void llvm::report_fatal_error(const Twine &Reason, bool GenCrashDiag) { } if (handler) { - handler(handlerData, Reason.str().c_str(), GenCrashDiag); + handler(handlerData, std::string{Reason}.c_str(), GenCrashDiag); } else { // Blast the result out to stderr. We don't try hard to make sure this // succeeds (e.g. handling EINTR) and we can't use errs() here because @@ -110,7 +109,7 @@ void llvm::report_fatal_error(const Twine &Reason, bool GenCrashDiag) { SmallVector Buffer; raw_svector_ostream OS(Buffer); OS << "LLVM ERROR: " << Reason << "\n"; - StringRef MessageStr = OS.str(); + std::string_view MessageStr = OS.str(); ssize_t written = ::write(2, MessageStr.data(), MessageStr.size()); (void)written; // If something went wrong, we deliberately just give up. } diff --git a/llvm/lib/Support/SmallVector.cpp b/llvm/lib/Support/SmallVector.cpp index dceea4fbc630e85a869458af8b35ee1066c5866d..fba8fcb7cf56f4914e6ab6ede78eb8d8c8bf3424 100644 --- a/llvm/lib/Support/SmallVector.cpp +++ b/llvm/lib/Support/SmallVector.cpp @@ -11,7 +11,6 @@ //===----------------------------------------------------------------------===// #include "llvm/ADT/SmallVector.h" -#include "llvm/ADT/Twine.h" #include "llvm/Support/MemAlloc.h" #include #ifdef LLVM_ENABLE_EXCEPTIONS @@ -67,7 +66,7 @@ static void report_size_overflow(size_t MinSize, size_t MaxSize) { #ifdef LLVM_ENABLE_EXCEPTIONS throw std::length_error(Reason); #else - report_fatal_error(Twine(Reason)); + report_fatal_error(Reason); #endif } @@ -81,7 +80,7 @@ static void report_at_maximum_capacity(size_t MaxSize) { #ifdef LLVM_ENABLE_EXCEPTIONS throw std::length_error(Reason); #else - report_fatal_error(Twine(Reason)); + report_fatal_error(Reason); #endif } diff --git a/llvm/lib/Support/raw_ostream.cpp b/llvm/lib/Support/raw_ostream.cpp index e75ddc66b7d1629a4e71c53d891ae0d3edf90813..681b6fdc95eb4fda4f23d0b381b83417d82b3b78 100644 --- a/llvm/lib/Support/raw_ostream.cpp +++ b/llvm/lib/Support/raw_ostream.cpp @@ -165,7 +165,7 @@ raw_ostream &raw_ostream::write_uuid(const uuid_t UUID) { } -raw_ostream &raw_ostream::write_escaped(StringRef Str, +raw_ostream &raw_ostream::write_escaped(std::string_view Str, bool UseHexEscapes) { for (unsigned char c : Str) { switch (c) { @@ -562,7 +562,7 @@ void format_object_base::home() { // raw_fd_ostream //===----------------------------------------------------------------------===// -static int getFD(StringRef Filename, std::error_code &EC, +static int getFD(std::string_view Filename, std::error_code &EC, sys::fs::CreationDisposition Disp, sys::fs::FileAccess Access, sys::fs::OpenFlags Flags) { assert((Access & sys::fs::FA_Write) && @@ -588,25 +588,25 @@ static int getFD(StringRef Filename, std::error_code &EC, return FD; } -raw_fd_ostream::raw_fd_ostream(StringRef Filename, std::error_code &EC) +raw_fd_ostream::raw_fd_ostream(std::string_view Filename, std::error_code &EC) : raw_fd_ostream(Filename, EC, sys::fs::CD_CreateAlways, sys::fs::FA_Write, sys::fs::OF_None) {} -raw_fd_ostream::raw_fd_ostream(StringRef Filename, std::error_code &EC, +raw_fd_ostream::raw_fd_ostream(std::string_view Filename, std::error_code &EC, sys::fs::CreationDisposition Disp) : raw_fd_ostream(Filename, EC, Disp, sys::fs::FA_Write, sys::fs::OF_None) {} -raw_fd_ostream::raw_fd_ostream(StringRef Filename, std::error_code &EC, +raw_fd_ostream::raw_fd_ostream(std::string_view Filename, std::error_code &EC, sys::fs::FileAccess Access) : raw_fd_ostream(Filename, EC, sys::fs::CD_CreateAlways, Access, sys::fs::OF_None) {} -raw_fd_ostream::raw_fd_ostream(StringRef Filename, std::error_code &EC, +raw_fd_ostream::raw_fd_ostream(std::string_view Filename, std::error_code &EC, sys::fs::OpenFlags Flags) : raw_fd_ostream(Filename, EC, sys::fs::CD_CreateAlways, sys::fs::FA_Write, Flags) {} -raw_fd_ostream::raw_fd_ostream(StringRef Filename, std::error_code &EC, +raw_fd_ostream::raw_fd_ostream(std::string_view Filename, std::error_code &EC, sys::fs::CreationDisposition Disp, sys::fs::FileAccess Access, sys::fs::OpenFlags Flags) @@ -678,8 +678,7 @@ raw_fd_ostream::~raw_fd_ostream() { // has_error() and clear the error flag with clear_error() before // destructing raw_ostream objects which may have errors. if (has_error()) - report_fatal_error(Twine("IO failure on output stream: ") + - error().message(), + report_fatal_error("IO failure on output stream: " + error().message(), /*gen_crash_diag=*/false); } @@ -698,7 +697,7 @@ raw_fd_ostream::~raw_fd_ostream() { // the input is UTF-8 or transcode from the local codepage to UTF-8 before // quoting it. If they don't, this may mess up the encoding, but this is still // probably the best compromise we can make. -static bool write_console_impl(int FD, StringRef Data) { +static bool write_console_impl(int FD, std::string_view Data) { SmallVector WideText; // Fall back to ::write if it wasn't valid UTF-8. @@ -744,7 +743,7 @@ void raw_fd_ostream::write_impl(const char *Ptr, size_t Size) { // If this is a Windows console device, try re-encoding from UTF-8 to UTF-16 // and using WriteConsoleW. If that fails, fall back to plain write(). if (IsWindowsConsole) - if (write_console_impl(FD, StringRef(Ptr, Size))) + if (write_console_impl(FD, std::string_view(Ptr, Size))) return; #endif @@ -924,7 +923,7 @@ raw_ostream &llvm::nulls() { // File Streams //===----------------------------------------------------------------------===// -raw_fd_stream::raw_fd_stream(StringRef Filename, std::error_code &EC) +raw_fd_stream::raw_fd_stream(std::string_view Filename, std::error_code &EC) : raw_fd_ostream(getFD(Filename, EC, sys::fs::CD_CreateAlways, sys::fs::FA_Write | sys::fs::FA_Read, sys::fs::OF_None), @@ -1009,7 +1008,7 @@ void buffer_ostream::anchor() {} void buffer_unique_ostream::anchor() {} -Error llvm::writeToOutput(StringRef OutputFileName, +Error llvm::writeToOutput(std::string_view OutputFileName, std::function Write) { if (OutputFileName == "-") return Write(outs()); diff --git a/llvm/unittests/ADT/DenseMapTest.cpp b/llvm/unittests/ADT/DenseMapTest.cpp index d1bbdde8dfc267770b9d98808de54381571f2785..e93e18423507655ce8275a0718d8e5d01915985f 100644 --- a/llvm/unittests/ADT/DenseMapTest.cpp +++ b/llvm/unittests/ADT/DenseMapTest.cpp @@ -10,11 +10,11 @@ #include "CountCopyAndMove.h" #include "llvm/ADT/DenseMapInfo.h" #include "llvm/ADT/DenseMapInfoVariant.h" -#include "llvm/ADT/StringRef.h" #include "gmock/gmock.h" #include "gtest/gtest.h" #include #include +#include #include #include @@ -523,31 +523,6 @@ TEST(DenseMapCustomTest, InsertOrAssignTest) { EXPECT_EQ(1, CountCopyAndMove::MoveAssignments); } -// Make sure DenseMap works with StringRef keys. -TEST(DenseMapCustomTest, StringRefTest) { - DenseMap M; - - M["a"] = 1; - M["b"] = 2; - M["c"] = 3; - - EXPECT_EQ(3u, M.size()); - EXPECT_EQ(1, M.lookup("a")); - EXPECT_EQ(2, M.lookup("b")); - EXPECT_EQ(3, M.lookup("c")); - - EXPECT_EQ(0, M.lookup("q")); - - // Test the empty string, spelled various ways. - EXPECT_EQ(0, M.lookup("")); - EXPECT_EQ(0, M.lookup(StringRef())); - EXPECT_EQ(0, M.lookup(StringRef("a", 0))); - M[""] = 42; - EXPECT_EQ(42, M.lookup("")); - EXPECT_EQ(42, M.lookup(StringRef())); - EXPECT_EQ(42, M.lookup(StringRef("a", 0))); -} - // Key traits that allows lookup with either an unsigned or char* key; // In the latter case, "a" == 0, "b" == 1 and so on. struct TestDenseMapInfo { @@ -785,7 +760,7 @@ TEST(DenseMapCustomTest, VariantSupport) { // Test that gTest prints map entries as pairs instead of opaque objects. // See third-party/unittest/googletest/internal/custom/gtest-printers.h TEST(DenseMapCustomTest, PairPrinting) { - DenseMap Map = {{1, "one"}, {2, "two"}}; + DenseMap Map = {{1, "one"}, {2, "two"}}; EXPECT_EQ(R"({ (1, "one"), (2, "two") })", ::testing::PrintToString(Map)); } diff --git a/llvm/unittests/ADT/FunctionExtrasTest.cpp b/llvm/unittests/ADT/FunctionExtrasTest.cpp index 9809a92daac72468ed5bbd1762798523c2c3d628..777c5784949fd3c07bbbcef8dc3fc8e5764896a9 100644 --- a/llvm/unittests/ADT/FunctionExtrasTest.cpp +++ b/llvm/unittests/ADT/FunctionExtrasTest.cpp @@ -250,23 +250,23 @@ TEST(UniqueFunctionTest, Const) { // Overloaded call operator correctly resolved. struct ChooseCorrectOverload { - StringRef operator()() { return "non-const"; } - StringRef operator()() const { return "const"; } + std::string_view operator()() { return "non-const"; } + std::string_view operator()() const { return "const"; } }; - unique_function ChooseMutable = ChooseCorrectOverload(); + unique_function ChooseMutable = ChooseCorrectOverload(); ChooseCorrectOverload A; EXPECT_EQ("non-const", ChooseMutable()); EXPECT_EQ("non-const", A()); - unique_function ChooseConst = ChooseCorrectOverload(); + unique_function ChooseConst = ChooseCorrectOverload(); const ChooseCorrectOverload &X = A; EXPECT_EQ("const", ChooseConst()); EXPECT_EQ("const", X()); } // Test that overloads on unique_functions are resolved as expected. -std::string returns(StringRef) { return "not a function"; } +std::string returns(std::string_view) { return "not a function"; } std::string returns(unique_function F) { return "number"; } -std::string returns(unique_function F) { return "string"; } +std::string returns(unique_function F) { return "string"; } TEST(UniqueFunctionTest, SFINAE) { EXPECT_EQ("not a function", returns("boo!")); diff --git a/llvm/unittests/ADT/SmallPtrSetTest.cpp b/llvm/unittests/ADT/SmallPtrSetTest.cpp index 1d9a0d1725a92ffd1bddcddf0a9ede28a1a74969..88be2b68915573a3b3a343ff53a84d86604d7bfd 100644 --- a/llvm/unittests/ADT/SmallPtrSetTest.cpp +++ b/llvm/unittests/ADT/SmallPtrSetTest.cpp @@ -12,7 +12,6 @@ #include "llvm/ADT/SmallPtrSet.h" #include "llvm/ADT/PointerIntPair.h" -#include "llvm/ADT/STLExtras.h" #include "llvm/Support/PointerLikeTypeTraits.h" #include "gmock/gmock.h" #include "gtest/gtest.h" diff --git a/llvm/unittests/ADT/SmallStringTest.cpp b/llvm/unittests/ADT/SmallStringTest.cpp index 2f4df8afeafa592cb9616bb78feb4964187786f2..6cf14700b34739420cd3dc4ff8a4c16ce162f715 100644 --- a/llvm/unittests/ADT/SmallStringTest.cpp +++ b/llvm/unittests/ADT/SmallStringTest.cpp @@ -50,43 +50,43 @@ TEST_F(SmallStringTest, AssignRepeated) { } TEST_F(SmallStringTest, AssignIterPair) { - StringRef abc = "abc"; + std::string_view abc = "abc"; theString.assign(abc.begin(), abc.end()); EXPECT_EQ(3u, theString.size()); EXPECT_STREQ("abc", theString.c_str()); } -TEST_F(SmallStringTest, AssignStringRef) { - StringRef abc = "abc"; +TEST_F(SmallStringTest, AssignStringView) { + std::string_view abc = "abc"; theString.assign(abc); EXPECT_EQ(3u, theString.size()); EXPECT_STREQ("abc", theString.c_str()); } TEST_F(SmallStringTest, AssignSmallVector) { - StringRef abc = "abc"; + std::string_view abc = "abc"; SmallVector abcVec(abc.begin(), abc.end()); theString.assign(abcVec); EXPECT_EQ(3u, theString.size()); EXPECT_STREQ("abc", theString.c_str()); } -TEST_F(SmallStringTest, AssignStringRefs) { +TEST_F(SmallStringTest, AssignStringViews) { theString.assign({"abc", "def", "ghi"}); EXPECT_EQ(9u, theString.size()); EXPECT_STREQ("abcdefghi", theString.c_str()); } TEST_F(SmallStringTest, AppendIterPair) { - StringRef abc = "abc"; + std::string_view abc = "abc"; theString.append(abc.begin(), abc.end()); theString.append(abc.begin(), abc.end()); EXPECT_EQ(6u, theString.size()); EXPECT_STREQ("abcabc", theString.c_str()); } -TEST_F(SmallStringTest, AppendStringRef) { - StringRef abc = "abc"; +TEST_F(SmallStringTest, AppendStringView) { + std::string_view abc = "abc"; theString.append(abc); theString.append(abc); EXPECT_EQ(6u, theString.size()); @@ -94,7 +94,7 @@ TEST_F(SmallStringTest, AppendStringRef) { } TEST_F(SmallStringTest, AppendSmallVector) { - StringRef abc = "abc"; + std::string_view abc = "abc"; SmallVector abcVec(abc.begin(), abc.end()); theString.append(abcVec); theString.append(abcVec); @@ -102,11 +102,11 @@ TEST_F(SmallStringTest, AppendSmallVector) { EXPECT_STREQ("abcabc", theString.c_str()); } -TEST_F(SmallStringTest, AppendStringRefs) { +TEST_F(SmallStringTest, AppendStringViews) { theString.append({"abc", "def", "ghi"}); EXPECT_EQ(9u, theString.size()); EXPECT_STREQ("abcdefghi", theString.c_str()); - StringRef Jkl = "jkl"; + std::string_view Jkl = "jkl"; std::string Mno = "mno"; SmallString<4> Pqr("pqr"); const char *Stu = "stu"; @@ -115,15 +115,15 @@ TEST_F(SmallStringTest, AppendStringRefs) { EXPECT_STREQ("abcdefghijklmnopqrstu", theString.c_str()); } -TEST_F(SmallStringTest, StringRefConversion) { - StringRef abc = "abc"; +TEST_F(SmallStringTest, StringViewConversion) { + std::string_view abc = "abc"; theString.assign(abc.begin(), abc.end()); - StringRef theStringRef = theString; - EXPECT_EQ("abc", theStringRef); + std::string_view theStringView = theString; + EXPECT_EQ("abc", theStringView); } TEST_F(SmallStringTest, StdStringConversion) { - StringRef abc = "abc"; + std::string_view abc = "abc"; theString.assign(abc.begin(), abc.end()); std::string theStdString = std::string(theString); EXPECT_EQ("abc", theStdString); @@ -149,29 +149,29 @@ TEST_F(SmallStringTest, Slice) { TEST_F(SmallStringTest, Find) { theString = "hello"; EXPECT_EQ(2U, theString.find('l')); - EXPECT_EQ(StringRef::npos, theString.find('z')); - EXPECT_EQ(StringRef::npos, theString.find("helloworld")); + EXPECT_EQ(std::string_view::npos, theString.find('z')); + EXPECT_EQ(std::string_view::npos, theString.find("helloworld")); EXPECT_EQ(0U, theString.find("hello")); EXPECT_EQ(1U, theString.find("ello")); - EXPECT_EQ(StringRef::npos, theString.find("zz")); + EXPECT_EQ(std::string_view::npos, theString.find("zz")); EXPECT_EQ(2U, theString.find("ll", 2)); - EXPECT_EQ(StringRef::npos, theString.find("ll", 3)); + EXPECT_EQ(std::string_view::npos, theString.find("ll", 3)); EXPECT_EQ(0U, theString.find("")); EXPECT_EQ(3U, theString.rfind('l')); - EXPECT_EQ(StringRef::npos, theString.rfind('z')); - EXPECT_EQ(StringRef::npos, theString.rfind("helloworld")); + EXPECT_EQ(std::string_view::npos, theString.rfind('z')); + EXPECT_EQ(std::string_view::npos, theString.rfind("helloworld")); EXPECT_EQ(0U, theString.rfind("hello")); EXPECT_EQ(1U, theString.rfind("ello")); - EXPECT_EQ(StringRef::npos, theString.rfind("zz")); + EXPECT_EQ(std::string_view::npos, theString.rfind("zz")); EXPECT_EQ(2U, theString.find_first_of('l')); EXPECT_EQ(1U, theString.find_first_of("el")); - EXPECT_EQ(StringRef::npos, theString.find_first_of("xyz")); + EXPECT_EQ(std::string_view::npos, theString.find_first_of("xyz")); EXPECT_EQ(1U, theString.find_first_not_of('h')); EXPECT_EQ(4U, theString.find_first_not_of("hel")); - EXPECT_EQ(StringRef::npos, theString.find_first_not_of("hello")); + EXPECT_EQ(std::string_view::npos, theString.find_first_not_of("hello")); theString = "hellx xello hell ello world foo bar hello"; EXPECT_EQ(36U, theString.find("hello")); diff --git a/llvm/unittests/ADT/SmallVectorTest.cpp b/llvm/unittests/ADT/SmallVectorTest.cpp index 137dd43b473068eae34b39edc4b9b8b9633bab95..7029038d18d433cef987bedbfa4fda269b24fb8f 100644 --- a/llvm/unittests/ADT/SmallVectorTest.cpp +++ b/llvm/unittests/ADT/SmallVectorTest.cpp @@ -11,10 +11,10 @@ //===----------------------------------------------------------------------===// #include "llvm/ADT/SmallVector.h" -#include "llvm/ADT/ArrayRef.h" #include "llvm/Support/Compiler.h" #include "gtest/gtest.h" #include +#include #include using namespace llvm; @@ -252,11 +252,11 @@ TYPED_TEST(SmallVectorTest, ConstructorIterTest) { } // Constructor test. -TYPED_TEST(SmallVectorTest, ConstructorFromArrayRefSimpleTest) { - SCOPED_TRACE("ConstructorFromArrayRefSimpleTest"); +TYPED_TEST(SmallVectorTest, ConstructorFromSpanSimpleTest) { + SCOPED_TRACE("ConstructorFromSpanSimpleTest"); std::array StdArray = {Constructable(1), Constructable(2), Constructable(3)}; - ArrayRef Array = StdArray; + span Array = StdArray; auto &V = this->theVector; V = SmallVector(Array); assertValuesInOrder(V, 3u, 1, 2, 3); @@ -1129,24 +1129,6 @@ TEST(SmallVectorTest, DefaultInlinedElements) { EXPECT_EQ(NestedV[0][0][0], 42); } -TEST(SmallVectorTest, InitializerList) { - SmallVector V1 = {}; - EXPECT_TRUE(V1.empty()); - V1 = {0, 0}; - EXPECT_TRUE(ArrayRef(V1).equals({0, 0})); - V1 = {-1, -1}; - EXPECT_TRUE(ArrayRef(V1).equals({-1, -1})); - - SmallVector V2 = {1, 2, 3, 4}; - EXPECT_TRUE(ArrayRef(V2).equals({1, 2, 3, 4})); - V2.assign({4}); - EXPECT_TRUE(ArrayRef(V2).equals({4})); - V2.append({3, 2}); - EXPECT_TRUE(ArrayRef(V2).equals({4, 3, 2})); - V2.insert(V2.begin() + 1, 5); - EXPECT_TRUE(ArrayRef(V2).equals({4, 5, 3, 2})); -} - TEST(SmallVectorTest, ToVector) { { std::vector v = {'a', 'b', 'c'}; @@ -1183,10 +1165,10 @@ private: To T; }; -TEST(SmallVectorTest, ConstructFromArrayRefOfConvertibleType) { +TEST(SmallVectorTest, ConstructFromSpanOfConvertibleType) { To to1{1}, to2{2}, to3{3}; std::vector StdVector = {From(to1), From(to2), From(to3)}; - ArrayRef Array = StdVector; + span Array = StdVector; { llvm::SmallVector Vector(Array); diff --git a/llvm/unittests/Support/ConvertUTFTest.cpp b/llvm/unittests/Support/ConvertUTFTest.cpp index 4c35a7e06df142cab79636df7769e556a42e1646..3b07d344f15a555f11ad5f8177a0a65b8a4fa472 100644 --- a/llvm/unittests/Support/ConvertUTFTest.cpp +++ b/llvm/unittests/Support/ConvertUTFTest.cpp @@ -7,7 +7,6 @@ //===----------------------------------------------------------------------===// #include "llvm/Support/ConvertUTF.h" -#include "llvm/ADT/ArrayRef.h" #include "gtest/gtest.h" #include #include @@ -17,7 +16,7 @@ using namespace llvm; TEST(ConvertUTFTest, ConvertUTF16LittleEndianToUTF8String) { // Src is the look of disapproval. alignas(UTF16) static const char Src[] = "\xff\xfe\xa0\x0c_\x00\xa0\x0c"; - ArrayRef Ref(Src, sizeof(Src) - 1); + span Ref(Src, sizeof(Src) - 1); std::string Result; bool Success = convertUTF16ToUTF8String(Ref, Result); EXPECT_TRUE(Success); @@ -29,7 +28,7 @@ TEST(ConvertUTFTest, ConvertUTF32LittleEndianToUTF8String) { // Src is the look of disapproval. alignas(UTF32) static const char Src[] = "\xFF\xFE\x00\x00\xA0\x0C\x00\x00\x5F\x00\x00\x00\xA0\x0C\x00\x00"; - ArrayRef Ref(Src, sizeof(Src) - 1); + span Ref(Src, sizeof(Src) - 1); std::string Result; bool Success = convertUTF32ToUTF8String(Ref, Result); EXPECT_TRUE(Success); @@ -40,7 +39,7 @@ TEST(ConvertUTFTest, ConvertUTF32LittleEndianToUTF8String) { TEST(ConvertUTFTest, ConvertUTF16BigEndianToUTF8String) { // Src is the look of disapproval. alignas(UTF16) static const char Src[] = "\xfe\xff\x0c\xa0\x00_\x0c\xa0"; - ArrayRef Ref(Src, sizeof(Src) - 1); + span Ref(Src, sizeof(Src) - 1); std::string Result; bool Success = convertUTF16ToUTF8String(Ref, Result); EXPECT_TRUE(Success); @@ -52,7 +51,7 @@ TEST(ConvertUTFTest, ConvertUTF32BigEndianToUTF8String) { // Src is the look of disapproval. alignas(UTF32) static const char Src[] = "\x00\x00\xFE\xFF\x00\x00\x0C\xA0\x00\x00\x00\x5F\x00\x00\x0C\xA0"; - ArrayRef Ref(Src, sizeof(Src) - 1); + span Ref(Src, sizeof(Src) - 1); std::string Result; bool Success = convertUTF32ToUTF8String(Ref, Result); EXPECT_TRUE(Success); @@ -63,7 +62,7 @@ TEST(ConvertUTFTest, ConvertUTF32BigEndianToUTF8String) { TEST(ConvertUTFTest, ConvertUTF8ToUTF16String) { // Src is the look of disapproval. static const char Src[] = "\xe0\xb2\xa0_\xe0\xb2\xa0"; - StringRef Ref(Src, sizeof(Src) - 1); + std::string_view Ref(Src, sizeof(Src) - 1); SmallVector Result; bool Success = convertUTF8ToUTF16String(Ref, Result); EXPECT_TRUE(Success); @@ -75,37 +74,38 @@ TEST(ConvertUTFTest, ConvertUTF8ToUTF16String) { TEST(ConvertUTFTest, OddLengthInput) { std::string Result; - bool Success = convertUTF16ToUTF8String(ArrayRef("xxxxx", 5), Result); + bool Success = convertUTF16ToUTF8String(span("xxxxx", 5), Result); EXPECT_FALSE(Success); } TEST(ConvertUTFTest, Empty) { std::string Result; - bool Success = convertUTF16ToUTF8String(llvm::ArrayRef(), Result); + bool Success = + convertUTF16ToUTF8String(span(), Result); EXPECT_TRUE(Success); EXPECT_TRUE(Result.empty()); } TEST(ConvertUTFTest, HasUTF16BOM) { - bool HasBOM = hasUTF16ByteOrderMark(ArrayRef("\xff\xfe", 2)); + bool HasBOM = hasUTF16ByteOrderMark("\xff\xfe"); EXPECT_TRUE(HasBOM); - HasBOM = hasUTF16ByteOrderMark(ArrayRef("\xfe\xff", 2)); + HasBOM = hasUTF16ByteOrderMark("\xfe\xff"); EXPECT_TRUE(HasBOM); - HasBOM = hasUTF16ByteOrderMark(ArrayRef("\xfe\xff ", 3)); + HasBOM = hasUTF16ByteOrderMark("\xfe\xff "); EXPECT_TRUE(HasBOM); // Don't care about odd lengths. - HasBOM = hasUTF16ByteOrderMark(ArrayRef("\xfe\xff\x00asdf", 6)); + HasBOM = hasUTF16ByteOrderMark("\xfe\xff\x00asdf"); EXPECT_TRUE(HasBOM); - HasBOM = hasUTF16ByteOrderMark({}); + HasBOM = hasUTF16ByteOrderMark(""); EXPECT_FALSE(HasBOM); - HasBOM = hasUTF16ByteOrderMark(ArrayRef("\xfe", 1)); + HasBOM = hasUTF16ByteOrderMark("\xfe"); EXPECT_FALSE(HasBOM); } TEST(ConvertUTFTest, UTF16WrappersForConvertUTF16ToUTF8String) { // Src is the look of disapproval. alignas(UTF16) static const char Src[] = "\xff\xfe\xa0\x0c_\x00\xa0\x0c"; - ArrayRef SrcRef = ArrayRef((const UTF16 *)Src, 4); + span SrcRef((const UTF16 *)Src, 4); std::string Result; bool Success = convertUTF16ToUTF8String(SrcRef, Result); EXPECT_TRUE(Success); @@ -122,7 +122,7 @@ TEST(ConvertUTFTest, ConvertUTF8toWide) { std::wstring Expected(L"\x0ca0_\x0ca0"); EXPECT_EQ(Expected, Result); Result.clear(); - Success = ConvertUTF8toWide(StringRef(Src, 7), Result); + Success = ConvertUTF8toWide(Src, Result); EXPECT_TRUE(Success); EXPECT_EQ(Expected, Result); } @@ -171,7 +171,7 @@ struct ConvertUTFResultContainer { }; std::pair> -ConvertUTF8ToUnicodeScalarsLenient(StringRef S) { +ConvertUTF8ToUnicodeScalarsLenient(std::string_view S) { const UTF8 *SourceStart = reinterpret_cast(S.data()); const UTF8 *SourceNext = SourceStart; @@ -188,7 +188,7 @@ ConvertUTF8ToUnicodeScalarsLenient(StringRef S) { } std::pair> -ConvertUTF8ToUnicodeScalarsPartialLenient(StringRef S) { +ConvertUTF8ToUnicodeScalarsPartialLenient(std::string_view S) { const UTF8 *SourceStart = reinterpret_cast(S.data()); const UTF8 *SourceNext = SourceStart; @@ -206,7 +206,7 @@ ConvertUTF8ToUnicodeScalarsPartialLenient(StringRef S) { ::testing::AssertionResult CheckConvertUTF8ToUnicodeScalars(ConvertUTFResultContainer Expected, - StringRef S, bool Partial = false) { + std::string_view S, bool Partial = false) { ConversionResult ErrorCode; std::vector Decoded; if (!Partial) @@ -301,7 +301,7 @@ TEST(ConvertUTFTest, UTF8ToUTF32Lenient) { // U+0000 NULL EXPECT_TRUE(CheckConvertUTF8ToUnicodeScalars( ConvertUTFResultContainer(conversionOK).withScalars(0x0000), - StringRef("\x00", 1))); + std::string_view("\x00", 1))); // U+0080 PADDING CHARACTER EXPECT_TRUE(CheckConvertUTF8ToUnicodeScalars( @@ -1075,7 +1075,7 @@ TEST(ConvertUTFTest, UTF8ToUTF32Lenient) { // U+0000 NULL EXPECT_TRUE(CheckConvertUTF8ToUnicodeScalars( ConvertUTFResultContainer(conversionOK).withScalars(0x0000), - StringRef("\x00", 1))); + std::string_view("\x00", 1))); // Overlong sequences of the above. EXPECT_TRUE(CheckConvertUTF8ToUnicodeScalars(