mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-19 00:41:43 +00:00
32cd2ddf8e
Semiwrap / meson / robotpy define `NDEBUG` when building their software in all modes, while `allwplib` only does it when building debug. This causes the size of `DenseMap` to differ between the shared libraries built here, and the extension modules built in `mostrobotpy`, causing segfaults when you try to execute code that uses `DenseMap`. This is not a problem with the robotpy code in `allwpilib`, because bazel uses the exact same compiler flags when building the shared libraries and pybind11 extensions.
27 lines
1.1 KiB
Diff
27 lines
1.1 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Tyler Veness <calcmogul@gmail.com>
|
|
Date: Sun, 30 Jul 2023 14:17:37 -0700
|
|
Subject: [PATCH 28/35] Remove DenseMap GTest printer test
|
|
|
|
LLVM modifies internal GTest headers to support it, which we can't do.
|
|
---
|
|
llvm/unittests/ADT/DenseMapTest.cpp | 7 -------
|
|
1 file changed, 7 deletions(-)
|
|
|
|
diff --git a/llvm/unittests/ADT/DenseMapTest.cpp b/llvm/unittests/ADT/DenseMapTest.cpp
|
|
index b930a21f8b43b64835436fcd27f4802a7987827f..b49100899c658fa952d37e526880913d57d07c5c 100644
|
|
--- a/llvm/unittests/ADT/DenseMapTest.cpp
|
|
+++ b/llvm/unittests/ADT/DenseMapTest.cpp
|
|
@@ -761,11 +761,4 @@ TEST(DenseMapCustomTest, VariantSupport) {
|
|
EXPECT_FALSE(DenseMapInfo<variant>::isEqual(Keys[2], Keys[2]));
|
|
}
|
|
|
|
-// Test that gTest prints map entries as pairs instead of opaque objects.
|
|
-// See third-party/unittest/googletest/internal/custom/gtest-printers.h
|
|
-TEST(DenseMapCustomTest, PairPrinting) {
|
|
- DenseMap<int, std::string_view> Map = {{1, "one"}, {2, "two"}};
|
|
- EXPECT_EQ(R"({ (1, "one"), (2, "two") })", ::testing::PrintToString(Map));
|
|
-}
|
|
-
|
|
} // namespace
|