Files
allwpilib/apriltag
Gold856 35e8abedeb Don't force public variables to use Hungarian notation (#8774)
People generally have expressed a dislike for the Hungarian notation
used in member variables, especially in examples/templates, and our
styleguide shouldn't be forced on downstream consumers, so this removes
all Hungarian notation from the examples/templates.

There are _some_ benefits to Hungarian for private member variables
(like knowing what's a member vs. local in a PR review) so we'll keep
private member variables the same for now, but public variables should
no longer use Hungarian notation, since it looks much worse. A new PMD
XPath rule has been added to accomplish this goal. Some other
non-compliant variables were fixed for the new rule.
2026-04-25 11:32:08 -07:00
..
2026-03-13 23:05:55 -07:00

AprilTag

Adding new field to AprilTagFields

Adding field JSON

  1. Add a field layout CSV file to src/main/native/resources/edu/wpi/first/apriltag
    1. See docstring in convert_apriltag_layouts.py for more
  2. Run convert_apriltag_layouts.py in the same directory as this readme to generate the JSON
  3. That script overwrites all generated JSONs, so undo undesired changes if necessary
  4. Update the field dimensions at the bottom of the JSON
    1. Length should be in meters from alliance wall to alliance wall
    2. Width should be in meters from inside guardrail plastic to plastic

Java updates

  1. Update src/main/java/edu/wpi/first/apriltag/AprilTagFields.java
    1. Add enum value for new field to AprilTagFields
    2. Update AprilTagFields.kDefaultField if necessary

C++ updates

  1. Update src/main/native/include/wpi/apriltag/AprilTagFields.hpp
    1. Add enum value for new field to AprilTagFields
    2. Update AprilTagFields::kDefaultField if necessary
  2. Update src/main/native/cpp/AprilTagFields.cpp
    1. Add resource getter prototype like std::string_view GetResource_2024_crescendo_json()
    2. Add case for new field to switch in LoadAprilTagLayoutField()