mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-19 00:41:43 +00:00
35e8abedeb
People generally have expressed a dislike for the Hungarian notation used in member variables, especially in examples/templates, and our styleguide shouldn't be forced on downstream consumers, so this removes all Hungarian notation from the examples/templates. There are _some_ benefits to Hungarian for private member variables (like knowing what's a member vs. local in a PR review) so we'll keep private member variables the same for now, but public variables should no longer use Hungarian notation, since it looks much worse. A new PMD XPath rule has been added to accomplish this goal. Some other non-compliant variables were fixed for the new rule.
35 lines
887 B
C++
35 lines
887 B
C++
// Copyright (c) FIRST and other WPILib contributors.
|
|
// Open Source Software; you can modify and/or share it under the terms of
|
|
// the WPILib BSD license file in the root directory of this project.
|
|
|
|
#pragma once
|
|
|
|
#include "Constants.hpp"
|
|
#include "wpi/commands2/SubsystemBase.hpp"
|
|
#include "wpi/hardware/pneumatic/DoubleSolenoid.hpp"
|
|
#include "wpi/hardware/pneumatic/PneumaticsControlModule.hpp"
|
|
|
|
class HatchSubsystem : public wpi::cmd::SubsystemBase {
|
|
public:
|
|
HatchSubsystem();
|
|
|
|
// Subsystem methods go here.
|
|
|
|
/**
|
|
* Grabs the hatch.
|
|
*/
|
|
void GrabHatch();
|
|
|
|
/**
|
|
* Releases the hatch.
|
|
*/
|
|
void ReleaseHatch();
|
|
|
|
void InitSendable(wpi::util::SendableBuilder& builder) override;
|
|
|
|
private:
|
|
// Components (e.g. motor controllers and sensors) should generally be
|
|
// declared private and exposed only through public methods.
|
|
wpi::DoubleSolenoid hatchSolenoid;
|
|
};
|