mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-19 00:41:43 +00:00
a9ac5b8e24
Reading exported data from shared objects on windows is broken. It requires __declspec(dllimport). However, this is problematic, as we use the same static libraries both from a shared and static context. So we can't just blindly apply dllimport. The linker should have caught this, as data members are exported in a different way. However, due to a bug in native-utils, data member symbols were exposed directly. However, interacting with those data member was completely broken. The only way we can really solve this is to just not use static data members. We're pretty good about this in WPILib itself. However, protobuf is absolutely terrible at this. There are a ton of inline functions that access global data. For the protobuf library itself, we can solve this easily enough. However, for the generated protobuf code, this is much more problematic. The member needed to bypass the global data is private. This means using just the stock protobuf code, this problem is not solvable. But, protobuf generated code has insertion points. Those insertion points let us add our own code into the generated code via a protoc plugin. And it just so happens that an insertion point exists to add extra public methodsto the generated protobuf header. There is also an insertion point to let us add to the cpp file. The methods we need are the getters, for unpacking protobufs. For any protobuf that has a message as a member, we generate a new wpi_x() getter (the existing one is just x(), where x is the field name). We then implement this in the cpp file. A trick we can use is in the cpp file, we can safely call the x() function, as the cpp file is in the same library as the global. Thus we can call that inline method, and not actually need to directly access any internal private state of the protobuf object. TL;DR, all protobuf classes that have messages as fields now have a wpi_x() accessor that must be used instead of x() if you want the code to work on windows. After wpilibsuite/native-utils#212, the bad code will fail to link, rather then just fail at runtime.
37 lines
1.3 KiB
Diff
37 lines
1.3 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Peter Johnson <johnson.peter@gmail.com>
|
|
Date: Sat, 10 Jun 2023 15:13:45 -0700
|
|
Subject: [PATCH 05/13] Suppress enum-enum conversion warning
|
|
|
|
---
|
|
src/google/protobuf/generated_message_tctable_impl.h | 9 +++++++++
|
|
1 file changed, 9 insertions(+)
|
|
|
|
diff --git a/src/google/protobuf/generated_message_tctable_impl.h b/src/google/protobuf/generated_message_tctable_impl.h
|
|
index 21fa5332d39b24e0bdb6432f27183df743d512c6..ce3d9110e28706ca18dcf0f2c94feba75f447dc7 100644
|
|
--- a/src/google/protobuf/generated_message_tctable_impl.h
|
|
+++ b/src/google/protobuf/generated_message_tctable_impl.h
|
|
@@ -180,6 +180,12 @@ static_assert(kFmtShift + kFmtBits == 12, "number of bits changed");
|
|
// This assertion should not change unless the storage width changes:
|
|
static_assert(kFmtShift + kFmtBits <= 16, "too many bits");
|
|
|
|
+#ifdef __GNUC__
|
|
+#pragma GCC diagnostic push
|
|
+#if __GNUC__ >= 12 || (__GNUC__ == 11 && __GNUC_MINOR >= 1)
|
|
+#pragma GCC diagnostic ignored "-Wdeprecated-enum-enum-conversion"
|
|
+#endif
|
|
+#endif
|
|
// Convenience aliases (16 bits, with format):
|
|
enum FieldType : uint16_t {
|
|
// Numeric types:
|
|
@@ -232,6 +238,9 @@ enum FieldType : uint16_t {
|
|
// Map types:
|
|
kMap = kFkMap,
|
|
};
|
|
+#ifdef __GNUC__
|
|
+#pragma GCC diagnostic pop
|
|
+#endif
|
|
|
|
// clang-format on
|
|
} // namespace field_layout
|